From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Udit Kumar <udit.kumar@nxp.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes.
Date: Thu, 10 May 2018 14:06:49 -0500 [thread overview]
Message-ID: <1525979209.3002.18.camel@arm.com> (raw)
In-Reply-To: <AM6PR0402MB3334F3E72A3063FEEEB2452491990@AM6PR0402MB3334.eurprd04.prod.outlook.com>
On Wed, 2018-05-09 at 20:57 +0000, Udit Kumar wrote:
>
> >
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > Of
> > Supreeth Venkatesh
> > Sent: Saturday, May 5, 2018 2:11 AM
> > To: edk2-devel@lists.01.org
> > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; jiewen.yao
> > @intel.com;
> > liming.gao@intel.com; michael.d.kinney@intel.com
> > Subject: [edk2] [PATCH v2 03/17] ArmPkg/Include: Add MM interface
> > SVC return
> > codes.
> >
> > This patch adds the Management Mode(MM) - Secure Partition
> > Manager(SPM)
> > SVC return codes.
> > Also, It corrects SVC ID for retrieving SPM version information.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Achin Gupta <achin.gupta@arm.com>
> > Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> > ---
> > ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
> > b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
> > index 4c7b6c3386..a64b9ec23c 100644
> > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
> > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
> > @@ -20,7 +20,7 @@
> > * delegated events and request the Secure partition manager to
> > perform
> > * privileged operations on its behalf.
> > */
> > -#define ARM_SVC_ID_SPM_VERSION_AARCH64 0xC4000060
> > +#define ARM_SVC_ID_SPM_VERSION_AARCH32 0x84000060
> > #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64 0xC4000061
> > #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64 0xC4000064
> > #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64 0xC4000065
> > @@ -40,4 +40,11 @@
> > ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) <<
> > SET_MEM_ATTR_CODE_PERM_SHIFT) | \
> > (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) <<
> > SET_MEM_ATTR_DATA_PERM_SHIFT))
> >
> > +/* MM SVC Return error codes */
> > +#define ARM_SVC_SPM_RET_SUCCESS 0
> > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED -1
> > +#define ARM_SVC_SPM_RET_INVALID_PARAMS -2
> > +#define ARM_SVC_SPM_RET_DENIED -3
> > +#define ARM_SVC_SPM_RET_NO_MEMORY -5
> Please see if you want to define errors as negative.
> AFAIK, in edk2 negative errors are not used
>
These defines are for SPM in arm-tf (https://github.com/ARM-software/ar
m-trusted-firmware/blob/master/docs/secure-partition-manager-
design.rst#error-codes) and MM edk2 code converts these error return
codes to standard EFI error codes.
> >
> > +
> > #endif
> > --
> > 2.16.2
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > lists.01
> > .org%2Fmailman%2Flistinfo%2Fedk2-
> > devel&data=02%7C01%7Cudit.kumar%40nxp.com%7Ca6dc7d4a80e24bad73b80
> > 8d5b1ff6f28%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63661063
> > 3010245207&sdata=IHWYNFk0W2OKDQ%2BYEkJFmpi14mkXJyhblAdZQK7jM%2
> > B0%3D&reserved=0
next prev parent reply other threads:[~2018-05-10 19:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 20:40 [PATCH v2 00/17] *** Standalone Management Mode Core Interface for AARCH64 Platforms *** Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 01/17] ArmPkg: Add PCDs needed for MM communication driver Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 02/17] ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver Supreeth Venkatesh
2018-05-09 20:52 ` Udit Kumar
2018-05-10 19:46 ` Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes Supreeth Venkatesh
2018-05-09 20:57 ` Udit Kumar
2018-05-10 19:06 ` Supreeth Venkatesh [this message]
2018-05-04 20:40 ` [PATCH v2 04/17] ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0 Supreeth Venkatesh
2018-05-09 21:09 ` Udit Kumar
2018-05-10 19:02 ` Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 05/17] ArmPkg/ArmMmuLib: Add MMU library inf file " Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 06/17] StandaloneMmPkg: Delete StandaloneMmPkg file Supreeth Venkatesh
2018-05-04 20:40 ` [PATCH v2 07/17] StandaloneMmPkg/FvLib: Add a common FV Library for management mode Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 08/17] StandaloneMmPkg/MemLib: Add Standalone MM instance of memory check library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 09/17] StandaloneMmPkg/MemoryAllocationLib: Add MM memory allocation library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 10/17] StandaloneMmPkg/HobLib: Add HOB Library for management mode Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 11/17] StandaloneMmPkg: MM driver entry point library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 12/17] StandaloneMmPkg/Core: Implementation of Standalone MM Core Module Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 13/17] StandaloneMmPkg: Add an AArch64 specific entry point library Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 14/17] StandaloneMmPkg: Add CPU driver suitable for ARM Platforms Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 15/17] StandaloneMmPkg: Describe the declaration and definition files Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 16/17] ArmPkg: Extra action to update permissions for S-ELO MM Image Supreeth Venkatesh
2018-05-04 20:41 ` [PATCH v2 17/17] BaseTools/AutoGen: Update header file for MM modules Supreeth Venkatesh
2018-05-07 15:11 ` Gao, Liming
2018-05-07 19:16 ` Supreeth Venkatesh
2018-06-04 22:16 ` Supreeth Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525979209.3002.18.camel@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox