From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id E28EA203B9931 for ; Thu, 10 May 2018 12:06:50 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE10C80D; Thu, 10 May 2018 12:06:50 -0700 (PDT) Received: from [10.0.2.15] (U203142.usa.Arm.com [10.118.30.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74C713F23C; Thu, 10 May 2018 12:06:50 -0700 (PDT) Message-ID: <1525979209.3002.18.camel@arm.com> From: Supreeth Venkatesh To: Udit Kumar , "edk2-devel@lists.01.org" Date: Thu, 10 May 2018 14:06:49 -0500 In-Reply-To: References: <20180504204109.3354-1-supreeth.venkatesh@arm.com> <20180504204109.3354-4-supreeth.venkatesh@arm.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Subject: Re: [PATCH v2 03/17] ArmPkg/Include: Add MM interface SVC return codes. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 19:06:51 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Wed, 2018-05-09 at 20:57 +0000, Udit Kumar wrote: > > > > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf > > Of > > Supreeth Venkatesh > > Sent: Saturday, May 5, 2018 2:11 AM > > To: edk2-devel@lists.01.org > > Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; jiewen.yao > > @intel.com; > > liming.gao@intel.com; michael.d.kinney@intel.com > > Subject: [edk2] [PATCH v2 03/17] ArmPkg/Include: Add MM interface > > SVC return > > codes. > > > > This patch adds the Management Mode(MM) - Secure Partition > > Manager(SPM) > > SVC return codes. > > Also, It corrects SVC ID for retrieving SPM version information. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Achin Gupta > > Signed-off-by: Supreeth Venkatesh > > --- > >  ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 9 ++++++++- > >  1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > > b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > > index 4c7b6c3386..a64b9ec23c 100644 > > --- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > > +++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h > > @@ -20,7 +20,7 @@ > >   * delegated events and request the Secure partition manager to > > perform > >   * privileged operations on its behalf. > >   */ > > -#define ARM_SVC_ID_SPM_VERSION_AARCH64             0xC4000060 > > +#define ARM_SVC_ID_SPM_VERSION_AARCH32             0x84000060 > >  #define ARM_SVC_ID_SP_EVENT_COMPLETE_AARCH64       0xC4000061 > >  #define ARM_SVC_ID_SP_GET_MEM_ATTRIBUTES_AARCH64   0xC4000064 > >  #define ARM_SVC_ID_SP_SET_MEM_ATTRIBUTES_AARCH64   0xC4000065 > > @@ -40,4 +40,11 @@ > >      ((((c_perm) & SET_MEM_ATTR_CODE_PERM_MASK) << > > SET_MEM_ATTR_CODE_PERM_SHIFT) | \ > >      (( (d_perm) & SET_MEM_ATTR_DATA_PERM_MASK) << > > SET_MEM_ATTR_DATA_PERM_SHIFT)) > > > > +/* MM SVC Return error codes */ > > +#define ARM_SVC_SPM_RET_SUCCESS               0 > > +#define ARM_SVC_SPM_RET_NOT_SUPPORTED        -1 > > +#define ARM_SVC_SPM_RET_INVALID_PARAMS       -2 > > +#define ARM_SVC_SPM_RET_DENIED               -3 > > +#define ARM_SVC_SPM_RET_NO_MEMORY            -5 > Please see if you want to define errors as negative. > AFAIK, in edk2 negative errors are not used  > These defines are for SPM in arm-tf (https://github.com/ARM-software/ar m-trusted-firmware/blob/master/docs/secure-partition-manager- design.rst#error-codes) and MM edk2 code converts these error return codes to standard EFI error codes.  > > > > + > >  #endif > > -- > > 2.16.2 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > lists.01 > > .org%2Fmailman%2Flistinfo%2Fedk2- > > devel&data=02%7C01%7Cudit.kumar%40nxp.com%7Ca6dc7d4a80e24bad73b80 > > 8d5b1ff6f28%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63661063 > > 3010245207&sdata=IHWYNFk0W2OKDQ%2BYEkJFmpi14mkXJyhblAdZQK7jM%2 > > B0%3D&reserved=0