From: Jordan Justen <jordan.l.justen@intel.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Marvin Häuser" <Marvin.Haeuser@outlook.com>
Cc: "afish@apple.com" <afish@apple.com>
Subject: Re: [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class.
Date: Thu, 24 May 2018 13:36:33 -0700 [thread overview]
Message-ID: <152719419292.1535.16346737535215645719@jljusten-skl> (raw)
In-Reply-To: <VI1PR0801MB17908A4F6D966E3DDD79B68A80910@VI1PR0801MB1790.eurprd08.prod.outlook.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Pushed as 7dc7c7435e.
On 2018-05-17 05:43:30, Marvin Häuser wrote:
> Currently, SmbiosLib declares the PcdLib library class. Update the
> declaration to declare SmbiosLib.
>
> V2:
> - Do not change the copyright date as requested.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
> EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> index adcd7ef08e20..36d5c350f51a 100644
> --- a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> +++ b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
> @@ -20,7 +20,7 @@ [Defines]
> FILE_GUID = 881863A2-09FD-3E44-8D62-7AE038D03747
> MODULE_TYPE = DXE_DRIVER
> VERSION_STRING = 1.0
> - LIBRARY_CLASS = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
> + LIBRARY_CLASS = SmbiosLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER
>
> CONSTRUCTOR = SmbiosLibConstructor
>
> --
> 2.17.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-05-24 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 12:43 [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class Marvin Häuser
2018-05-24 20:36 ` Jordan Justen [this message]
2018-05-24 20:51 ` Laszlo Ersek
2018-05-24 20:56 ` Marvin Häuser
2018-05-25 14:19 ` Carsey, Jaben
2018-05-25 15:00 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152719419292.1535.16346737535215645719@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox