* [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
@ 2018-06-01 13:58 Marcin Wojtas
2018-06-01 14:00 ` Ard Biesheuvel
2018-06-01 14:35 ` Gao, Liming
0 siblings, 2 replies; 4+ messages in thread
From: Marcin Wojtas @ 2018-06-01 13:58 UTC (permalink / raw)
To: edk2-devel
Cc: feng.tian, michael.d.kinney, liming.gao, leif.lindholm,
ard.biesheuvel, jsd, Marcin Wojtas
Until now the possible errors returned from processing
boot firmware volume were not checked, which could cause
misbehavior in further booting stages. Add relevant assert.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Jan Dabros <jsd@semihalf.com>
---
MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
index 8009546..4150b33 100644
--- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
+++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
@@ -495,12 +495,13 @@ PeiInitializeFv (
//
// Get handle of BFV
//
- FvPpi->ProcessVolume (
- FvPpi,
- SecCoreData->BootFirmwareVolumeBase,
- (UINTN)BfvHeader->FvLength,
- &FvHandle
- );
+ Status = FvPpi->ProcessVolume (
+ FvPpi,
+ SecCoreData->BootFirmwareVolumeBase,
+ (UINTN)BfvHeader->FvLength,
+ &FvHandle
+ );
+ ASSERT_EFI_ERROR (Status);
//
// Update internal PEI_CORE_FV array.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
2018-06-01 13:58 [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV Marcin Wojtas
@ 2018-06-01 14:00 ` Ard Biesheuvel
2018-06-04 5:30 ` Zeng, Star
2018-06-01 14:35 ` Gao, Liming
1 sibling, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2018-06-01 14:00 UTC (permalink / raw)
To: Marcin Wojtas, Zeng, Star, Eric Dong
Cc: edk2-devel@lists.01.org, Tian, Feng, Kinney, Michael D,
Gao, Liming, Leif Lindholm, Jan Dąbroś
(+ MdeModulePkg maintainers)
On 1 June 2018 at 15:58, Marcin Wojtas <mw@semihalf.com> wrote:
> Until now the possible errors returned from processing
> boot firmware volume were not checked, which could cause
> misbehavior in further booting stages. Add relevant assert.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> index 8009546..4150b33 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> @@ -495,12 +495,13 @@ PeiInitializeFv (
> //
> // Get handle of BFV
> //
> - FvPpi->ProcessVolume (
> - FvPpi,
> - SecCoreData->BootFirmwareVolumeBase,
> - (UINTN)BfvHeader->FvLength,
> - &FvHandle
> - );
> + Status = FvPpi->ProcessVolume (
> + FvPpi,
> + SecCoreData->BootFirmwareVolumeBase,
> + (UINTN)BfvHeader->FvLength,
> + &FvHandle
> + );
> + ASSERT_EFI_ERROR (Status);
>
> //
> // Update internal PEI_CORE_FV array.
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
2018-06-01 13:58 [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV Marcin Wojtas
2018-06-01 14:00 ` Ard Biesheuvel
@ 2018-06-01 14:35 ` Gao, Liming
1 sibling, 0 replies; 4+ messages in thread
From: Gao, Liming @ 2018-06-01 14:35 UTC (permalink / raw)
To: Marcin Wojtas, edk2-devel@lists.01.org
Cc: Tian, Feng, Kinney, Michael D, leif.lindholm@linaro.org,
ard.biesheuvel@linaro.org, jsd@semihalf.com
I agree to add this checker.
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Marcin Wojtas [mailto:mw@semihalf.com]
> Sent: Friday, June 1, 2018 9:58 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>;
> leif.lindholm@linaro.org; ard.biesheuvel@linaro.org; jsd@semihalf.com; Marcin Wojtas <mw@semihalf.com>
> Subject: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
>
> Until now the possible errors returned from processing
> boot firmware volume were not checked, which could cause
> misbehavior in further booting stages. Add relevant assert.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> index 8009546..4150b33 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> @@ -495,12 +495,13 @@ PeiInitializeFv (
> //
> // Get handle of BFV
> //
> - FvPpi->ProcessVolume (
> - FvPpi,
> - SecCoreData->BootFirmwareVolumeBase,
> - (UINTN)BfvHeader->FvLength,
> - &FvHandle
> - );
> + Status = FvPpi->ProcessVolume (
> + FvPpi,
> + SecCoreData->BootFirmwareVolumeBase,
> + (UINTN)BfvHeader->FvLength,
> + &FvHandle
> + );
> + ASSERT_EFI_ERROR (Status);
>
> //
> // Update internal PEI_CORE_FV array.
> --
> 2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
2018-06-01 14:00 ` Ard Biesheuvel
@ 2018-06-04 5:30 ` Zeng, Star
0 siblings, 0 replies; 4+ messages in thread
From: Zeng, Star @ 2018-06-04 5:30 UTC (permalink / raw)
To: Ard Biesheuvel, Marcin Wojtas, Dong, Eric
Cc: Tian, Feng, edk2-devel@lists.01.org, Leif Lindholm, Gao, Liming,
Kinney, Michael D, Zeng, Star
Reviewed-by: Star Zeng <star.zeng@intel.com>
Pushed at 38c977c148e92e2af17c5d346d9b4b2e7a18680a.
Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel
Sent: Friday, June 1, 2018 10:00 PM
To: Marcin Wojtas <mw@semihalf.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Cc: Tian, Feng <feng.tian@intel.com>; edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2] [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV
(+ MdeModulePkg maintainers)
On 1 June 2018 at 15:58, Marcin Wojtas <mw@semihalf.com> wrote:
> Until now the possible errors returned from processing boot firmware
> volume were not checked, which could cause misbehavior in further
> booting stages. Add relevant assert.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> ---
> MdeModulePkg/Core/Pei/FwVol/FwVol.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> index 8009546..4150b33 100644
> --- a/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> +++ b/MdeModulePkg/Core/Pei/FwVol/FwVol.c
> @@ -495,12 +495,13 @@ PeiInitializeFv (
> //
> // Get handle of BFV
> //
> - FvPpi->ProcessVolume (
> - FvPpi,
> - SecCoreData->BootFirmwareVolumeBase,
> - (UINTN)BfvHeader->FvLength,
> - &FvHandle
> - );
> + Status = FvPpi->ProcessVolume (
> + FvPpi,
> + SecCoreData->BootFirmwareVolumeBase,
> + (UINTN)BfvHeader->FvLength,
> + &FvHandle
> + );
> + ASSERT_EFI_ERROR (Status);
>
> //
> // Update internal PEI_CORE_FV array.
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 5:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-01 13:58 [PATCH] MdeModulePkg PeiCore: Check error status when processing boot FV Marcin Wojtas
2018-06-01 14:00 ` Ard Biesheuvel
2018-06-04 5:30 ` Zeng, Star
2018-06-01 14:35 ` Gao, Liming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox