* [Patch] FDF spec: Correct the example with SET statement in [FD] section
@ 2018-06-04 9:22 Liming Gao
2018-06-05 5:36 ` Zhu, Yonghong
0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2018-06-04 9:22 UTC (permalink / raw)
To: edk2-devel
Region base address needs to add FD base address as the final value.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
2_fdf_design_discussion/24_[fd]_sections.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
index d55b793..04053a0 100644
--- a/2_fdf_design_discussion/24_[fd]_sections.md
+++ b/2_fdf_design_discussion/24_[fd]_sections.md
@@ -212,7 +212,7 @@ gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress | gEfiMyTokenSpaceGuid.PcdFlashFv
FV = FvMain
0x000000|0x0C0000
-SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000
+SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000 + $(BaseAddress)
SET gEfiMyTokenSpaceGuid.PcdFlashFvMainSize = 0x0C0000
FV = FvMain
```
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] FDF spec: Correct the example with SET statement in [FD] section
2018-06-04 9:22 [Patch] FDF spec: Correct the example with SET statement in [FD] section Liming Gao
@ 2018-06-05 5:36 ` Zhu, Yonghong
0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-06-05 5:36 UTC (permalink / raw)
To: Gao, Liming, edk2-devel@lists.01.org
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Gao, Liming
Sent: Monday, June 04, 2018 5:22 PM
To: edk2-devel@lists.01.org
Cc: Sean Brogan <sean.brogan@microsoft.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch] FDF spec: Correct the example with SET statement in [FD] section
Region base address needs to add FD base address as the final value.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>
---
2_fdf_design_discussion/24_[fd]_sections.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/2_fdf_design_discussion/24_[fd]_sections.md b/2_fdf_design_discussion/24_[fd]_sections.md
index d55b793..04053a0 100644
--- a/2_fdf_design_discussion/24_[fd]_sections.md
+++ b/2_fdf_design_discussion/24_[fd]_sections.md
@@ -212,7 +212,7 @@ gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress | gEfiMyTokenSpaceGuid.PcdFlashFv FV = FvMain
0x000000|0x0C0000
-SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000
+SET gEfiMyTokenSpaceGuid.PcdFlashFvMainBaseAddress = 0x000000 +
+$(BaseAddress)
SET gEfiMyTokenSpaceGuid.PcdFlashFvMainSize = 0x0C0000
FV = FvMain
```
--
2.8.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-05 5:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-04 9:22 [Patch] FDF spec: Correct the example with SET statement in [FD] section Liming Gao
2018-06-05 5:36 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox