From: Star Zeng <star.zeng@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH 1/2] MdePkg UefiLib: Fix in EfiLocateProtocolBuffer()
Date: Mon, 4 Jun 2018 18:10:55 +0800 [thread overview]
Message-ID: <1528107056-53060-2-git-send-email-star.zeng@intel.com> (raw)
In-Reply-To: <1528107056-53060-1-git-send-email-star.zeng@intel.com>
Free HandleBuffer for error path in EfiLocateProtocolBuffer().
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdePkg/Library/UefiLib/UefiLib.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
index 23faa63226ef..9ade1b0ce1a0 100644
--- a/MdePkg/Library/UefiLib/UefiLib.c
+++ b/MdePkg/Library/UefiLib/UefiLib.c
@@ -1678,6 +1678,10 @@ EfiLocateProtocolBuffer (
(VOID **)Buffer
);
if (EFI_ERROR (Status)) {
+ //
+ // Free the handle buffer
+ //
+ gBS->FreePool (HandleBuffer);
return EFI_OUT_OF_RESOURCES;
}
ZeroMem (*Buffer, NoHandles * sizeof (VOID *));
--
2.7.0.windows.1
next prev parent reply other threads:[~2018-06-04 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 10:10 [PATCH 0/2] UefiLib: Free HandleBuffer for error path in EfiLocateProtocolBuffer() Star Zeng
2018-06-04 10:10 ` Star Zeng [this message]
2018-06-04 10:10 ` [PATCH 2/2] IntelFrameworkPkg FrameworkUefiLib: Fix " Star Zeng
2018-06-04 21:50 ` [PATCH 0/2] UefiLib: Free HandleBuffer for error path " Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528107056-53060-2-git-send-email-star.zeng@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox