[PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support
@ 2018-06-12 20:14 Udit Kumar
  2018-06-12 20:14 ` [PATCH v3 1/2] " Udit Kumar
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Udit Kumar @ 2018-06-12 20:14 UTC (permalink / raw)
  To: ard.biesheuvel, leif.lindholm, edk2-devel

[v3]
  Incorporated review comments of v2

[v2]
   Incorporated review comments of v1



Udit Kumar (2):
  ArmPlatformPkg: PL011 Dynamic clock freq Support
  ArmPlatformPkg: Include PL011UartClock Lib

 ArmPlatformPkg/ArmPlatformPkg.dec                  |  1 +
 ArmPlatformPkg/ArmPlatformPkg.dsc                  |  1 +
 ArmPlatformPkg/Include/Library/PL011UartClockLib.h | 31 +++++++++++++++++++
 .../PL011SerialPortLib/PL011SerialPortLib.c        |  5 +--
 .../PL011SerialPortLib/PL011SerialPortLib.inf      |  1 +
 .../Library/PL011UartClockLib/PL011UartClockLib.c  | 29 +++++++++++++++++
 .../PL011UartClockLib/PL011UartClockLib.inf        | 36 ++++++++++++++++++++++
 7 files changed, 102 insertions(+), 2 deletions(-)
 create mode 100644 ArmPlatformPkg/Include/Library/PL011UartClockLib.h
 create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
 create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf

-- 
1.9.1



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/2] ArmPlatformPkg: PL011 Dynamic clock freq Support
  2018-06-12 20:14 [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Udit Kumar
@ 2018-06-12 20:14 ` Udit Kumar
  2018-06-12 20:14 ` [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib Udit Kumar
  2018-06-13  9:49 ` [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Ard Biesheuvel
  2 siblings, 0 replies; 5+ messages in thread
From: Udit Kumar @ 2018-06-12 20:14 UTC (permalink / raw)
  To: ard.biesheuvel, leif.lindholm, edk2-devel

Some platform support dynamic clocking, Which is controlled
by some jumper setting or hardware registers.
Result of that PCD PL011UartClkInHz needs to be updated for
frequency change.
This patch implements support for dynamic frequency for
PL011 uart.
This patch implements default lib, which is using Pcd.
Platform which needs dynamic clocking needs implement
PL011UartClockLib

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
---
 ArmPlatformPkg/ArmPlatformPkg.dec                  |  1 +
 ArmPlatformPkg/ArmPlatformPkg.dsc                  |  1 +
 ArmPlatformPkg/Include/Library/PL011UartClockLib.h | 31 +++++++++++++++++++
 .../Library/PL011UartClockLib/PL011UartClockLib.c  | 29 +++++++++++++++++
 .../PL011UartClockLib/PL011UartClockLib.inf        | 36 ++++++++++++++++++++++
 5 files changed, 98 insertions(+)
 create mode 100644 ArmPlatformPkg/Include/Library/PL011UartClockLib.h
 create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
 create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index dff4598..5f67e74 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -36,6 +36,7 @@
   LcdHwLib|Include/Library/LcdHwLib.h
   LcdPlatformLib|Include/Library/LcdPlatformLib.h
   NorFlashPlatformLib|Include/Library/NorFlashPlatformLib.h
+  PL011UartClockLib|Include/Library/PL011UartClockLib.h
   PL011UartLib|Include/Library/PL011UartLib.h
 
 [Guids.common]
diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
index 0013106..d504e76 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dsc
+++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
@@ -105,6 +105,7 @@
   ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.inf
   ArmPlatformPkg/Library/NorFlashPlatformNullLib/NorFlashPlatformNullLib.inf
   ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
+  ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
   ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.inf
   ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf
   ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
diff --git a/ArmPlatformPkg/Include/Library/PL011UartClockLib.h b/ArmPlatformPkg/Include/Library/PL011UartClockLib.h
new file mode 100644
index 0000000..04c7d51
--- /dev/null
+++ b/ArmPlatformPkg/Include/Library/PL011UartClockLib.h
@@ -0,0 +1,31 @@
+/** @file
+*
+*  Copyright 2018 NXP
+*
+*  This program and the accompanying materials
+*  are licensed and made available under the terms and conditions of the BSD License
+*  which accompanies this distribution.  The full text of the license may be found at
+*  http://opensource.org/licenses/bsd-license.php
+*
+*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+*
+**/
+
+#ifndef __PL011UARTCLOCKLIB_H__
+#define __PL011UARTCLOCKLIB_H__
+
+/**
+
+  Return baud clock frequency of  PL011.
+
+  @return return frequency of PL011 in Hz
+
+**/
+UINT32
+EFIAPI
+PL011UartClockGetFreq (
+  VOID
+  );
+
+#endif
diff --git a/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
new file mode 100644
index 0000000..6f0f61c
--- /dev/null
+++ b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
@@ -0,0 +1,29 @@
+/** @file
+*
+*  Copyright 2018 NXP
+*
+*  This program and the accompanying materials
+*  are licensed and made available under the terms and conditions of the BSD License
+*  which accompanies this distribution.  The full text of the license may be found at
+*  http://opensource.org/licenses/bsd-license.php
+*
+*  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+*  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+*
+**/
+
+#include <Library/PL011UartClockLib.h>
+
+/**
+  Return clock in for PL011 Uart IP
+
+  @return Pcd PL011UartClkInHz
+**/
+UINT32
+EFIAPI
+PL011UartClockGetFreq (
+  VOID
+  )
+{
+  return FixedPcdGet32 (PL011UartClkInHz);
+}
diff --git a/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
new file mode 100644
index 0000000..90193e6
--- /dev/null
+++ b/ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
@@ -0,0 +1,36 @@
+#/* @file
+#  Copyright 2018 NXP
+#
+#  This program and the accompanying materials
+#  are licensed and made available under the terms and conditions of the BSD License
+#  which accompanies this distribution.  The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#*/
+
+[Defines]
+  INF_VERSION                    = 0x0001001A
+  BASE_NAME                      = BasePL011UartClockLib
+  FILE_GUID                      = af8fef24-afbb-472a-b8b7-13101a79703c
+  MODULE_TYPE                    = BASE
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = PL011UartClockLib
+
+[Packages]
+  ArmPkg/ArmPkg.dec
+  ArmPlatformPkg/ArmPlatformPkg.dec
+  MdePkg/MdePkg.dec
+
+[LibraryClasses]
+  ArmLib
+  DebugLib
+
+[Sources.common]
+  PL011UartClockLib.c
+
+[FixedPcd]
+  gArmPlatformTokenSpaceGuid.PL011UartClkInHz
+
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib
  2018-06-12 20:14 [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Udit Kumar
  2018-06-12 20:14 ` [PATCH v3 1/2] " Udit Kumar
@ 2018-06-12 20:14 ` Udit Kumar
  2018-06-15 10:58   ` Ard Biesheuvel
  2018-06-13  9:49 ` [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Ard Biesheuvel
  2 siblings, 1 reply; 5+ messages in thread
From: Udit Kumar @ 2018-06-12 20:14 UTC (permalink / raw)
  To: ard.biesheuvel, leif.lindholm, edk2-devel

This patch gets PL011 baud rate clock from
pl011 uart clock lib instead of Pcd.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Udit Kumar <udit.kumar@nxp.com>
---
 ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c   | 5 +++--
 ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
index 6aa8063..212991d 100644
--- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
+++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
@@ -19,6 +19,7 @@
 
 #include <Library/IoLib.h>
 #include <Library/PcdLib.h>
+#include <Library/PL011UartClockLib.h>
 #include <Library/PL011UartLib.h>
 #include <Library/SerialPortLib.h>
 
@@ -48,7 +49,7 @@ SerialPortInitialize (
 
   return PL011UartInitializePort (
            (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
-           FixedPcdGet32 (PL011UartClkInHz),
+           PL011UartClockGetFreq(),
            &BaudRate,
            &ReceiveFifoDepth,
            &Parity,
@@ -156,7 +157,7 @@ SerialPortSetAttributes (
 {
   return PL011UartInitializePort (
            (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
-           FixedPcdGet32 (PL011UartClkInHz),
+           PL011UartClockGetFreq(),
            BaudRate,
            ReceiveFifoDepth,
            Parity,
diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
index 3683e06..5ce5b2f 100644
--- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
+++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
@@ -26,6 +26,7 @@
   PL011SerialPortLib.c
 
 [LibraryClasses]
+  PL011UartClockLib
   PL011UartLib
   PcdLib
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib
  2018-06-12 20:14 ` [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib Udit Kumar
@ 2018-06-15 10:58   ` Ard Biesheuvel
  0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2018-06-15 10:58 UTC (permalink / raw)
  To: Udit Kumar; +Cc: Leif Lindholm, edk2-devel@lists.01.org

On 12 June 2018 at 22:14, Udit Kumar <udit.kumar@nxp.com> wrote:
> This patch gets PL011 baud rate clock from
> pl011 uart clock lib instead of Pcd.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Udit Kumar <udit.kumar@nxp.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 112c6c22376267a79f4a4ac0c4263bf24a548d81

> ---
>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c   | 5 +++--
>  ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> index 6aa8063..212991d 100644
> --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.c
> @@ -19,6 +19,7 @@
>
>  #include <Library/IoLib.h>
>  #include <Library/PcdLib.h>
> +#include <Library/PL011UartClockLib.h>
>  #include <Library/PL011UartLib.h>
>  #include <Library/SerialPortLib.h>
>
> @@ -48,7 +49,7 @@ SerialPortInitialize (
>
>    return PL011UartInitializePort (
>             (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> -           FixedPcdGet32 (PL011UartClkInHz),
> +           PL011UartClockGetFreq(),
>             &BaudRate,
>             &ReceiveFifoDepth,
>             &Parity,
> @@ -156,7 +157,7 @@ SerialPortSetAttributes (
>  {
>    return PL011UartInitializePort (
>             (UINTN)FixedPcdGet64 (PcdSerialRegisterBase),
> -           FixedPcdGet32 (PL011UartClkInHz),
> +           PL011UartClockGetFreq(),
>             BaudRate,
>             ReceiveFifoDepth,
>             Parity,
> diff --git a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> index 3683e06..5ce5b2f 100644
> --- a/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> +++ b/ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf
> @@ -26,6 +26,7 @@
>    PL011SerialPortLib.c
>
>  [LibraryClasses]
> +  PL011UartClockLib
>    PL011UartLib
>    PcdLib
>
> --
> 1.9.1
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support
  2018-06-12 20:14 [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Udit Kumar
  2018-06-12 20:14 ` [PATCH v3 1/2] " Udit Kumar
  2018-06-12 20:14 ` [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib Udit Kumar
@ 2018-06-13  9:49 ` Ard Biesheuvel
  2 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2018-06-13  9:49 UTC (permalink / raw)
  To: Udit Kumar; +Cc: Leif Lindholm, edk2-devel@lists.01.org

On 12 June 2018 at 22:14, Udit Kumar <udit.kumar@nxp.com> wrote:
> [v3]
>   Incorporated review comments of v2
>
> [v2]
>    Incorporated review comments of v1
>
>
>
> Udit Kumar (2):
>   ArmPlatformPkg: PL011 Dynamic clock freq Support
>   ArmPlatformPkg: Include PL011UartClock Lib
>

Thank you Udit.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Patch #1 pushed as cbba5ca104fb

I will push patch #2 once the accompanying edk2-platforms change is in.

>  ArmPlatformPkg/ArmPlatformPkg.dec                  |  1 +
>  ArmPlatformPkg/ArmPlatformPkg.dsc                  |  1 +
>  ArmPlatformPkg/Include/Library/PL011UartClockLib.h | 31 +++++++++++++++++++
>  .../PL011SerialPortLib/PL011SerialPortLib.c        |  5 +--
>  .../PL011SerialPortLib/PL011SerialPortLib.inf      |  1 +
>  .../Library/PL011UartClockLib/PL011UartClockLib.c  | 29 +++++++++++++++++
>  .../PL011UartClockLib/PL011UartClockLib.inf        | 36 ++++++++++++++++++++++
>  7 files changed, 102 insertions(+), 2 deletions(-)
>  create mode 100644 ArmPlatformPkg/Include/Library/PL011UartClockLib.h
>  create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.c
>  create mode 100644 ArmPlatformPkg/Library/PL011UartClockLib/PL011UartClockLib.inf
>
> --
> 1.9.1
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-06-15 10:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-12 20:14 [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Udit Kumar
2018-06-12 20:14 ` [PATCH v3 1/2] " Udit Kumar
2018-06-12 20:14 ` [PATCH v3 2/2] ArmPlatformPkg: Include PL011UartClock Lib Udit Kumar
2018-06-15 10:58   ` Ard Biesheuvel
2018-06-13  9:49 ` [PATCH v3 0/2] ArmPlatformPkg: PL011 Dynamic clock freq Support Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox