From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch] BaseTools: remove the unneeded code
Date: Wed, 13 Jun 2018 09:13:16 +0800 [thread overview]
Message-ID: <1528852396-11312-1-git-send-email-yonghong.zhu@intel.com> (raw)
Do a clean up to remove the unneeded code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/Source/Python/Workspace/MetaFileParser.py | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/BaseTools/Source/Python/Workspace/MetaFileParser.py b/BaseTools/Source/Python/Workspace/MetaFileParser.py
index a2ded0c..71da731 100644
--- a/BaseTools/Source/Python/Workspace/MetaFileParser.py
+++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py
@@ -1549,27 +1549,10 @@ class DscParser(MetaFileParser):
Parser = DscParser(IncludedFile1, self._FileType, self._Arch, IncludedFileTable,
Owner=Owner, From=FromItem)
self.IncludedFiles.add (IncludedFile1)
- # todo: rework the nested include checking logic
- # Current nested include checking rely on dsc file order inside build.db.
- # It is not reliable and will lead to build fail in some case.
- #
- # When project A and B include a common dsc file C.
- # Build project A. It give dsc file A = ID 1 in build.db, and C ID = 2.
- # Build project B. It give dsc file B ID = 3, and C ID still = 2.
- # Then, we build project B fail, unless we clean build.db.
- # In oldder BaseTools, the project B ID will still be 1,
- # that's why it work before.
-
- # Does not allow lower level included file to include upper level included file
- #if Parser._From != Owner and int(Owner) > int (Parser._From):
- # EdkLogger.error('parser', FILE_ALREADY_EXIST, File=self._FileWithError,
- # Line=self._LineIndex + 1, ExtraData="{0} is already included at a higher level.".format(IncludedFile1))
-
-
# set the parser status with current status
Parser._SectionName = self._SectionName
if self._InSubsection:
Parser._SectionType = self._SubsectionType
else:
--
2.6.1.windows.1
next reply other threads:[~2018-06-13 1:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 1:13 Yonghong Zhu [this message]
2018-06-21 8:00 ` [Patch] BaseTools: remove the unneeded code Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528852396-11312-1-git-send-email-yonghong.zhu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox