public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leo Duran <leo.duran@amd.com>
To: edk2-devel@lists.01.org
Subject: [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi on AMD
Date: Wed, 13 Jun 2018 15:11:13 -0500	[thread overview]
Message-ID: <1528920674-24912-1-git-send-email-leo.duran@amd.com> (raw)

This patch is related to the patch-set discussed here:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg27020.html

The GetProcessorLocationByApicId portion of that patch-set was pushed,
but the SendIpi issue was defered based on questions Jeff raised here:
https://www.mail-archive.com/edk2-devel@lists.01.org/msg27195.html

In any event, I do not have public documents explictly describing that
a) second SendIpi is not required on AMD processors, or that
b) only a single SendIpi is required on AMD processors.

However, as stated in the commit log:
On AMD processors the second SendIpi in the SendInitSipiSipi and
SendInitSipiSipiAllExcludingSelf routines is not required, and may cause
undesired side-effects during MP initialization.

Leo Duran (1):
  UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD
    processors.

 UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c             | 12 ++++++++----
 UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 12 ++++++++----
 2 files changed, 16 insertions(+), 8 deletions(-)

-- 
2.7.4



             reply	other threads:[~2018-06-13 20:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 20:11 Leo Duran [this message]
2018-06-13 20:11 ` [PATCH] UefiCpuPkg/LocalApicLib: Exclude second SendIpi sequence on AMD processors Leo Duran
2018-06-13 20:49   ` Laszlo Ersek
2018-06-13 20:52     ` Paolo Bonzini
2018-06-14  5:39       ` Ni, Ruiyu
2018-06-14  9:04         ` Paolo Bonzini
2018-06-14 14:08     ` Duran, Leo
2018-06-14 14:52       ` Andrew Fish
2018-06-14 15:00         ` Laszlo Ersek
2018-06-14 15:47           ` Brijesh Singh
2018-06-14 16:36   ` Laszlo Ersek
2018-06-19  5:20     ` Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528920674-24912-1-git-send-email-leo.duran@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox