From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4010:c07::241; helo=mail-lf0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A3A3E209605BF for ; Sun, 17 Jun 2018 13:12:28 -0700 (PDT) Received: by mail-lf0-x241.google.com with SMTP id t2-v6so15161350lfd.6 for ; Sun, 17 Jun 2018 13:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=M7dZ7uZsljY7AHgP9FGCV7DBkU6b6RrplofmHyAAqNA=; b=YAQbpcujbfE9uhHgHq47E2D5uyg1zKBOwXLxx7g3HPVvpIxg/6C4ZVt3WpGWDmTnvX I67EagXLQUs6uMbJBaUXoRsGwnMM9mb2DmHZGI7ZOQGvd3KdYx5P0u8mxbaB23VhzOYe GVehhC0wd2Sj3VJWWf6ctbRZJHu1ddL7wEgSF4Kw6xorzWKqPZUuxoossijgaSplsitf FICsxGor3CHRBGPbTECx0yt0w7kgpuMqQhOx4eESuVZ3O1WBCbMQEm3MDEjgO5Q2+A9u Ii5TJ8jDGrMLTX2kYOA+vgFp6GGiD3rXLQWvoPceUzfYgkLX/xpjuRABI81w6HzN/9YF p8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=M7dZ7uZsljY7AHgP9FGCV7DBkU6b6RrplofmHyAAqNA=; b=HBgrGiW14v0D6PQgENZNBOOKio2wfvWN9ovX2wMreLtdKcF9k60PRLTJTjGHcjFmcM MtEjjcAdK+FEoatFo1ldK1ypO0q4AP6HPaNNnfGqgBq0swFICCAm66eZ/QQr/ytNqIf3 omAGChvb4QCETdbAB8pirD6oVLGEf6nt5pFEHdmJkYG5wo3hyoC9a6pR5cO8uUx2s26i 8uXO8VT3KYDLGCXjbnB8QEuAt+5llQY1cBwpafYM96FQfHsYsswp/QrIyyQIuwOkLIdy LKqoAVq1KlICaD4Z+V3vCdM/RV+AfTV3bpqSefGPOtS3mXJg+/UF3eiApKAP0gYpO8Y6 IEHw== X-Gm-Message-State: APt69E3EV5qozb1/9ZHZ7LYBdAc4/mWR5xFt2Bb3YInBdu8ZSglNzXo8 s1SBetJsWXkqr7HI83EgEs89lPFRsz0= X-Google-Smtp-Source: ADUXVKLI0D/m8WN+NE6bK0thP5JZNJG0YWdM1q6MlWQc4e/J3jES9C9QPpy5uGPyORGpgRmtlQZhxA== X-Received: by 2002:a2e:905a:: with SMTP id n26-v6mr6110894ljg.33.1529266345860; Sun, 17 Jun 2018 13:12:25 -0700 (PDT) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id q75-v6sm387272lfq.47.2018.06.17.13.12.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 17 Jun 2018 13:12:25 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, jinghua@marvell.com, mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com Date: Sun, 17 Jun 2018 22:11:40 +0200 Message-Id: <1529266325-18371-1-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 Subject: [platforms: PATCH v2 00/25] Armada hardware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 20:12:29 -0000 Hi, The second version of the patchset comes with a lot of improvements, as requested during review. Please see details in the changelog below. The patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180617 I'm looking forward to review and any comments/remarks. Best regards, Marcin Changelog: v1 -> v2 * All - rebase on top of the master branch - remove internal review residues from the commit logs - increase all files version to 0x1A - use UINTN, where applicable - add Armada7k8kSoCDescLib definitions to a local header - remove assignments from variables declarations * 2,3,5-7,13,20-21 - Add Leif's RBs * 1 - add parentheses in macros - simplify loop and values assignments * 4 - add parentheses in if's - rename table and remove usage of MVHW_DEV_ENABLED - remove redundant NULL check in MvBoardDescFree () - add comments about using UINT8 * arrays, remove casting - use MV prefix in the signature - sort PCDs * 9 - drop TODO comment - rename table and remove usage of MVHW_DEV_ENABLED - add comments about using UINT8 * arrays, remove casting * 11 - simplify ArmadaSoCDescXhciGet * 12 - remove TODO in comment - sort variables, PCDs and assignments - add comments about UINT8 arrays, remove casting - rename table and remove usage of MVHW_DEV_ENABLED * 16 - remove TODO in comment - sort variables, PCDs and assignments - add comments about UINT8 arrays, remove casting - rename table and remove usage of MVHW_DEV_ENABLED * 22 - simplify loop and values assignments *23 - remove TODO in comment - sort variables, PCDs and assignments - add comments about UINT8 arrays, remove casting - rename table and remove usage of MVHW_DEV_ENABLED *25 - add parentheses in if condition Marcin Wojtas (21): Marvell/Library: Introduce ArmadaBoardDescLib class Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol Marvell/Library: RealTimeClockLib: Simplify obtaining base address Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information Marvell/Drivers: MvBoardDesc: Extend protocol with ComPhy support Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support Marvell/Drivers: MvMdioDxe: Enable 64bit addressing Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency jinghua (4): Marvell/Library: Introduce ArmadaSoCDescLib class Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL Marvell/Drivers: MvBoardDesc: Introduce board description driver Marvell/Armada7k8k: Enable board description driver compilation Silicon/Marvell/Marvell.dec | 8 +- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 + Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 +- Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 2 +- Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 1 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 2 - Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 ++ Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 2 +- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 70 +++ Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 1 + Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 1 + Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 2 +- Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf | 6 +- Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 6 +- Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 9 +- Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 79 +++ Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h | 57 ++ Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 87 +++ Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 146 +++++ Silicon/Marvell/Include/Library/MvHwDescLib.h | 290 ---------- Silicon/Marvell/Include/Library/UtmiPhyLib.h | 2 + Silicon/Marvell/Include/Protocol/BoardDesc.h | 118 ++++ Silicon/Marvell/Include/Protocol/Mdio.h | 4 +- Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 + Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 5 + Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 279 +++++++++ Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 29 +- Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 597 ++++++++++++++++++++ Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 37 +- Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c | 41 +- Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 4 +- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 43 +- Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 100 ++-- Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 50 +- Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 74 ++- Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 65 +-- 37 files changed, 1727 insertions(+), 537 deletions(-) create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h create mode 100644 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h create mode 100644 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h delete mode 100644 Silicon/Marvell/Include/Library/MvHwDescLib.h create mode 100644 Silicon/Marvell/Include/Protocol/BoardDesc.h create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c -- 2.7.4