public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org,
	nadavh@marvell.com, jinghua@marvell.com, mw@semihalf.com,
	jsd@semihalf.com, jaz@semihalf.com
Subject: [platforms: PATCH v3 00/25] Armada hardware description rework
Date: Tue, 19 Jun 2018 00:58:19 +0200	[thread overview]
Message-ID: <1529362724-9244-1-git-send-email-mw@semihalf.com> (raw)

Hi,

The third version of the patchset comes with the single Signed-off-by,
Reviewed-by's and corrected double parentheses in one of the headers.
For the details, please check the changelog below.

The patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180619

I'm looking forward to review and any comments/remarks.

Best regards,
Marcin

Changelog:
v2 -> v3
* 1,3,4,5
  - remove additional Signed-off-by

* 1,4,8,9,10,11,12,14,15,16,17,18,19,22,23,24,25
  - add Leif's RBs

* 8,11,15,18
  - remove double parentheses in Armada7k8kSoCDescLib.h

v1 -> v2
* All
  - rebase on top of the master branch
  - remove internal review residues from the commit logs
  - increase all files version to 0x1A
  - use UINTN, where applicable
  - add Armada7k8kSoCDescLib definitions to a local header
  - remove assignments from variables declarations

*  2,3,5-7,13,20-21
  - Add Leif's RBs

* 1
  - add parentheses in macros
  - simplify loop and values assignments

* 4
  - add parentheses in if's
  - rename table and remove usage of MVHW_DEV_ENABLED
  - remove redundant NULL check in  MvBoardDescFree ()
  - add comments about using UINT8 * arrays, remove casting
  - use MV prefix in the signature
  - sort PCDs

* 9
  - drop TODO comment
  - rename table and remove usage of MVHW_DEV_ENABLED
  - add comments about using UINT8 * arrays, remove casting 

* 11
  - simplify ArmadaSoCDescXhciGet

* 12
  - remove TODO in comment
  - sort variables, PCDs and assignments
  - add comments about UINT8 arrays, remove casting
  - rename table and remove usage of MVHW_DEV_ENABLED 

* 16
  - remove TODO in comment
  - sort variables, PCDs and assignments
  - add comments about UINT8 arrays, remove casting
  - rename table and remove usage of MVHW_DEV_ENABLED

* 22
  - simplify loop and values assignments

*23
  - remove TODO in comment
  - sort variables, PCDs and assignments
  - add comments about UINT8 arrays, remove casting
  - rename table and remove usage of MVHW_DEV_ENABLED

*25
  - add parentheses in if condition

Marcin Wojtas (21):
  Marvell/Library: Introduce ArmadaBoardDescLib class
  Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol
  Marvell/Library: RealTimeClockLib: Simplify obtaining base address
  Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information
  Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support
  Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol
  Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI
  Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI
  Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC
  Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC
  Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information
  Marvell/Drivers: MvBoardDesc: Extend protocol with ComPhy support
  Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC
  Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information
  Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support
  Marvell/Drivers: MvMdioDxe: Enable 64bit addressing
  Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC
  Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information
  Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support
  Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC
  Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency

jinghua (4):
  Marvell/Library: Introduce ArmadaSoCDescLib class
  Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL
  Marvell/Drivers: MvBoardDesc: Introduce board description driver
  Marvell/Armada7k8k: Enable board description driver compilation

 Silicon/Marvell/Marvell.dec                                                      |   8 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                                    |   2 +
 Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc                                   |   2 +-
 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc                                   |   2 +-
 Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc                            |   2 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                                        |   1 +
 Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf               |   2 -
 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf |  37 ++
 Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf         |   2 +-
 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf                             |  70 +++
 Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf                                |   1 +
 Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf                              |   1 +
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf                                    |   2 +-
 Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf                |   6 +-
 Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf                                  |   6 +-
 Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf                                |   9 +-
 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h   |  79 +++
 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h                               |  57 ++
 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h                             |  87 +++
 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h                               | 146 +++++
 Silicon/Marvell/Include/Library/MvHwDescLib.h                                    | 290 ----------
 Silicon/Marvell/Include/Library/UtmiPhyLib.h                                     |   2 +
 Silicon/Marvell/Include/Protocol/BoardDesc.h                                     | 118 ++++
 Silicon/Marvell/Include/Protocol/Mdio.h                                          |   4 +-
 Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h                                    |   4 +
 Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h                                  |   5 +
 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c   | 279 +++++++++
 Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c           |  29 +-
 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c                               | 597 ++++++++++++++++++++
 Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c                                  |  37 +-
 Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c                                |  41 +-
 Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c                                  |   4 +-
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c                                      |  43 +-
 Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c                  | 100 ++--
 Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c                                  |  50 +-
 Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c                                    |  74 ++-
 Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c                                  |  65 +--
 37 files changed, 1727 insertions(+), 537 deletions(-)
 create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf
 create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf
 create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h
 create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h
 create mode 100644 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h
 create mode 100644 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h
 delete mode 100644 Silicon/Marvell/Include/Library/MvHwDescLib.h
 create mode 100644 Silicon/Marvell/Include/Protocol/BoardDesc.h
 create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c
 create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c

-- 
2.7.4



             reply	other threads:[~2018-06-18 22:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 22:58 Marcin Wojtas [this message]
2018-06-18 22:58 ` [platforms: PATCH v3 01/25] Marvell/Library: Introduce ArmadaSoCDescLib class Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 02/25] Marvell/Library: Introduce ArmadaBoardDescLib class Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 03/25] Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 04/25] Marvell/Drivers: MvBoardDesc: Introduce board description driver Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 05/25] Marvell/Armada7k8k: Enable board description driver compilation Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 06/25] Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 07/25] Marvell/Library: RealTimeClockLib: Simplify obtaining base address Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 08/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 09/25] Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 10/25] Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 11/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 12/25] Marvell/Drivers: MvBoardDesc: Extend protocol " Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 13/25] Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 14/25] Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 15/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 16/25] Marvell/Drivers: MvBoardDesc: Extend protocol with ComPhy support Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 17/25] Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 18/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 19/25] Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 20/25] Marvell/Drivers: MvMdioDxe: Enable 64bit addressing Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 21/25] Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 22/25] Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 23/25] Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 24/25] Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC Marcin Wojtas
2018-06-18 22:58 ` [platforms: PATCH v3 25/25] Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency Marcin Wojtas
2018-06-21 15:06 ` [platforms: PATCH v3 00/25] Armada hardware description rework Leif Lindholm
2018-06-21 17:06   ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529362724-9244-1-git-send-email-mw@semihalf.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox