Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg/PlatformCI/ReadMe.md: Update contents

["Laszlo Ersek" <lersek@redhat.com>]

On 10/31/23 14:43, Laszlo Ersek wrote:
> On 10/31/23 13:23, Laszlo Ersek wrote:
>> On 10/31/23 00:09, Michael Kubacki wrote:
>>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>>
>>> Since the code is most regularly tested in CI, distro/versioning
>>> details are updated to match the latest CI configuration.
>>>
>>> CI has moved from Ubuntu 18.04 to Ubuntu 22.04 since the time of the
>>> file's creation, but the code is actually built in a Fedora container
>>> so Fedora is mentioned as the primary build/test environment.
>>>
>>> Updates the following information:
>>>
>>> - Build OS: Fedora 37 Linux
>>> - Supported Configuration: Additional DSCs added
>>> - Python: 3.12.x
>>> - Packaging Tool: dnf instead of apt
>>> - Container Details: Added
>>> - Primary Build Example: QemuBuild.py instead of PlatformBuild.py
>>>
>>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
>>> ---
>>>
>>> Notes:
>>>     I don't use ArmVirtPkg that often. I was reviewing the
>>>     file for the latest build instructions and realized it
>>>     was quite out of date, leading to this patch.
>>>     
>>>     The project is using Python 3.11.x right now, but a
>>>     patch is going in the next day or so that has shown
>>>     Python 3.12 will work:
>>>     https://edk2.groups.io/g/devel/message/110323
>>>     
>>>     So I went ahead and made the Python version in this
>>>     patch mention 3.12.x.
>>>
>>>  ArmVirtPkg/PlatformCI/ReadMe.md | 53 +++++++++++++-------
>>>  1 file changed, 34 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/ArmVirtPkg/PlatformCI/ReadMe.md b/ArmVirtPkg/PlatformCI/ReadMe.md
>>> index ee8d8cd61e73..c0f2b2a43b3c 100644
>>> --- a/ArmVirtPkg/PlatformCI/ReadMe.md
>>> +++ b/ArmVirtPkg/PlatformCI/ReadMe.md
>>> @@ -5,28 +5,43 @@ to use the same Pytools based build infrastructure locally.
>>>  
>>>  ## Supported Configuration Details
>>>  
>>> -This solution for building and running ArmVirtPkg has only been validated with Ubuntu
>>> -18.04 and the GCC5 toolchain. Two different firmware builds are supported and are
>>> -described below.
>>> +This solution for building and running ArmVirtPkg has been validated with Fedora
>>> +37 Linux and the GCC5 toolchain. Two different firmware builds are supported
>>> +and are described below.
>>
>> "Two different firmware builds" is now stale; we're listing 10.
>>
>> I'd suggest "The following different firmware builds".
>>
>> No need to repost just for that; I'm fine if it gets updated upon merge.
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> With the proposed update included:
> 
> Queued via <https://github.com/tianocore/edk2/pull/4984>.

Commit a6871b53599e2bf23bfa16adae638cc9a6f0755f.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110425): https://edk2.groups.io/g/devel/message/110425
Mute This Topic: https://groups.io/mt/102287336/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-