public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Liming Gao <liming.gao@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override
Date: Fri,  6 Jul 2018 15:45:49 +0800	[thread overview]
Message-ID: <1530863149-9232-4-git-send-email-liming.gao@intel.com> (raw)
In-Reply-To: <1530863149-9232-1-git-send-email-liming.gao@intel.com>

Link16 is not used any longer. Remove the checker for it.
IASL path is not required to be override.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
---
 .../BoardMtOlympus/PlatformPkgBuildOption.dsc                |  2 +-
 .../Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat     | 12 +-----------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOption.dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOption.dsc
index 151cbdc..3b55e78 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOption.dsc
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/PlatformPkgBuildOption.dsc
@@ -76,7 +76,7 @@
 #
 # Override the existing iasl path in tools_def.template
 #
-  MSFT:*_*_*_ASL_PATH == c:/Iasl/iasl.exe
+#  MSFT:*_*_*_ASL_PATH == c:/Iasl/iasl.exe
 
 #
 # Override the VFR compile flags to speed the build time
diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
index 7c444fb..ceb2bbb 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/prebuild.bat
@@ -105,18 +105,8 @@ set TOOL_CHAIN_TAG=
   )
 )
 
-echo ..WinDDK
-set CHECK_PATH_WINDDK=C:\WINDDK\3790.1830
-if not exist %CHECK_PATH_WINDDK%\bin\bin16\link16.exe (
-  echo.
-  echo !!! ERROR !!! Could not find 16-bit linker at %CHECK_PATH_WINDDK%\bin\bin16\link16.exe. !!!
-  echo.
-  set SCRIPT_ERROR=1
-)
-set CHECK_PATH_WINDDK=
-
 echo ..iASL
-set CHECK_PATH_IASL=c:\Iasl
+set CHECK_PATH_IASL=%IASL_PREFIX%
 if not exist %CHECK_PATH_IASL%\iasl.exe (
   echo.
   echo !!! ERROR !!! Could not find iASL compiler at %CHECK_PATH_IASL%\iasl.exe. !!!
-- 
2.10.0.windows.1



  parent reply	other threads:[~2018-07-06  7:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  7:45 [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report Liming Gao
2018-07-06  7:45 ` [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: Update batch file to call python.exe Liming Gao
2018-07-06 14:57   ` Yao, Jiewen
2018-07-06  7:45 ` [PATCH edk2-platforms\devel-MinPlatform] MinPlatform: update ReadMe.md to correct branch name Liming Gao
2018-07-06 14:56   ` Yao, Jiewen
2018-07-06  7:45 ` Liming Gao [this message]
2018-07-06 14:56   ` [PATCH edk2-platforms\devel-MinPlatform] PurleyOpenBoardPkg: Remove unnecessary Link16 and IASL override Yao, Jiewen
2018-07-06 14:57 ` [PATCH edk2-platforms\devel-MinPlatform] MinPlatformPkg: Enable PatchFv tool supports PCD value format in build report Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530863149-9232-4-git-send-email-liming.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox