From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4031721BADAB2 for ; Thu, 19 Jul 2018 03:31:41 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 03:31:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="65848799" Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.158.46]) by FMSMGA003.fm.intel.com with ESMTP; 19 Jul 2018 03:31:40 -0700 From: Star Zeng To: edk2-devel@lists.01.org Cc: Star Zeng , Michael D Kinney Date: Thu, 19 Jul 2018 18:31:38 +0800 Message-Id: <1531996298-28516-1-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return 0 when LSV check is not required X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 10:31:42 -0000 Current code return 1 when LSV check is not required, but 1 LSV will make 0 Version capsule image update failed. 0 LSV is valid, this patch updates the code to return 0 when LSV check is not required We can see even the DEFAULT_LOWESTSUPPORTEDVERSION is 0. Cc: Michael D Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- FmpDevicePkg/FmpDxe/FmpDxe.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index c0c1383723fb..d6b599ee1a56 100644 --- a/FmpDevicePkg/FmpDxe/FmpDxe.c +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c @@ -210,12 +210,15 @@ GetLowestSupportedVersion ( // Get the LowestSupportedVersion. // - DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION; - ReturnLsv = PcdGet32 (PcdFmpDeviceBuildTimeLowestSupportedVersion); if (!IsLowestSupportedVersionCheckRequired ()) { - return 1; + // + // Any Versioon can pass the 0 LowestSupportedVersion check. + // + return 0; } + ReturnLsv = PcdGet32 (PcdFmpDeviceBuildTimeLowestSupportedVersion); + // // Check the FmpDeviceLib // -- 2.7.0.windows.1