public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] OvmfPkg/XenPvBlkDxe: remove gEfiDevicePathProtocolGuid from [Protocols]
@ 2018-07-19 18:01 Laszlo Ersek
  2018-07-19 18:42 ` Jordan Justen
  0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2018-07-19 18:01 UTC (permalink / raw)
  To: edk2-devel-01
  Cc: Anthony Perard, Ard Biesheuvel, Jordan Justen, Julien Grall,
	Steven Shi

XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
the INF file.

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien.grall@linaro.org>
Cc: Steven Shi <steven.shi@intel.com>
Reported-by: Steven Shi <steven.shi@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1034
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    Repo:   https://github.com/lersek/edk2.git
    Branch: xenpvblk_redundant_proto_tcbz1034

 OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf | 1 -
 1 file changed, 1 deletion(-)

diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
index b3dd7c70294a..4b4dd1310f71 100644
--- a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
+++ b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
@@ -57,7 +57,6 @@ [Protocols]
   gEfiComponentName2ProtocolGuid
   gEfiComponentNameProtocolGuid
   gXenBusProtocolGuid
-  gEfiDevicePathProtocolGuid                    ## TO_START
 
 
 [Guids]
-- 
2.14.1.3.gb7cf6e02401b



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] OvmfPkg/XenPvBlkDxe: remove gEfiDevicePathProtocolGuid from [Protocols]
  2018-07-19 18:01 [PATCH] OvmfPkg/XenPvBlkDxe: remove gEfiDevicePathProtocolGuid from [Protocols] Laszlo Ersek
@ 2018-07-19 18:42 ` Jordan Justen
  2018-07-20 19:06   ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Jordan Justen @ 2018-07-19 18:42 UTC (permalink / raw)
  To: Laszlo Ersek, edk2-devel-01
  Cc: Anthony Perard, Ard Biesheuvel, Julien Grall, Steven Shi

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2018-07-19 11:01:43, Laszlo Ersek wrote:
> XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
> the INF file.
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Cc: Steven Shi <steven.shi@intel.com>
> Reported-by: Steven Shi <steven.shi@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1034
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     Repo:   https://github.com/lersek/edk2.git
>     Branch: xenpvblk_redundant_proto_tcbz1034
> 
>  OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
> index b3dd7c70294a..4b4dd1310f71 100644
> --- a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
> +++ b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
> @@ -57,7 +57,6 @@ [Protocols]
>    gEfiComponentName2ProtocolGuid
>    gEfiComponentNameProtocolGuid
>    gXenBusProtocolGuid
> -  gEfiDevicePathProtocolGuid                    ## TO_START
>  
>  
>  [Guids]
> -- 
> 2.14.1.3.gb7cf6e02401b
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] OvmfPkg/XenPvBlkDxe: remove gEfiDevicePathProtocolGuid from [Protocols]
  2018-07-19 18:42 ` Jordan Justen
@ 2018-07-20 19:06   ` Laszlo Ersek
  0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2018-07-20 19:06 UTC (permalink / raw)
  To: Jordan Justen, edk2-devel-01
  Cc: Anthony Perard, Ard Biesheuvel, Julien Grall, Steven Shi

On 07/19/18 20:42, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Thank you, Jordan :) Pushed as commit 2aa4fb10a574.

Laszlo

> On 2018-07-19 11:01:43, Laszlo Ersek wrote:
>> XenPvBlkDxe doesn't reference gEfiDevicePathProtocolGuid; remove it from
>> the INF file.
>>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien.grall@linaro.org>
>> Cc: Steven Shi <steven.shi@intel.com>
>> Reported-by: Steven Shi <steven.shi@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1034
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Notes:
>>     Repo:   https://github.com/lersek/edk2.git
>>     Branch: xenpvblk_redundant_proto_tcbz1034
>>
>>  OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
>> index b3dd7c70294a..4b4dd1310f71 100644
>> --- a/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
>> +++ b/OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf
>> @@ -57,7 +57,6 @@ [Protocols]
>>    gEfiComponentName2ProtocolGuid
>>    gEfiComponentNameProtocolGuid
>>    gXenBusProtocolGuid
>> -  gEfiDevicePathProtocolGuid                    ## TO_START
>>  
>>  
>>  [Guids]
>> -- 
>> 2.14.1.3.gb7cf6e02401b
>>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-20 19:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-19 18:01 [PATCH] OvmfPkg/XenPvBlkDxe: remove gEfiDevicePathProtocolGuid from [Protocols] Laszlo Ersek
2018-07-19 18:42 ` Jordan Justen
2018-07-20 19:06   ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox