public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Star Zeng <star.zeng@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>
Subject: [staging/FmpDevicePkg-master][PATCH V2 1/2] Remove PcdFmpDeviceSystemResetRequired from platform and Readme
Date: Fri, 20 Jul 2018 15:16:02 +0800	[thread overview]
Message-ID: <1532070963-9512-2-git-send-email-star.zeng@intel.com> (raw)
In-Reply-To: <1532070963-9512-1-git-send-email-star.zeng@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1040

FmpDxe will be updated to use Attributes to know whether reset
is required and PcdFmpDeviceSystemResetRequired will be removed.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 Readme.md                                  | 3 ---
 Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc  | 6 ------
 Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc | 6 ------
 Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc   | 6 ------
 Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc   | 6 ------
 5 files changed, 27 deletions(-)

diff --git a/Readme.md b/Readme.md
index bb6d0e1c2ac2..f4aecd7592f6 100644
--- a/Readme.md
+++ b/Readme.md
@@ -74,9 +74,6 @@ edk2/master.  The target date for integration into edk2/master is early August
   new information.
 
 ## PCDs set per module
-* PcdFmpDeviceSystemResetRequired - Indicates if a full
-  system reset is required before a firmware update to a
-  firmware devices takes effect
 * PcdFmpDeviceTestKeySha256Digest - The SHA-256 hash of a
   PKCS7 test key that is used to detect if a test key is
   being used to authenticate capsules.  Test key detection
diff --git a/Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc b/Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
index 342fd982d2f9..d5183651ef7a 100644
--- a/Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
+++ b/Vlv2TbltDevicePkg/FmpBlueSampleDevice.dsc
@@ -44,12 +44,6 @@
       #
       !include Vlv2TbltDevicePkg/FmpCertificate.dsc
 
-      #
-      # TRUE if system reset is required after sucessful capsule update
-      # FALSE if system reset is not required after sucessful capsule update
-      #
-      gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceSystemResetRequired|TRUE
-
     <LibraryClasses>
       #
       # Generic libraries that are used "as is" by all FMP modules
diff --git a/Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc b/Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
index a9489972e69f..d8914e3f0ff1 100644
--- a/Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
+++ b/Vlv2TbltDevicePkg/FmpGreenSampleDevice.dsc
@@ -44,12 +44,6 @@
       #
       !include Vlv2TbltDevicePkg/FmpCertificate.dsc
 
-      #
-      # TRUE if system reset is required after sucessful capsule update
-      # FALSE if system reset is not required after sucessful capsule update
-      #
-      gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceSystemResetRequired|TRUE
-
     <LibraryClasses>
       #
       # Generic libraries that are used "as is" by all FMP modules
diff --git a/Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc b/Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
index a1f5b6a3c469..45a173099cb2 100644
--- a/Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
+++ b/Vlv2TbltDevicePkg/FmpMinnowMaxSystem.dsc
@@ -48,12 +48,6 @@
       #
       !include Vlv2TbltDevicePkg/FmpCertificate.dsc
 
-      #
-      # TRUE if system reset is required after sucessful capsule update
-      # FALSE if system reset is not required after sucessful capsule update
-      #
-      gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceSystemResetRequired|TRUE
-
     <LibraryClasses>
       #
       # Generic libraries that are used "as is" by all FMP modules
diff --git a/Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc b/Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc
index 53a7027676a2..0ddc6c4226fa 100644
--- a/Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc
+++ b/Vlv2TbltDevicePkg/FmpRedSampleDevice.dsc
@@ -44,12 +44,6 @@
       #
       !include Vlv2TbltDevicePkg/FmpCertificate.dsc
 
-      #
-      # TRUE if system reset is required after sucessful capsule update
-      # FALSE if system reset is not required after sucessful capsule update
-      #
-      gFmpDevicePkgTokenSpaceGuid.PcdFmpDeviceSystemResetRequired|TRUE
-
     <LibraryClasses>
       #
       # Generic libraries that are used "as is" by all FMP modules
-- 
2.7.0.windows.1



  reply	other threads:[~2018-07-20  7:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20  7:16 [staging/FmpDevicePkg-master][PATCH V2 0/2] Remove PcdFmpDeviceSystemResetRequired Star Zeng
2018-07-20  7:16 ` Star Zeng [this message]
2018-07-20  7:16 ` [staging/FmpDevicePkg-master][PATCH V2 2/2] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required Star Zeng
2018-07-28  6:05   ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532070963-9512-2-git-send-email-star.zeng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox