public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion
@ 2018-07-30  2:49 Star Zeng
  0 siblings, 0 replies; only message in thread
From: Star Zeng @ 2018-07-30  2:49 UTC (permalink / raw)
  To: edk2-devel; +Cc: Star Zeng, Michael D Kinney

Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.

This patch refines the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 FmpDevicePkg/FmpDxe/FmpDxe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index b25a1511c70c..4868f80de2b9 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -229,10 +229,8 @@ GetLowestSupportedVersion (
   //
   // Check the FmpDeviceLib
   //
-  Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
-  if (EFI_ERROR (Status)) {
-    DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
-  }
+  DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
+  FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
 
   if (DeviceLibLowestSupportedVersion > ReturnLsv) {
     ReturnLsv = DeviceLibLowestSupportedVersion;
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-07-30  2:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30  2:49 [PATCH] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion Star Zeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox