public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used
@ 2018-07-30  8:53 Star Zeng
  2018-07-30 22:32 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-07-30  8:53 UTC (permalink / raw)
  To: edk2-devel; +Cc: Star Zeng, Jiewen Yao, Michael D Kinney

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index a1347b5ce67c..e88dab8c7642 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -610,6 +610,8 @@ DumpAllFmpInfo (
     FreePool(FmpImageInfoBuf);
   }
 
+  FreePool (HandleBuffer);
+
   return ;
 }
 
@@ -741,6 +743,8 @@ GetFmpHandleBufferByType (
     FreePool(FmpImageInfoBuf);
   }
 
+  FreePool (HandleBuffer);
+
   if (MatchedNumberOfHandles == 0) {
     return EFI_NOT_FOUND;
   }
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used
  2018-07-30  8:53 [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used Star Zeng
@ 2018-07-30 22:32 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2018-07-30 22:32 UTC (permalink / raw)
  To: Zeng, Star; +Cc: edk2-devel@lists.01.org, Kinney, Michael D

Reviewed-by: jiewen.yao@intel.com

thank you!
Yao, Jiewen


> 在 2018年7月30日,下午4:54,Zeng, Star <star.zeng@intel.com> 写道:
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> index a1347b5ce67c..e88dab8c7642 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> @@ -610,6 +610,8 @@ DumpAllFmpInfo (
>     FreePool(FmpImageInfoBuf);
>   }
> 
> +  FreePool (HandleBuffer);
> +
>   return ;
> }
> 
> @@ -741,6 +743,8 @@ GetFmpHandleBufferByType (
>     FreePool(FmpImageInfoBuf);
>   }
> 
> +  FreePool (HandleBuffer);
> +
>   if (MatchedNumberOfHandles == 0) {
>     return EFI_NOT_FOUND;
>   }
> -- 
> 2.7.0.windows.1
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-30 22:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30  8:53 [PATCH] MdeModulePkg DxeCapsuleLibFmp: Free HandleBuffer after it is used Star Zeng
2018-07-30 22:32 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox