* [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure
@ 2018-08-01 10:31 Star Zeng
2018-08-01 22:49 ` Kinney, Michael D
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-08-01 10:31 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Michael D Kinney
FmpDxe.c:517:18: error: equality comparison with extraneous
parentheses [-Werror,-Wparentheses-equality]
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
NOTE: This patch is based on thread
https://lists.01.org/pipermail/edk2-devel/2018-July/027810.html.
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index 0f3396c2ef83..eb3a9b0e32c2 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -514,7 +514,7 @@ GetTheImage (
goto cleanup;
}
- if ((ImageSize == NULL)) {
+ if (ImageSize == NULL) {
DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() - ImageSize Pointer Parameter is NULL.\n"));
Status = EFI_INVALID_PARAMETER;
goto cleanup;
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure
2018-08-01 10:31 [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure Star Zeng
@ 2018-08-01 22:49 ` Kinney, Michael D
0 siblings, 0 replies; 2+ messages in thread
From: Kinney, Michael D @ 2018-08-01 22:49 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org, Kinney, Michael D
Star,
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
I have integrated this patch into a V6 patch series.
Mike
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:31 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build
> failure
>
> FmpDxe.c:517:18: error: equality comparison with
> extraneous
> parentheses [-Werror,-Wparentheses-equality]
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
>
> NOTE: This patch is based on thread
> https://lists.01.org/pipermail/edk2-devel/2018-
> July/027810.html.
>
> ---
> FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index 0f3396c2ef83..eb3a9b0e32c2 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -514,7 +514,7 @@ GetTheImage (
> goto cleanup;
> }
>
> - if ((ImageSize == NULL)) {
> + if (ImageSize == NULL) {
> DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() -
> ImageSize Pointer Parameter is NULL.\n"));
> Status = EFI_INVALID_PARAMETER;
> goto cleanup;
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-01 22:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 10:31 [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure Star Zeng
2018-08-01 22:49 ` Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox