From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jordan.l.justen@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=134.134.136.24; helo=mga09.intel.com;
 envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 9B52C21CB74A7
 for <edk2-devel@lists.01.org>; Mon,  6 Aug 2018 11:26:25 -0700 (PDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Aug 2018 11:26:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,452,1526367600"; d="scan'208";a="70623809"
Received: from kjotwani-mobl1.amr.corp.intel.com (HELO localhost)
 ([10.252.140.49])
 by FMSMGA003.fm.intel.com with ESMTP; 06 Aug 2018 11:26:24 -0700
MIME-Version: 1.0
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-01 <edk2-devel@lists.01.org>
Message-ID: <153357998401.20541.14387171373485362984@jljusten-skl>
From: Jordan Justen <jordan.l.justen@intel.com>
In-Reply-To: <e2aadd35-ea0c-41d6-c387-d51267be6345@redhat.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>
References: <20180803003045.31740-1-lersek@redhat.com>
 <153327854869.17436.13213153845980323214@jljusten-skl>
 <e2aadd35-ea0c-41d6-c387-d51267be6345@redhat.com>
User-Agent: alot/0.7
Date: Mon, 06 Aug 2018 11:26:24 -0700
Subject: Re: [PATCH] OvmfPkg/PlatformDebugLibIoPort: fix port detection for use in the DXE Core
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 18:26:25 -0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2018-08-03 08:08:13, Laszlo Ersek wrote:
> =

> Should I resubmit the patch for function-scoping (and renaming) the
> global variables, or for inserting the blank linke?

No need to resubmit. Furthermore, you can consider my suggestions as
optional. I don't feel too strongly about these ones.

-Jordan