From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9B52C21CB74A7 for ; Mon, 6 Aug 2018 11:26:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2018 11:26:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,452,1526367600"; d="scan'208";a="70623809" Received: from kjotwani-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.140.49]) by FMSMGA003.fm.intel.com with ESMTP; 06 Aug 2018 11:26:24 -0700 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel-01 Message-ID: <153357998401.20541.14387171373485362984@jljusten-skl> From: Jordan Justen In-Reply-To: Cc: Brijesh Singh References: <20180803003045.31740-1-lersek@redhat.com> <153327854869.17436.13213153845980323214@jljusten-skl> User-Agent: alot/0.7 Date: Mon, 06 Aug 2018 11:26:24 -0700 Subject: Re: [PATCH] OvmfPkg/PlatformDebugLibIoPort: fix port detection for use in the DXE Core X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 18:26:25 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2018-08-03 08:08:13, Laszlo Ersek wrote: > = > Should I resubmit the patch for function-scoping (and renaming) the > global variables, or for inserting the blank linke? No need to resubmit. Furthermore, you can consider my suggestions as optional. I don't feel too strongly about these ones. -Jordan