public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Anthony Perard <anthony.perard@citrix.com>,
	Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files
Date: Fri, 1 Feb 2019 09:53:05 +0100	[thread overview]
Message-ID: <153360d1-c31e-fa85-3288-6d278824d295@redhat.com> (raw)
In-Reply-To: <20190201053445.13660-6-shenglei.zhang@intel.com>

On 02/01/19 06:34, Shenglei Zhang wrote:
> Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc
> and OvmfPkgX64.dsc.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1377
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  OvmfPkg/OvmfPkgIa32.dsc    | 1 -
>  OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
>  OvmfPkg/OvmfPkgX64.dsc     | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index aee19b75d7..7872ead8de 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -61,7 +61,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index 90cbd8e341..eef8ae25f3 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -61,7 +61,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index 83d16eb00b..6d5623857c 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -61,7 +61,6 @@
>  !endif
>  
>  [BuildOptions]
> -  GCC:*_UNIXGCC_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
>    INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
>    MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2019-02-01  8:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-01  5:34 [PATCH 00/10] Remove unused tool chain configuration Shenglei Zhang
2019-02-01  5:34 ` [PATCH 01/10] BaseTools/tools_def.template: Remove VS2003 and VS2005 Shenglei Zhang
2019-02-01  5:34 ` [PATCH 02/10] OptionRomPkg/ReadMe.txt: Remove VS2005 Shenglei Zhang
2019-02-01  5:34 ` [PATCH 03/10] BaseTools/tools_def.template: Remove DDK3790 Shenglei Zhang
2019-02-01  5:34 ` [PATCH 04/10] BaseTools/tools_def.template: Remove UNIXGCC Shenglei Zhang
2019-02-01  8:52   ` Laszlo Ersek
2019-02-01  5:34 ` [PATCH 05/10] OvmfPkg: Remove UNIXGCC in DSC files Shenglei Zhang
2019-02-01  8:53   ` Laszlo Ersek [this message]
2019-02-01  5:34 ` [PATCH 06/10] OvmfPkg/README: Remove UNIXGCC Shenglei Zhang
2019-02-01  8:55   ` Laszlo Ersek
2019-02-01  9:50   ` Philippe Mathieu-Daudé
2019-02-01 13:47     ` Laszlo Ersek
2019-02-01  5:34 ` [PATCH 07/10] BaseTools: Update MYTOOLS Shenglei Zhang
2019-02-01  5:34 ` [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC Shenglei Zhang
2019-02-01  8:56   ` Laszlo Ersek
2019-02-01  5:34 ` [PATCH 09/10] BaseTools/tools_def.template: Remove CYGGCC Shenglei Zhang
2019-02-01  8:58   ` Laszlo Ersek
2019-02-01  5:34 ` [PATCH 10/10] OptionRomPkg/ReadMe.txt: " Shenglei Zhang
2019-02-01 10:25 ` [PATCH 00/10] Remove unused tool chain configuration Ard Biesheuvel
2019-02-01 13:23   ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153360d1-c31e-fa85-3288-6d278824d295@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox