public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option
@ 2018-08-23  5:51 Haojian Zhuang
  2018-08-23 11:29 ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Haojian Zhuang @ 2018-08-23  5:51 UTC (permalink / raw)
  To: edk2-devel; +Cc: Laszlo Ersek, Leif Lindholm, Ard Biesheuvel

Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
the hotkey of boot option won't be registered correctly.

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
---
 ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
index f9c71d430c99..81d36f218700 100644
--- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
+++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
@@ -479,7 +479,7 @@ GetPlatformOptions (
                NULL,
                BootOptionNumber,
                0,
-               BootKeys[Index],
+               &BootKeys[Index],
                NULL
                );
     if (EFI_ERROR (Status)) {
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option
  2018-08-23  5:51 [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option Haojian Zhuang
@ 2018-08-23 11:29 ` Laszlo Ersek
  2018-08-23 15:42   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2018-08-23 11:29 UTC (permalink / raw)
  To: Haojian Zhuang, edk2-devel

On 08/23/18 07:51, Haojian Zhuang wrote:
> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
> the hotkey of boot option won't be registered correctly.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
> ---
>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index f9c71d430c99..81d36f218700 100644
> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -479,7 +479,7 @@ GetPlatformOptions (
>                 NULL,
>                 BootOptionNumber,
>                 0,
> -               BootKeys[Index],
> +               &BootKeys[Index],
>                 NULL
>                 );
>      if (EFI_ERROR (Status)) {
> 

I'm sorry I didn't notice this while reviewing the patch that would end
up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform
boot options", 2018-06-05). Also, ellipses are tricky; the compiler
couldn't help.

Please add the following to the commit message, just above the
Contributed-under line:

Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505

With that:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option
  2018-08-23 11:29 ` Laszlo Ersek
@ 2018-08-23 15:42   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-08-23 15:42 UTC (permalink / raw)
  To: Laszlo Ersek; +Cc: Haojian Zhuang, edk2-devel@lists.01.org, Leif Lindholm

On 23 August 2018 at 12:29, Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/23/18 07:51, Haojian Zhuang wrote:
>> Fix the parameter in EfiBootManagerAddKeyOptionVariable (). Otherwise,
>> the hotkey of boot option won't be registered correctly.
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
>> ---
>>  ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> index f9c71d430c99..81d36f218700 100644
>> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> @@ -479,7 +479,7 @@ GetPlatformOptions (
>>                 NULL,
>>                 BootOptionNumber,
>>                 0,
>> -               BootKeys[Index],
>> +               &BootKeys[Index],
>>                 NULL
>>                 );
>>      if (EFI_ERROR (Status)) {
>>
>
> I'm sorry I didn't notice this while reviewing the patch that would end
> up as commit 1b6e7633cad8 ("ArmPkg/PlatformBootManagerLib: load platform
> boot options", 2018-06-05). Also, ellipses are tricky; the compiler
> couldn't help.
>
> Please add the following to the commit message, just above the
> Contributed-under line:
>
> Fixes: 1b6e7633cad8135547f337eeef47f446f57a2505
>
> With that:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>

Pushed as 2b2959dd347388d9a056d8116e02268cb563ef09

Thanks


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-23 15:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23  5:51 [PATCH v1 1/1] ArmPkg/PlatformBootManagerLib: fix hotkey of boot option Haojian Zhuang
2018-08-23 11:29 ` Laszlo Ersek
2018-08-23 15:42   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox