From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::231; helo=mail-lj1-x231.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2CF752110E8B9 for ; Sun, 2 Sep 2018 21:54:37 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id v26-v6so14261728ljj.3 for ; Sun, 02 Sep 2018 21:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c9N7QvhoFS23znYYTwVSWNx6w9l7AorcABZOE9o1m1U=; b=OUg6uIDPTQO/Yr5aZGugp584+ZFV6bdPvJ6GvhRdgupv2qgGFkzC1Wz0WFCQ+7eSId 5He4kn8P6Is7QAx68JDg7KCSlsG+SAJvIwivHG9JLHCEAS5ZdvX6+8V3TfV1SzlG2blk ywW/CiK1Lmju0qlvtB/bKr7dNfGJe8m/0wyKXU4FtnLs0gGoBUaSWaBRp2UkkRcaGNnN LqHUAriDaAs9+358tMgR831mMyjlYD29xKPxKxEAH4cvpwTCe/YFi+xTnj3DOr1h1gj6 38JlOViD757CL8QGEPOw8a//A++BQ0Cf8tatJQSkN2Dirz4yrh+ANu7GTOkrLKA7IF4Z nMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=c9N7QvhoFS23znYYTwVSWNx6w9l7AorcABZOE9o1m1U=; b=oAB6T1kyxUnqX8/jPpH26k/ZSOmvCx+v+YbbmxxTXpR1oUxnrQRGdRkvh2oqb6nC3y 9hDfwR3+XAp0XLhxodDMLT8XhRhL6vP+qXlkX8CFHgoNv/dkoY/F2IeM3TLpsLVkVNvY 2VLopHku/uNsJmp/H20CCeaZspeqX9k/G8nc0c+AXU7YHV+vSEiq8nRnu5F8+p+DiNW2 7prn6vApsLNsr9gS3A4vkAIjaybjHCpJFaz79Ws76Pb7w2TQVHVuPx60AIc1Z56FuZFW aXLkbrfdTMUQXO1D/gQr1KXc6zdl3x3KobfA2NlxkrCa2RX0LEV0SALmkboUtLpOrVhc UgAA== X-Gm-Message-State: APzg51AB0gjYNVx18MhrXhPjB8hE31BKDteyxWtmDT1w0c89K5juqTZI 198rYwcGKlJHHE0xM7kNU92nti/zoxA= X-Google-Smtp-Source: ANB0Vdbjt2qCg9VBI7YUBwwkkAqWCiwPmgzRko+kwW105CEpbEHvMXcyvCTMWVd+mjmzaG3XdWLhvw== X-Received: by 2002:a2e:550b:: with SMTP id j11-v6mr16989986ljb.124.1535950474945; Sun, 02 Sep 2018 21:54:34 -0700 (PDT) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h16-v6sm3196658ljh.26.2018.09.02.21.54.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 02 Sep 2018 21:54:34 -0700 (PDT) From: Marcin Wojtas To: edk2-devel@lists.01.org Cc: feng.tian@intel.com, michael.d.kinney@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, nadavh@marvell.com, mw@semihalf.com, jsd@semihalf.com, Tomasz Michalec Date: Mon, 3 Sep 2018 06:54:12 +0200 Message-Id: <1535950453-27147-7-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535950453-27147-1-git-send-email-mw@semihalf.com> References: <1535950453-27147-1-git-send-email-mw@semihalf.com> Subject: [PATCH 6/7] MdeModulePkg/SdMmcPciHcDxe: Fix SdMmcHcReset to set only necesery bits X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 04:54:37 -0000 From: Tomasz Michalec SdMmcHcReset used to set all bits of Software Reset Register to 1 including reserved ones. Now only first bit is set which means "Software Reset for All". Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index e7c51e6..c9a0acc 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -459,8 +459,8 @@ SdMmcHcReset ( } PciIo = Private->PciIo; - SwReset = 0xFF; - Status = SdMmcHcRwMmio (PciIo, Slot, SD_MMC_HC_SW_RST, FALSE, sizeof (SwReset), &SwReset); + SwReset = BIT0; + Status = SdMmcHcOrMmio (PciIo, Slot, SD_MMC_HC_SW_RST, sizeof (SwReset), &SwReset); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "SdMmcHcReset: write full 1 fails: %r\n", Status)); @@ -472,7 +472,7 @@ SdMmcHcReset ( Slot, SD_MMC_HC_SW_RST, sizeof (SwReset), - 0xFF, + BIT0, 0x00, SD_MMC_HC_GENERIC_TIMEOUT ); -- 2.7.4