public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char
@ 2018-09-25  8:36 Yonghong Zhu
  2018-09-27 15:41 ` Gao, Liming
  0 siblings, 1 reply; 2+ messages in thread
From: Yonghong Zhu @ 2018-09-25  8:36 UTC (permalink / raw)
  To: edk2-devel; +Cc: Liming Gao, Michael Kinney, Kevin W Shaw

Update the '*' in the EBNF to '+' which means in the string there at
least need one char. the case like "" is not supported.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
 appendix_d_buildexe_command/d4_usage.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/appendix_d_buildexe_command/d4_usage.md b/appendix_d_buildexe_command/d4_usage.md
index 16c3630..00928f3 100644
--- a/appendix_d_buildexe_command/d4_usage.md
+++ b/appendix_d_buildexe_command/d4_usage.md
@@ -214,12 +214,12 @@ precedence over PCD provided in DSC, FDF, INF, and DEC files.
 <HexNumber>       ::= {"0x"} {"0X"} (a-fA-F0-9){1,16}
 <Boolean>         ::= {<True>} {<False>}
 <True>            ::= {"TRUE"} {"True"} {"true"} {"1"} {"0x1"} {"0x01"}
 <False>           ::= {"FALSE"} {"False"} {"false"} {"0"} {"0x0"} {"0x00"}
 <String>          ::= {<QuotedStr>} {<SglQuotedStr>}
-<QuotedStr>       ::= ["L"] <DblQuote> <PrintChars>* <DblQuote>
-<SglQuotedStr>    ::= ["L"] <DblQuote> "\" <SglQuote> <PrintChars>*
+<QuotedStr>       ::= ["L"] <DblQuote> <PrintChars>+ <DblQuote>
+<SglQuotedStr>    ::= ["L"] <DblQuote> "\" <SglQuote> <PrintChars>+
                       "\" <SglQuote> <DblQuote>
 <PrintChars>      ::= {<TS>} {<CChars>}
 <DblQuote>        ::= 0x22
 <SglQuote>        ::= 0x27
 <CChars>          ::= {0x21} {(0x23 - 0x26)} {(0x28 - 0x5B)} {(0x5D - 0x7E)}
-- 
2.6.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char
  2018-09-25  8:36 [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char Yonghong Zhu
@ 2018-09-27 15:41 ` Gao, Liming
  0 siblings, 0 replies; 2+ messages in thread
From: Gao, Liming @ 2018-09-27 15:41 UTC (permalink / raw)
  To: Zhu, Yonghong, edk2-devel@lists.01.org; +Cc: Kinney, Michael D, Shaw, Kevin W

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Tuesday, September 25, 2018 4:37 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Shaw, Kevin W <kevin.w.shaw@intel.com>
> Subject: [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char
> 
> Update the '*' in the EBNF to '+' which means in the string there at
> least need one char. the case like "" is not supported.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Kevin W Shaw <kevin.w.shaw@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
>  appendix_d_buildexe_command/d4_usage.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/appendix_d_buildexe_command/d4_usage.md b/appendix_d_buildexe_command/d4_usage.md
> index 16c3630..00928f3 100644
> --- a/appendix_d_buildexe_command/d4_usage.md
> +++ b/appendix_d_buildexe_command/d4_usage.md
> @@ -214,12 +214,12 @@ precedence over PCD provided in DSC, FDF, INF, and DEC files.
>  <HexNumber>       ::= {"0x"} {"0X"} (a-fA-F0-9){1,16}
>  <Boolean>         ::= {<True>} {<False>}
>  <True>            ::= {"TRUE"} {"True"} {"true"} {"1"} {"0x1"} {"0x01"}
>  <False>           ::= {"FALSE"} {"False"} {"false"} {"0"} {"0x0"} {"0x00"}
>  <String>          ::= {<QuotedStr>} {<SglQuotedStr>}
> -<QuotedStr>       ::= ["L"] <DblQuote> <PrintChars>* <DblQuote>
> -<SglQuotedStr>    ::= ["L"] <DblQuote> "\" <SglQuote> <PrintChars>*
> +<QuotedStr>       ::= ["L"] <DblQuote> <PrintChars>+ <DblQuote>
> +<SglQuotedStr>    ::= ["L"] <DblQuote> "\" <SglQuote> <PrintChars>+
>                        "\" <SglQuote> <DblQuote>
>  <PrintChars>      ::= {<TS>} {<CChars>}
>  <DblQuote>        ::= 0x22
>  <SglQuote>        ::= 0x27
>  <CChars>          ::= {0x21} {(0x23 - 0x26)} {(0x28 - 0x5B)} {(0x5D - 0x7E)}
> --
> 2.6.1.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-27 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25  8:36 [Patch] Build Spec: Update EBNF of --pcd for String type to at least one char Yonghong Zhu
2018-09-27 15:41 ` Gao, Liming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox