From: Yonghong Zhu <yonghong.zhu@intel.com>
To: edk2-devel@lists.01.org
Subject: [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6
Date: Sun, 14 Oct 2018 00:39:28 +0800 [thread overview]
Message-ID: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> (raw)
Remove the logic that the Python3 version must larger than 3.6.
We verified Python3 migration patches on version 3.6 and 3.7.
for other version we not verified it.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
---
BaseTools/toolsetup.bat | 7 -------
edksetup.sh | 4 ++--
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index 0d4028d..d585431 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -314,17 +314,10 @@ set PYTHON3=py -3
echo.
echo !!! ERROR !!! %PYTHON3% not install.
echo.
goto end
)
- FOR /F "TOKENS=1,2" %%i IN ('%PYTHON3% --version') DO set VERSION=%%j
- if /I "%VERSION%" LSS "3.6" (
- echo.
- echo !!! ERROR !!! python version should greater than or equal to version 3.6.
- echo.
- goto end
- )
:check_freezer_path
@REM We have Python, now test for FreezePython application
if not defined PYTHON_FREEZER_PATH (
echo.
diff --git a/edksetup.sh b/edksetup.sh
index d4e577e..84b3e63 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -129,13 +129,13 @@ function SetupPython3()
if [ "$ret" -eq 1 ]; then
origin_version=$python_version
export PYTHON3=$python
fi
done
- if [ -z "$origin_version" ] || [ `echo "$origin_version < 3.6" |bc` -eq 1 ]; then
+ if [ -z "$origin_version" ]; then
echo
- echo ERROR!!!, python version should greater than or equal to version 3.6.
+ echo ERROR!!!, Please install a Python 3 Tool.
echo
return 1
fi
--
2.6.1.windows.1
next reply other threads:[~2018-10-13 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 16:39 Yonghong Zhu [this message]
2018-10-13 16:52 ` [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 Ard Biesheuvel
2018-10-13 17:03 ` Gao, Liming
2018-10-13 17:04 ` Ard Biesheuvel
2018-10-13 17:12 ` Gao, Liming
2018-10-13 17:17 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1539448768-12816-1-git-send-email-yonghong.zhu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox