From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 5/5] KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support To: Michael Kubacki ,devel@edk2.groups.io From: "Benjamin Doron" X-Originating-Location: Thornhill, Ontario, CA (24.52.200.135) X-Originating-Platform: Linux Firefox 90 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Wed, 18 Aug 2021 13:17:40 -0700 References: In-Reply-To: Message-ID: <15410.1629317860999625583@groups.io> Content-Type: multipart/alternative; boundary="1qL9GO29f5CpqyNVbaIg" --1qL9GO29f5CpqyNVbaIg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, That's a good idea, I'll try to file the bugs when I get a chance (of cours= e, there probably isn't an AspireVn7Dash572G keyword yet). I've removed the #if 0 code in AspireVn7Dash572GBoardBootModeDetect() and i= mplemented the other function. Now there is only some #if 0 in Acpi/ec.asl,= I'll try to implement this sometime. Regards, Benjamin --1qL9GO29f5CpqyNVbaIg Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael,
That's a good idea, I'll try to file the bugs when I get a= chance (of course, there probably isn't an AspireVn7Dash572G keyword yet).=

I've removed the #if 0 code in AspireVn7Dash572GBoardBootModeDe= tect() and implemented the other function. Now there is only some #if 0 in = Acpi/ec.asl, I'll try to implement this sometime.

Regards,
= Benjamin --1qL9GO29f5CpqyNVbaIg--