From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=sakar.arora@arm.com; receiver=edk2-devel@lists.01.org Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id E057821B02822 for ; Tue, 6 Nov 2018 00:48:34 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 722F115AD; Tue, 6 Nov 2018 00:48:34 -0800 (PST) Received: from u201365.usa.Arm.com (a75592.asiapac.arm.com [10.162.22.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 239C73F5BD; Tue, 6 Nov 2018 00:48:32 -0800 (PST) From: Sakar Arora To: edk2-devel@lists.01.org Cc: Supreeth.Venkatesh@arm.com, prasanth.pulla@arm.com Date: Tue, 6 Nov 2018 14:17:45 +0530 Message-Id: <1541494066-16288-11-git-send-email-sakar.arora@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> References: <1541494066-16288-1-git-send-email-sakar.arora@arm.com> Subject: [edk2-test][RFC PATCH 11/12] uefi-sct/SctPkg: sbbr: Bugfix for MemoryMap Check Test. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 08:48:35 -0000 X-List-Received-Date: Tue, 06 Nov 2018 08:48:35 -0000 X-List-Received-Date: Tue, 06 Nov 2018 08:48:35 -0000 X-List-Received-Date: Tue, 06 Nov 2018 08:48:35 -0000 As per SBBR specification, "A UEFI runtime environment compliant with SBBR must not be written with any assumption of an identity mapping between virtual and physical memory maps." Test case implementation was failing the test, if it is not identity mapped, which is incorrect. Corrected test case to warn the user that UEFI runtime environment is identity mapped, instead of failure. Signed-off-by: Sakar Arora Reported-by: Felix Poludov --- .../SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c index fb50702..c88d60b 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/SbbrBootServices/BlackBoxTest/SbbrBootServicesBBTestFunction.c @@ -201,13 +201,13 @@ BBTestMemoryMapTest ( // // Checking for identity mapping // - if (MemoryMapDescriptor->PhysicalStart != MemoryMapDescriptor->VirtualStart) { + if (MemoryMapDescriptor->PhysicalStart == MemoryMapDescriptor->VirtualStart) { StandardLib->RecordAssertion ( StandardLib, - EFI_TEST_ASSERTION_FAILED, + EFI_TEST_ASSERTION_WARNING, gSbbrBootServicesAssertion001Guid, L"MemoryMap", - L"%a:%d - MemoryMap 0x%X Not Identity Mapped", + L"%a:%d - MemoryMap 0x%X is Identity Mapped. UEFI runtime environment must not be written with any assumption of an identity mapping between virtual and physical memory maps.", __FILE__, __LINE__, MemoryMapDescriptor -- 2.7.4