From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2359B21959CB2 for ; Tue, 13 Nov 2018 04:33:29 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id a2-v6so10293385edi.5 for ; Tue, 13 Nov 2018 04:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=ZLtD7PyospqxxYRpC2shD7eVoULJiJb8E9uBiMYVIF8=; b=Loh9uaHwPPgr3xa1EStHHg3cgXmhzUFUEEPtltkQEWA0xlU9YkGqttDF9OGwfhtK4O fGeaanoakUnAtgise3L2efg5GN/Mjq8tf6w+HTm9pyJIC7QluvDsNDHo6sfFIemFyyrS H037hFU4I97J6UMViIdg1YNOHJJv5nOAlQYov6QyjjH1F+iYlsG+wcExuSaHZ+KrRN3W OikDuJPfHEPvyrVIy+2AS5hrt1yOef1fpdZLYOnlCGL807o9jPRSGbawinvdpXugmHzZ qbJRD5fWiuYzY0j0ZskY7xsL6tFdyRKpypz5MR/Lca/78Ke7VmGQy/dWdxKZXEAuhMUM xuEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ZLtD7PyospqxxYRpC2shD7eVoULJiJb8E9uBiMYVIF8=; b=sy44NIadAGyndV4DnubTf32IV+5dVX4DijsZA7A163eT1j71TTa/SeN71KIILX4Cim f8tipbpmDwDxJTerOprzJj+gOiA1di6qvo7AaeatVGC7uuXCTQaVIIr7wOadBBPI7r4L esQFzVCYqn6LkYBe/z4Kqdly37STiVCpLll/5JUJcrXs4pz4O48aLo/JVO+3/ABwi5Gt Cze5qO7jwf9l/rdjyWkFZI6OO5Thx4h80riuUQBOwONVUzAJNCfxsa5FFXYJJPB/rGck pAvqS01i+oiSRx+9i7IJEmuYW3Ol+KWbqBLZBpooNJCHgkcEy69SDXEfN6bWshuQm0w2 HhEA== X-Gm-Message-State: AGRZ1gLFkqhgO0HrHWrWbto0BQP5YKhT51DFnHShOiZ0bAmGEGlikgok 0D0akgTDyngHZRD5KLlPHmfvUe0Kkxc= X-Google-Smtp-Source: AJdET5eVHveeQP/wJLTxHDl03MYJMFayGDY2IaubXGn17cpygFvB/zFsoiA0XsO/ZWWfX9eDKWDW5w== X-Received: by 2002:a17:906:88f:: with SMTP id n15-v6mr12608903eje.119.1542112406974; Tue, 13 Nov 2018 04:33:26 -0800 (PST) Received: from gilgamesh.semihalf.com (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id h28-v6sm5298083ede.49.2018.11.13.04.33.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Nov 2018 04:33:26 -0800 (PST) From: Marcin Wojtas To: edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, hao.a.wu@intel.com, nadavh@marvell.com, mw@semihalf.com, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com, tm@semihalf.com Date: Tue, 13 Nov 2018 13:32:43 +0100 Message-Id: <1542112371-32546-1-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 2.7.4 Subject: [platforms: PATCH v5 0/8] Armada7k8k Xenon driver rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 X-List-Received-Date: Tue, 13 Nov 2018 12:33:29 -0000 Hi, The fifth version of the patchset splits last commit to two parts (removal of old files and rework). It also applies correction to the BoardDesc library callbacks. Patches are available in the github: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/xenon-upstream-r20181113 Generic driver patches with fixes and extended SdMmcOverride protocol: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/sdmmc-override-upstream-r20181109 I'm looking forward to the comments and remarks. Best regards, Marcin Changelog: v4->v5: * 1,2,6/8 - add Ard's RB * 2,3,4,5 - change parameters to OUT - assign count only after allocation is successful * 7/8 & 8/8 - split driver rework patches into two steps v3->v4: * 1/7: - add Ard's RB * 2/7: - use local enum definition for SlotType in order not to include MdeModulePkg private header * 7/7: - rework capability handling, without using the structure defined in the MdeModulePkg header v2->v3 * 1/7: - rename NotifyPhase parameter to PhaseData * 7/7: - rename NotifyPhase parameter to PhaseData - update UHS_MODE_SEL only for HS200/HS400 in XenonSdMmcHcUhsSignaling - use local macros for standard SDHC registers in order not to include private MdeModulePkg header v1 -> v2 * 1/7 and 7/7 - adjust to modified SdMmcOverride NotifyPhase and Capability routines Marcin Wojtas (2): Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride Marvell/Drivers: XenonDxe: Remove SdMmcPciHcDxe files Tomasz Michalec (6): Marvell/Library: ArmadaBoardDescLib: Extend SDMMC information SolidRun/Armada80x0McBin: Introduce board description library Marvell/Armada70x0Db: Introduce board description library Marvell/Armada80x0Db: Introduce board description library Marvell/Drivers: MvBoardDesc: Extend information for SdMmc Marvell/Drivers: XenonDxe: Switch to use generic SdMmcPciHcDxe Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 3 + Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 3 + Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 3 + Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 3 +- Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf | 34 + Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf | 34 + Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf | 34 + Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 1 + Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf => XenonDxe.inf} | 33 +- Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h | 791 -------- Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h | 550 ------ Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.h | 151 ++ Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.h | 53 + Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h | 131 +- Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 21 +- Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c | 66 + Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c | 66 + Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c | 66 + Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 24 +- Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentName.c | 211 --- Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c | 1164 ------------ Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c | 1190 ------------ Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c | 1320 -------------- Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c | 1928 -------------------- Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.c | 321 ++++ Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 432 +++++ Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c | 408 +++-- Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Emmc.c | 9 +- Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.uni | 23 - Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxeExtra.uni | 19 - 31 files changed, 1712 insertions(+), 7383 deletions(-) create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.inf create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.inf create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.inf rename Silicon/Marvell/Drivers/SdMmc/XenonDxe/{SdMmcPciHcDxe.inf => XenonDxe.inf} (65%) delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.h delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.h create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.h create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.h create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbBoardDescLib/Armada70x0DbBoardDescLib.c create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoardDescLib.c create mode 100644 Platform/SolidRun/Armada80x0McBin/Armada80x0McBinBoardDescLib/Armada80x0McBinBoardDescLib.c delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/ComponentName.c delete mode 100755 Silicon/Marvell/Drivers/SdMmc/XenonDxe/EmmcDevice.c delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdDevice.c delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHci.c create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonPciHci.c create mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.uni delete mode 100644 Silicon/Marvell/Drivers/SdMmc/XenonDxe/SdMmcPciHcDxeExtra.uni -- 2.7.4