From: Jordan Justen <jordan.l.justen@intel.com>
To: afish@apple.com, jordan.l.justen@intel.com, ruiyu.ni@intel.com,
Liu Yu <pedroa.liu@outlook.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] EmulatorPkg/build.sh 64bit simulator execution issue
Date: Sat, 17 Nov 2018 23:12:02 -0800 [thread overview]
Message-ID: <154252512264.2928.7129665532523986620@jljusten-skl> (raw)
In-Reply-To: <TY2PR02MB283159489F6B4059D1CBFCB88FDF0@TY2PR02MB2831.apcprd02.prod.outlook.com>
I think 32-bit version is incorrect too.
Can you delete BUILD_OUTPUT_DIR from both IA32 and X64 cases, and
following the case use:
BUILD_OUTPUT_DIR=$WORKSPACE/Build/Emulator$PROCESSOR
Can you add this to the commit message:
Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run at 64bit)"
-Jordan
On 2018-11-17 20:13:02, Liu Yu wrote:
> correction BUILD_OUTPUT_DIR path
>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Signed-off-by: Pedroa Liu <pedroa.liu@outlook.com>
> ---
> EmulatorPkg/build.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
> index 339c6b3b4f..3abdab1db9 100755
> --- a/EmulatorPkg/build.sh
> +++ b/EmulatorPkg/build.sh
> @@ -188,7 +188,7 @@ case $PROCESSOR in
> ;;
> X64)
> ARCH_SIZE=64
> - BUILD_OUTPUT_DIR=$WORKSPACE/Build/Emulator
> + BUILD_OUTPUT_DIR=$WORKSPACE/Build/EmulatorX64
> LIB_NAMES="ld-linux-x86-64.so.2 libdl.so.2 crt1.o crti.o crtn.o"
> LIB_SEARCH_PATHS="/usr/lib/x86_64-linux-gnu /usr/lib64 /lib64
> /usr/lib /lib"
> ;;
> --
> 2.17.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-11-18 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 4:13 [PATCH] EmulatorPkg/build.sh 64bit simulator execution issue Liu Yu
2018-11-18 7:12 ` Jordan Justen [this message]
2018-11-18 12:32 ` [PATCH 2/2] Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)" Liu Yu
2018-11-19 0:41 ` Jordan Justen
-- strict thread matches above, loose matches on Subject: below --
2018-11-18 4:02 [PATCH] EmulatorPkg/build.sh 64bit simulator execution issue Liu Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154252512264.2928.7129665532523986620@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox