From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BE6B621A07A92 for ; Sun, 18 Nov 2018 16:41:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2018 16:41:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,250,1539673200"; d="scan'208";a="109189472" Received: from dtan-mobl.amr.corp.intel.com (HELO localhost) ([10.254.55.211]) by fmsmga001.fm.intel.com with ESMTP; 18 Nov 2018 16:41:24 -0800 MIME-Version: 1.0 To: "afish@apple.com" , "ruiyu.ni@intel.com" , Liu Yu Message-ID: <154258808427.7306.7305301391792897447@jljusten-skl> From: Jordan Justen In-Reply-To: Cc: "edk2-devel@lists.01.org" References: <154252512264.2928.7129665532523986620@jljusten-skl> User-Agent: alot/0.7 Date: Sun, 18 Nov 2018 16:41:24 -0800 Subject: Re: [PATCH 2/2] Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC, PEI, DXE all run at 64bit)" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 00:41:26 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Pushed as 90fa59f685. Thanks for the contribution! -Jordan On 2018-11-18 04:32:50, Liu Yu wrote: > Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit=C2=A0 (SEC,PEI,DXE all r= un = > at 64bit)" > = > Contributed-under: TianoCore Contribution Agreement 1.1 > = > Signed-off-by: Pedroa Liu > = > diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh > index 3abdab1db9..9ed59387d1 100755 > --- a/EmulatorPkg/build.sh > +++ b/EmulatorPkg/build.sh > @@ -179,16 +179,16 @@ then > =C2=A0=C2=A0 PROCESSOR=3D$HOST_PROCESSOR > =C2=A0fi > = > +BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/Emulator$PROCESSOR > + > =C2=A0case $PROCESSOR in > =C2=A0=C2=A0 IA32) > =C2=A0=C2=A0=C2=A0=C2=A0 ARCH_SIZE=3D32 > -=C2=A0=C2=A0=C2=A0 BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/Emulator32 > =C2=A0=C2=A0=C2=A0=C2=A0 LIB_NAMES=3D"ld-linux.so.2 libdl.so.2 crt1.o cr= ti.o crtn.o" > =C2=A0=C2=A0=C2=A0=C2=A0 LIB_SEARCH_PATHS=3D"/usr/lib/i386-linux-gnu /us= r/lib32 /lib32 = > /usr/lib /lib" > =C2=A0=C2=A0=C2=A0=C2=A0 ;; > =C2=A0=C2=A0 X64) > =C2=A0=C2=A0=C2=A0=C2=A0 ARCH_SIZE=3D64 > -=C2=A0=C2=A0=C2=A0 BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/EmulatorX64 > =C2=A0=C2=A0=C2=A0=C2=A0 LIB_NAMES=3D"ld-linux-x86-64.so.2 libdl.so.2 cr= t1.o crti.o crtn.o" > =C2=A0=C2=A0=C2=A0=C2=A0 LIB_SEARCH_PATHS=3D"/usr/lib/x86_64-linux-gnu /= usr/lib64 /lib64 = > /usr/lib /lib" > =C2=A0=C2=A0=C2=A0=C2=A0 ;; > -- = > 2.17.1 > = > =E5=9C=A8 2018/11/18 =E4=B8=8B=E5=8D=883:12, Jordan Justen =E5=86=99=E9= =81=93: > > I think 32-bit version is incorrect too. > > > > Can you delete BUILD_OUTPUT_DIR from both IA32 and X64 cases, and > > following the case use: > > > > BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/Emulator$PROCESSOR > > > > Can you add this to the commit message: > > > > Fixes: f89c018f3d "EmulatorPkg/Win: Enable 64bit (SEC,PEI,DXE all run a= t 64bit)" > > > > -Jordan > > > > On 2018-11-17 20:13:02, Liu Yu wrote: > >> correction BUILD_OUTPUT_DIR path > >> > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> > >> Signed-off-by: Pedroa Liu > >> --- > >> =C2=A0EmulatorPkg/build.sh | 2 +- > >> =C2=A01 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh > >> index 339c6b3b4f..3abdab1db9 100755 > >> --- a/EmulatorPkg/build.sh > >> +++ b/EmulatorPkg/build.sh > >> @@ -188,7 +188,7 @@ case $PROCESSOR in > >> =C2=A0=C2=A0=C2=A0=C2=A0 ;; > >> =C2=A0=C2=A0 X64) > >> =C2=A0=C2=A0=C2=A0=C2=A0 ARCH_SIZE=3D64 > >> -=C2=A0=C2=A0=C2=A0 BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/Emulator > >> +=C2=A0=C2=A0=C2=A0 BUILD_OUTPUT_DIR=3D$WORKSPACE/Build/EmulatorX64 > >> =C2=A0=C2=A0=C2=A0=C2=A0 LIB_NAMES=3D"ld-linux-x86-64.so.2 libdl.so.= 2 crt1.o crti.o crtn.o" > >> =C2=A0=C2=A0=C2=A0=C2=A0 LIB_SEARCH_PATHS=3D"/usr/lib/x86_64-linux-g= nu /usr/lib64 /lib64 > >> /usr/lib /lib" > >> =C2=A0=C2=A0=C2=A0=C2=A0 ;; > >> -- = > >> 2.17.1 > >> > >> _______________________________________________ > >> edk2-devel mailing list > >> edk2-devel@lists.01.org > >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel