public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] Maintainers.txt: Add the rule to hand over the package maintain role
@ 2018-11-28  7:31 Liming Gao
  2018-11-28 10:29 ` Ni, Ruiyu
  2018-11-28 12:08 ` Laszlo Ersek
  0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2018-11-28  7:31 UTC (permalink / raw)
  To: edk2-devel

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 Maintainers.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 91a4657adc..d75bbe278d 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -6,7 +6,9 @@ EDK II.
 
 In general, you should not privately email the maintainer. You should
 email the edk2-devel list, and Cc the package maintainers and
-reviewers.
+reviewers. If the package maintainer wants to hand over his role to 
+other people, the package maintainer should send the patch to update 
+Maintainers.txt with new maintainer.
 
 Descriptions of section entries:
 
-- 
2.13.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch] Maintainers.txt: Add the rule to hand over the package maintain role
  2018-11-28  7:31 [Patch] Maintainers.txt: Add the rule to hand over the package maintain role Liming Gao
@ 2018-11-28 10:29 ` Ni, Ruiyu
  2018-11-28 12:08 ` Laszlo Ersek
  1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ruiyu @ 2018-11-28 10:29 UTC (permalink / raw)
  To: Liming Gao, edk2-devel

On 11/28/2018 3:31 PM, Liming Gao wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>   Maintainers.txt | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 91a4657adc..d75bbe278d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -6,7 +6,9 @@ EDK II.
>   
>   In general, you should not privately email the maintainer. You should
>   email the edk2-devel list, and Cc the package maintainers and
> -reviewers.
> +reviewers. If the package maintainer wants to hand over his role to

the role instead of his role? :)

> +other people, the package maintainer should send the patch to update
> +Maintainers.txt with new maintainer.
>   
>   Descriptions of section entries:
>   
> 


-- 
Thanks,
Ray


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] Maintainers.txt: Add the rule to hand over the package maintain role
  2018-11-28  7:31 [Patch] Maintainers.txt: Add the rule to hand over the package maintain role Liming Gao
  2018-11-28 10:29 ` Ni, Ruiyu
@ 2018-11-28 12:08 ` Laszlo Ersek
  1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2018-11-28 12:08 UTC (permalink / raw)
  To: Liming Gao; +Cc: edk2-devel, Philippe Mathieu-Daudé

On 11/28/18 08:31, Liming Gao wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 91a4657adc..d75bbe278d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -6,7 +6,9 @@ EDK II.
>  
>  In general, you should not privately email the maintainer. You should
>  email the edk2-devel list, and Cc the package maintainers and
> -reviewers.
> +reviewers. If the package maintainer wants to hand over his role to 
> +other people, the package maintainer should send the patch to update 
> +Maintainers.txt with new maintainer.
>  
>  Descriptions of section entries:
>  
> 

(1) Using "his" in the above context is grammatically correct English,
as far as I know (note: I'm not a native speaker).

However, given the TianoCore Code of Conduct at

  https://www.tianocore.org/coc.html

I'm going to ask you to please replace "his" with "the".

(2) Please append: "..., and the new maintainer should follow up with an
Acked-by or a Reviewed-by".

Thanks,
Laszlo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-28 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-28  7:31 [Patch] Maintainers.txt: Add the rule to hand over the package maintain role Liming Gao
2018-11-28 10:29 ` Ni, Ruiyu
2018-11-28 12:08 ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox