* [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h
@ 2018-12-11 13:18 Marcin Wojtas
2018-12-11 13:39 ` Leif Lindholm
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Wojtas @ 2018-12-11 13:18 UTC (permalink / raw)
To: edk2-devel; +Cc: leif.lindholm, ard.biesheuvel, nadavh, mw, jsd, jaz, kostap
Recent changes in EDK2 resulted in compilation break
of all Marvell platforms, because the applications
include deprecated ShellBase.h header. Fix that.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Silicon/Marvell/Applications/EepromCmd/EepromCmd.c | 1 -
Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c | 1 -
Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
index f43e411..dc3c95f 100644
--- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
+++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
@@ -34,7 +34,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include <Uefi.h>
-#include <ShellBase.h>
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/DebugLib.h>
diff --git a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
index 9ccb1c7..22a9b8f 100644
--- a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
+++ b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
@@ -31,7 +31,6 @@ ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*******************************************************************************/
-#include <ShellBase.h>
#include <Uefi.h>
#include <Library/BaseLib.h>
diff --git a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
index cf91581..a028c54 100644
--- a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
+++ b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
@@ -32,7 +32,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*******************************************************************************/
#include <Uefi.h>
-#include <ShellBase.h>
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h
2018-12-11 13:18 [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h Marcin Wojtas
@ 2018-12-11 13:39 ` Leif Lindholm
0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2018-12-11 13:39 UTC (permalink / raw)
To: Marcin Wojtas; +Cc: edk2-devel, ard.biesheuvel, nadavh, jsd, jaz, kostap
On Tue, Dec 11, 2018 at 02:18:35PM +0100, Marcin Wojtas wrote:
> Recent changes in EDK2 resulted in compilation break
> of all Marvell platforms, because the applications
> include deprecated ShellBase.h header. Fix that.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 852195e6f5.
Thanks for quick turnaround!
> ---
> Silicon/Marvell/Applications/EepromCmd/EepromCmd.c | 1 -
> Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c | 1 -
> Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> index f43e411..dc3c95f 100644
> --- a/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> +++ b/Silicon/Marvell/Applications/EepromCmd/EepromCmd.c
> @@ -34,7 +34,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> #include <Uefi.h>
>
> -#include <ShellBase.h>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> #include <Library/DebugLib.h>
> diff --git a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> index 9ccb1c7..22a9b8f 100644
> --- a/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> +++ b/Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.c
> @@ -31,7 +31,6 @@ ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> *******************************************************************************/
> -#include <ShellBase.h>
> #include <Uefi.h>
>
> #include <Library/BaseLib.h>
> diff --git a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> index cf91581..a028c54 100644
> --- a/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> +++ b/Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.c
> @@ -32,7 +32,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> *******************************************************************************/
> #include <Uefi.h>
> -#include <ShellBase.h>
>
> #include <Library/BaseLib.h>
> #include <Library/BaseMemoryLib.h>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-11 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-11 13:18 [platforms: PATCH 1/1] Marvell/Applications: Drop dependency on ShellBase.h Marcin Wojtas
2018-12-11 13:39 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox