public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Star Zeng <star.zeng@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>
Subject: [PATCH V3 00/17] Merge EmuVariable and Real variable driver
Date: Tue, 15 Jan 2019 18:29:22 +0800	[thread overview]
Message-ID: <1547548179-42552-1-git-send-email-star.zeng@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323

Purpose:
1. Add emulated variable NV mode support in
   MdeModulePkg\Universal\Variable\RuntimeDxe.
   Platform can configure PCD statically (build time) or
   dynamically (boot time) to support emulated variable NV mode.
2. Remove MdeModulePkg\Universal\Variable\EmuRuntimeDxe whose
   most codes are duplicated.


V3:
Addressed all the great feedbacks from Jian, Hao, Laszlo and Leif, thanks.
Pick up RB and AB tags.

Repo: git@github.com:lzeng14/edk2.git
Branch: MergedVariableDriver_EmuNvMode_V3

Patches 1~9: Preparation
  Patch 3 and 9 are new added based on feedbacks.
Patch 10~11: Real work
Patch 12~17: Migration for platforms and cleanup


V2: Addressed all the feedbacks from Laszlo, thanks.

Repo: git@github.com:lzeng14/edk2.git
Branch: MergedVariableDriver_EmuNvMode_V2

Patches 1~7: Preparation
  Patch 6 and 7 are new separated.
Patch 8~9: Real work
Patch 10~15: Migration for platforms and cleanup
  Patch 11 is new added to let ArmVirtXen be aligned with ArmVirtQemuXXX.


V1:

Repo: git@github.com:lzeng14/edk2.git
Branch: MergedVariableDriver_EmuNvMode

Patches 1~5: Preparation
Patch 6~7: Real work
Patch 8~12: Migration for platforms and cleanup

Test done:
Build code with VS2012, VS2015 and GCC49.
Regression: Boot Nt32, Ovmf (including 32, 3264 and 64 with no SMM) to UEFI SHELL.
            Boot some internal platform to UEFI SHELL and Windows.
Functionality: Boot Nt32, Ovmf (including 32, 3264 and 64 with no SMM) to UEFI SHELL
               with PcdEmuVariableNvModeEnable == TRUE.

More test will be welcome and appreciated. :)

Patches to update edk2-platforms Repo will be sent out separately.

Star Zeng (17):
  MdeModulePkg Variable: Add some missing changes for 9b18845
  MdeModulePkg Variable: Abstract InitRealNonVolatileVariableStore
  MdeModulePkg Variable: Move "extern XXX" to Variable.h
  MdeModulePkg Variable: Not get NV PCD in
    VariableWriteServiceInitialize
  MdeModulePkg Variable: Abstract VariableWriteServiceInitializeDxe/Smm
  MdeModulePkg Variable: Remove CacheOffset in UpdateVariable()
  MdeModulePkg Variable: type case VolatileBase to UINTN directly
  MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec
  MdeModulePkg: Refine description a little for
    PcdEmuVariableNvStoreReserved
  MdeModulePkg Variable: Add emulated variable NV mode support
  MdeModulePkg VariablePei: Don't check BOOT_IN_RECOVERY_MODE
  ArmVirtXen: Use merged variable driver for emulated NV mode
  ArmVirtXen: Link VarCheckUefiLib NULL class library instance
  BeagleBoardPkg: Use merged variable driver for emulated NV mode
  QuarkMin: Use merged variable driver for emulated NV mode
  CorebootPayloadPkg: Use merged variable driver for emulated NV mode
  MdeModulePkg: Remove EmuVariableRuntimeDxe

 ArmVirtPkg/ArmVirtXen.dsc                          |   12 +-
 ArmVirtPkg/ArmVirtXen.fdf                          |    4 +-
 BeagleBoardPkg/BeagleBoardPkg.dsc                  |   14 +-
 BeagleBoardPkg/BeagleBoardPkg.fdf                  |    4 +-
 CorebootPayloadPkg/CorebootPayloadPkg.fdf          |    4 +-
 CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc      |   11 +-
 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc   |   11 +-
 MdeModulePkg/MdeModulePkg.dec                      |   16 +-
 MdeModulePkg/MdeModulePkg.dsc                      |    5 +-
 MdeModulePkg/MdeModulePkg.uni                      |   14 +-
 .../Universal/Variable/EmuRuntimeDxe/EmuVariable.c | 1820 --------------------
 .../EmuRuntimeDxe/EmuVariableRuntimeDxe.inf        |   88 -
 .../EmuRuntimeDxe/EmuVariableRuntimeDxe.uni        |   22 -
 .../EmuRuntimeDxe/EmuVariableRuntimeDxeExtra.uni   |   19 -
 .../Variable/EmuRuntimeDxe/InitVariable.c          |  259 ---
 .../Universal/Variable/EmuRuntimeDxe/Variable.h    |  277 ---
 MdeModulePkg/Universal/Variable/Pei/Variable.c     |    8 +-
 .../Universal/Variable/Pei/VariablePei.inf         |    3 +-
 .../Universal/Variable/RuntimeDxe/Variable.c       |  431 +++--
 .../Universal/Variable/RuntimeDxe/Variable.h       |   19 +-
 .../Universal/Variable/RuntimeDxe/VariableDxe.c    |  103 +-
 .../Variable/RuntimeDxe/VariableRuntimeDxe.inf     |    4 +-
 .../Universal/Variable/RuntimeDxe/VariableSmm.c    |   90 +-
 .../Universal/Variable/RuntimeDxe/VariableSmm.inf  |    4 +-
 QuarkPlatformPkg/QuarkMin.dsc                      |    8 +-
 QuarkPlatformPkg/QuarkMin.fdf                      |    4 +-
 26 files changed, 518 insertions(+), 2736 deletions(-)
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariable.c
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.uni
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxeExtra.uni
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/InitVariable.c
 delete mode 100644 MdeModulePkg/Universal/Variable/EmuRuntimeDxe/Variable.h

-- 
2.7.0.windows.1



             reply	other threads:[~2019-01-15 10:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-15 10:29 Star Zeng [this message]
2019-01-15 10:29 ` [PATCH V3 01/17] MdeModulePkg Variable: Add some missing changes for 9b18845 Star Zeng
2019-01-15 10:29 ` [PATCH V3 02/17] MdeModulePkg Variable: Abstract InitRealNonVolatileVariableStore Star Zeng
2019-01-15 10:29 ` [PATCH V3 03/17] MdeModulePkg Variable: Move "extern XXX" to Variable.h Star Zeng
2019-01-16  7:28   ` Wu, Hao A
2019-01-15 10:29 ` [PATCH V3 04/17] MdeModulePkg Variable: Not get NV PCD in VariableWriteServiceInitialize Star Zeng
2019-01-16  7:28   ` Wu, Hao A
2019-01-15 10:29 ` [PATCH V3 05/17] MdeModulePkg Variable: Abstract VariableWriteServiceInitializeDxe/Smm Star Zeng
2019-01-15 10:29 ` [PATCH V3 06/17] MdeModulePkg Variable: Remove CacheOffset in UpdateVariable() Star Zeng
2019-01-15 10:29 ` [PATCH V3 07/17] MdeModulePkg Variable: type case VolatileBase to UINTN directly Star Zeng
2019-01-15 10:29 ` [PATCH V3 08/17] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dec Star Zeng
2019-01-15 10:29 ` [PATCH V3 09/17] MdeModulePkg: Refine description a little for PcdEmuVariableNvStoreReserved Star Zeng
2019-01-16  7:28   ` Wu, Hao A
2019-01-15 10:29 ` [PATCH V3 10/17] MdeModulePkg Variable: Add emulated variable NV mode support Star Zeng
2019-01-16  7:28   ` Wu, Hao A
2019-01-15 10:29 ` [PATCH V3 11/17] MdeModulePkg VariablePei: Don't check BOOT_IN_RECOVERY_MODE Star Zeng
2019-01-16  7:28   ` Wu, Hao A
2019-01-15 10:29 ` [PATCH V3 12/17] ArmVirtXen: Use merged variable driver for emulated NV mode Star Zeng
2019-01-16 12:58   ` Ard Biesheuvel
2019-01-15 10:29 ` [PATCH V3 13/17] ArmVirtXen: Link VarCheckUefiLib NULL class library instance Star Zeng
2019-01-16 12:58   ` Ard Biesheuvel
2019-01-15 10:29 ` [PATCH V3 14/17] BeagleBoardPkg: Use merged variable driver for emulated NV mode Star Zeng
2019-01-15 11:35   ` Leif Lindholm
2019-01-15 10:29 ` [PATCH V3 15/17] QuarkMin: " Star Zeng
2019-01-16 17:46   ` Kinney, Michael D
2019-01-16 17:55   ` Steele, Kelly
2019-01-15 10:29 ` [PATCH V3 16/17] CorebootPayloadPkg: " Star Zeng
2019-01-16  5:22   ` You, Benjamin
2019-01-15 10:29 ` [PATCH V3 17/17] MdeModulePkg: Remove EmuVariableRuntimeDxe Star Zeng
2019-01-16  7:29   ` Wu, Hao A
2019-01-16  3:01 ` [PATCH V3 00/17] Merge EmuVariable and Real variable driver Wang, Jian J
2019-01-16  7:40 ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1547548179-42552-1-git-send-email-star.zeng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox