public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including
@ 2019-01-16 10:25 Star Zeng
  2019-01-16 12:55 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2019-01-16 10:25 UTC (permalink / raw)
  To: edk2-devel; +Cc: Star Zeng, Ard Biesheuvel, Leif Lindholm, Michael D Kinney

For https://bugzilla.tianocore.org/show_bug.cgi?id=1323,
EmuVariable will be merged to real variable driver, and
EmuVariableRuntimeDxe will be removed finally.

As D03 and D05 are using the real variable driver VariableRuntimeDxe,
this patch removes EmuVariableRuntimeDxe including in D03.dsc and
D05.dsc directly.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 Platform/Hisilicon/D03/D03.dsc | 1 -
 Platform/Hisilicon/D05/D05.dsc | 2 --
 2 files changed, 3 deletions(-)

diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 23764ef0e961..3f59be22ec8e 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -348,7 +348,6 @@ [Components.common]
   Platform/Hisilicon/D03/Drivers/SFC/SfcDxeDriver.inf
 
   MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
-  MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
   Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
     <LibraryClasses>
diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index ee306a8be555..25db1c38d287 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -481,8 +481,6 @@ [Components.common]
   Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf
 
   MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
-  # Sometimes we can use EmuVariableRuntimeDxe instead of real flash variable store for debug.
-  #MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
   Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
   MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
     <LibraryClasses>
-- 
2.7.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including
  2019-01-16 10:25 [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including Star Zeng
@ 2019-01-16 12:55 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-01-16 12:55 UTC (permalink / raw)
  To: Star Zeng; +Cc: edk2-devel@lists.01.org, Leif Lindholm, Michael D Kinney

On Wed, 16 Jan 2019 at 11:25, Star Zeng <star.zeng@intel.com> wrote:
>
> For https://bugzilla.tianocore.org/show_bug.cgi?id=1323,
> EmuVariable will be merged to real variable driver, and
> EmuVariableRuntimeDxe will be removed finally.
>
> As D03 and D05 are using the real variable driver VariableRuntimeDxe,
> this patch removes EmuVariableRuntimeDxe including in D03.dsc and
> D05.dsc directly.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/D03.dsc | 1 -
>  Platform/Hisilicon/D05/D05.dsc | 2 --
>  2 files changed, 3 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
> index 23764ef0e961..3f59be22ec8e 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -348,7 +348,6 @@ [Components.common]
>    Platform/Hisilicon/D03/Drivers/SFC/SfcDxeDriver.inf
>
>    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> -  MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
>    Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
>    MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
>      <LibraryClasses>
> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
> index ee306a8be555..25db1c38d287 100644
> --- a/Platform/Hisilicon/D05/D05.dsc
> +++ b/Platform/Hisilicon/D05/D05.dsc
> @@ -481,8 +481,6 @@ [Components.common]
>    Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf
>
>    MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf
> -  # Sometimes we can use EmuVariableRuntimeDxe instead of real flash variable store for debug.
> -  #MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntimeDxe.inf
>    Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
>    MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {
>      <LibraryClasses>
> --
> 2.7.0.windows.1
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-16 12:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 10:25 [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including Star Zeng
2019-01-16 12:55 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox