* [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib
@ 2019-01-25 6:42 Jagadeesh Ujja
2019-01-25 10:02 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Jagadeesh Ujja @ 2019-01-25 6:42 UTC (permalink / raw)
To: edk2-devel, leif.lindholm, ard.biesheuvel
Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on
Sgi platforms. These will be consumed by MM_STANDALONE drivers.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
---
Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
index 2a17e9f..65dd6ac 100644
--- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
+++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
@@ -71,6 +71,11 @@
StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
+[LibraryClasses.common.MM_STANDALONE]
+ HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
+ MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
+ MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
+
################################################################################
#
# Pcd Section - list of all EDK II PCD Entries defined by this Platform
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib
2019-01-25 6:42 [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib Jagadeesh Ujja
@ 2019-01-25 10:02 ` Ard Biesheuvel
2019-01-25 10:29 ` Jagadeesh Ujja
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2019-01-25 10:02 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org, Leif Lindholm
On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on
> Sgi platforms. These will be consumed by MM_STANDALONE drivers.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
> ---
> Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> index 2a17e9f..65dd6ac 100644
> --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> @@ -71,6 +71,11 @@
>
> StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
>
> +[LibraryClasses.common.MM_STANDALONE]
> + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
> + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
> +
Should you add the entrypoint library as well?
> ################################################################################
> #
> # Pcd Section - list of all EDK II PCD Entries defined by this Platform
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib
2019-01-25 10:02 ` Ard Biesheuvel
@ 2019-01-25 10:29 ` Jagadeesh Ujja
2019-01-25 10:46 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Jagadeesh Ujja @ 2019-01-25 10:29 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
hi Ard
On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on
> > Sgi platforms. These will be consumed by MM_STANDALONE drivers.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
> > ---
> > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > index 2a17e9f..65dd6ac 100644
> > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > @@ -71,6 +71,11 @@
> >
> > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
> >
> > +[LibraryClasses.common.MM_STANDALONE]
> > + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> > + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
> > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
> > +
>
> Should you add the entrypoint library as well?
in https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
we already have
StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
Are you looking for this?
> > ################################################################################
> > #
> > # Pcd Section - list of all EDK II PCD Entries defined by this Platform
> > --
> > 2.7.4
> >
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib
2019-01-25 10:29 ` Jagadeesh Ujja
@ 2019-01-25 10:46 ` Ard Biesheuvel
2019-01-25 10:51 ` Ard Biesheuvel
0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2019-01-25 10:46 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org
On Fri, 25 Jan 2019 at 11:29, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> hi Ard
>
> On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > >
> > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on
> > > Sgi platforms. These will be consumed by MM_STANDALONE drivers.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
> > > ---
> > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > index 2a17e9f..65dd6ac 100644
> > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > @@ -71,6 +71,11 @@
> > >
> > > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
> > >
> > > +[LibraryClasses.common.MM_STANDALONE]
> > > + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> > > + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
> > > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
> > > +
> >
> > Should you add the entrypoint library as well?
>
> in https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> we already have
> StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
> StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
>
> Are you looking for this?
>
Ah yes, I missed that.
But in fact, we should replace that reference with the MdePkg version,
and drop the one from StandaloneMmPkg entirely
> > > ################################################################################
> > > #
> > > # Pcd Section - list of all EDK II PCD Entries defined by this Platform
> > > --
> > > 2.7.4
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib
2019-01-25 10:46 ` Ard Biesheuvel
@ 2019-01-25 10:51 ` Ard Biesheuvel
0 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2019-01-25 10:51 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org
On Fri, 25 Jan 2019 at 11:46, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 25 Jan 2019 at 11:29, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > hi Ard
> >
> > On Fri, Jan 25, 2019 at 3:32 PM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 25 Jan 2019 at 07:42, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > >
> > > > Include the HobLib, MmServicesTableLib and MemoryAllocationLib libraries on
> > > > Sgi platforms. These will be consumed by MM_STANDALONE drivers.
> > > >
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
> > > > ---
> > > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > > index 2a17e9f..65dd6ac 100644
> > > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > > > @@ -71,6 +71,11 @@
> > > >
> > > > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
> > > >
> > > > +[LibraryClasses.common.MM_STANDALONE]
> > > > + HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> > > > + MmServicesTableLib|MdePkg/Library/StandaloneMmServicesTableLib/StandaloneMmServicesTableLib.inf
> > > > + MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmMemoryAllocationLib/StandaloneMmMemoryAllocationLib.inf
> > > > +
> > >
> > > Should you add the entrypoint library as well?
> >
> > in https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc
> > we already have
> > StandaloneMmDriverEntryPoint|StandaloneMmPkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf
> > StandaloneMmCoreEntryPoint|StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf
> >
> > Are you looking for this?
> >
>
> Ah yes, I missed that.
>
> But in fact, we should replace that reference with the MdePkg version,
> and drop the one from StandaloneMmPkg entirely
>
For this patch
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as b4069053a8a6..b0bb325f2033
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-25 10:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25 6:42 [PATCH edk2-platforms] Platform/ARM/SgiPkg: Include HobLib, MmServicesTableLib and MemoryAllocationLib Jagadeesh Ujja
2019-01-25 10:02 ` Ard Biesheuvel
2019-01-25 10:29 ` Jagadeesh Ujja
2019-01-25 10:46 ` Ard Biesheuvel
2019-01-25 10:51 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox