From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD0F6211CC3AD for ; Wed, 20 Feb 2019 17:03:15 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2019 17:03:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,393,1544515200"; d="scan'208";a="320744491" Received: from thirashi-mobl.gar.corp.intel.com (HELO localhost) ([10.251.147.230]) by fmsmga006.fm.intel.com with ESMTP; 20 Feb 2019 17:03:14 -0800 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C028CBC@SHSMSX104.ccr.corp.intel.com> References: <20190218041141.21363-1-jordan.l.justen@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C023766@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3E1923@SHSMSX104.ccr.corp.intel.com> <155068462865.16578.13632602389562462232@jljusten-skl> <734D49CCEBEEF84792F5B80ED585239D5C028CBC@SHSMSX104.ccr.corp.intel.com> Cc: "Wu, Hao A" , Anthony Perard , Laszlo Ersek , "Zeng, Star" , Andrew Fish To: "Gao, Liming" , "Ni, Ray" , "edk2-devel@lists.01.org" From: Jordan Justen Message-ID: <155071099391.27635.17148748494622597613@jljusten-skl> User-Agent: alot/0.8.1 Date: Wed, 20 Feb 2019 17:03:14 -0800 Subject: Re: [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 01:03:15 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-02-20 16:15:59, Ni, Ray wrote: > > -----Original Message----- > > From: Justen, Jordan L > > Sent: Thursday, February 21, 2019 1:44 AM > > To: Gao, Liming ; Ni, Ray ; edk= 2- > > devel@lists.01.org > > Cc: Wu, Hao A ; Anthony Perard > > ; Laszlo Ersek ; Zeng, > > Star > > Subject: Re: [PATCH 00/10] Fix PEI Core issue during TemporaryRamMigrat= ion > >=20 > > On 2019-02-20 05:27:21, Ni, Ray wrote: > > > On 2/19/2019 9:25 PM, Gao, Liming wrote: > > > > Ray: > > > > > > > > Now, real platform has no side effect. So, only TempRamDone > > > > PPI is produced. For emulator platform, is there any side > > > > effect when both Temporary RAM and Permanent RAM are enabled? > > > > > > > > > > No side effect when both of T-RAM and P-RAM are enabled. > > > Which means no side effect when neither of the PPIs is produced. > > > But for demo purpose, I think producing TemporaryRamDone PPI makes > > sense. > >=20 > > In addition to being a demo/sample, it also provides a check that no mo= dules > > are accessing temp-ram after temp-ram should no longer be used. > >=20 > > > I will work out patches for EmulatorPkg to produce TemoraryRamDone. > >=20 > > I think we should first fix TemporaryRamSupport usage. Otherwise, we are > > just hiding the bug. > >=20 > > Have you tried these patches to verify that they fix the issue in your = setup? > > Have you taken a look at the patches to see what problem is being fixed? >=20 > I feel the change to PeiCore is a bit complex and introduce additional de= ps (assembly). I asked about this last November, and as I recall, Andrew said we can (and should) add assembly to PEI Core if it is required to meet the specs. > Behavior of ARM and x86 becomes different. (The patch only fixes x86 issu= e.) Yes. Similar code should be written for ARM, but I don't have experience with ARM assembly code. > Given there is no real requirement on this, Isn't the requirement to be compatible with the PI specification? It seems that at least you and Liu Yu have encountered a build environment that produces code for PEI Core that isn't compatible with the PI specification. It doesn't seem like the best response to this is to just change the platform boot path and ignore the bug. I do agree that after this issue is fixed, we can then consider changing the platform. The downside to changing it then will be to leave an untested code path, but at least we won't leave it with a known bug present. -Jordan > I prefer to not change PeiCore.