* [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
@ 2019-03-05 6:41 Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge Jagadeesh Ujja
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-05 6:41 UTC (permalink / raw)
To: edk2-devel, leif.lindholm, ard.biesheuvel
This patchset updates the product names for SGI-Clark.Ares and
SGI-Clark.Helios platforms.
The first patch replaces all uses of sgiclarka with rdn1edge.
The second patch replaces all use of sgiclarkh with rde1edge.
Jagadeesh Ujja (2):
Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge
Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl | 66 ++++++++++----------
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc | 0
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} | 6 +-
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl | 16 ++---
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc | 16 ++---
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} | 6 +-
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 12 ++--
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 4 +-
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 8 +--
Platform/ARM/SgiPkg/SgiPlatform.dec | 4 +-
Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +-
Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +-
12 files changed, 73 insertions(+), 73 deletions(-)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl (68%)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc (100%)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} (91%)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl (85%)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc (93%)
rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} (92%)
--
2.7.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge
2019-03-05 6:41 [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
@ 2019-03-05 6:41 ` Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 2/2] Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge Jagadeesh Ujja
2019-03-13 8:48 ` [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2 siblings, 0 replies; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-05 6:41 UTC (permalink / raw)
To: edk2-devel, leif.lindholm, ard.biesheuvel
Replace all usage of 'SgiClark' with 'RdN1E1Edge' and 'SgiClarkAres'
with 'RdN1Edge' as per the updated product names.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
---
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl | 16 ++++++++--------
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc | 16 ++++++++--------
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} | 6 +++---
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 8 ++++----
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 +-
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 6 +++---
Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +-
9 files changed, 30 insertions(+), 30 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
similarity index 85%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl
rename to Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
index 69dc33c..9226229 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl
@@ -20,49 +20,49 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARMSGI",
EFI_ACPI_ARM_OEM_REVISION) {
Scope (_SB) {
- Device (CP00) { // Ares: Cluster 0, Cpu 0
+ Device (CP00) { // Neoverse-N1: Cluster 0, Cpu 0
Name (_HID, "ACPI0007")
Name (_UID, 0)
Name (_STA, 0xF)
}
- Device (CP01) { // Ares: Cluster 0, Cpu 1
+ Device (CP01) { // Neoverse-N1: Cluster 0, Cpu 1
Name (_HID, "ACPI0007")
Name (_UID, 1)
Name (_STA, 0xF)
}
- Device (CP02) { // Ares: Cluster 0, Cpu 2
+ Device (CP02) { // Neoverse-N1: Cluster 0, Cpu 2
Name (_HID, "ACPI0007")
Name (_UID, 2)
Name (_STA, 0xF)
}
- Device (CP03) { // Ares: Cluster 0, Cpu 3
+ Device (CP03) { // Neoverse-N1: Cluster 0, Cpu 3
Name (_HID, "ACPI0007")
Name (_UID, 3)
Name (_STA, 0xF)
}
- Device (CP04) { // Ares: Cluster 1, Cpu 0
+ Device (CP04) { // Neoverse-N1: Cluster 1, Cpu 0
Name (_HID, "ACPI0007")
Name (_UID, 4)
Name (_STA, 0xF)
}
- Device (CP05) { // Ares: Cluster 1, Cpu 1
+ Device (CP05) { // Neoverse-N1: Cluster 1, Cpu 1
Name (_HID, "ACPI0007")
Name (_UID, 5)
Name (_STA, 0xF)
}
- Device (CP06) { // Ares: Cluster 1, Cpu 2
+ Device (CP06) { // Neoverse-N1: Cluster 1, Cpu 2
Name (_HID, "ACPI0007")
Name (_UID, 6)
Name (_STA, 0xF)
}
- Device (CP07) { // Ares: Cluster 1, Cpu 3
+ Device (CP07) { // Neoverse-N1: Cluster 1, Cpu 3
Name (_HID, "ACPI0007")
Name (_UID, 7)
Name (_STA, 0xF)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc
similarity index 93%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc
rename to Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc
index f60b62d..d29eda5 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAres/Madt.aslc
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc
@@ -120,36 +120,36 @@ STATIC EFI_ACPI_6_2_MULTIPLE_APIC_DESCRIPTION_TABLE Madt = {
// Efficiency)
// Note: The GIC Structure of the primary CPU must be the first entry
// (see note in 5.2.12.14 GICC Structure of ACPI v6.2).
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-0
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-0
0, 0, GET_MPID(0x0, 0x0), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-1
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-1
0, 1, GET_MPID(0x0, 0x100), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-2
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-2
0, 2, GET_MPID(0x0, 0x200), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-3
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-3
0, 3, GET_MPID(0x0, 0x300), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-4
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-4
0, 4, GET_MPID(0x100, 0x00), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-5
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-5
0, 5, GET_MPID(0x100, 0x100), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-6
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-6
0, 6, GET_MPID(0x100, 0x200), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */),
- EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Ares-7
+ EFI_ACPI_6_2_GICC_STRUCTURE_INIT( // Neoverse-N1-7
0, 7, GET_MPID(0x100, 0x300), EFI_ACPI_6_2_GIC_ENABLED, 23,
FixedPcdGet32 (PcdGicDistributorBase),
0x2c020000, 0x2c010000, 25, 0 /* GicRBase */, 0 /* Efficiency */)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
similarity index 92%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf
rename to Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
index d4bacdb..aa9fec7 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
@@ -15,7 +15,7 @@
[Defines]
INF_VERSION = 0x0001001A
- BASE_NAME = SgiClarkAresAcpiTables
+ BASE_NAME = RdN1EdgeAcpiTables
FILE_GUID = 4b0b91d0-4a05-45c4-88a7-88e170e76694
MODULE_TYPE = USER_DEFINED
VERSION_STRING = 1.0
@@ -26,8 +26,8 @@
Gtdt.aslc
Iort.aslc
Mcfg.aslc
- SgiClarkAres/Dsdt.asl
- SgiClarkAres/Madt.aslc
+ RdN1Edge/Dsdt.asl
+ RdN1Edge/Madt.aslc
Spcr.aslc
Ssdt.asl
diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
index 5c1eec0..e00febd 100644
--- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
@@ -48,10 +48,10 @@ ArmSgiPkgEntryPoint (
if ((PartNum == SGI575_PART_NUM) && (ConfigId == SGI575_CONF_NUM)) {
Status = LocateAndInstallAcpiFromFv (&gSgi575AcpiTablesFileGuid);
- } else if ((PartNum == SGI_CLARK_PART_NUM) &&
- (ConfigId == SGI_CLARK_CONF_ARES)) {
- Status = LocateAndInstallAcpiFromFv (&gSgiClarkAresAcpiTablesFileGuid);
- } else if ((PartNum == SGI_CLARK_PART_NUM) &&
+ } else if ((PartNum == RD_N1E1_EDGE_PART_NUM) &&
+ (ConfigId == RD_N1_EDGE_CONF_ID)) {
+ Status = LocateAndInstallAcpiFromFv (&gRdN1EdgeAcpiTablesFileGuid);
+ } else if ((PartNum == RD_N1E1_EDGE_PART_NUM) &&
(ConfigId == SGI_CLARK_CONF_HELIOS)) {
Status = LocateAndInstallAcpiFromFv (&gSgiClarkHeliosAcpiTablesFileGuid);
} else {
diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
index 3283ff0..7b8b3b6 100644
--- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
+++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
@@ -37,7 +37,7 @@
[Guids]
gArmSgiPlatformIdDescriptorGuid
gSgi575AcpiTablesFileGuid
- gSgiClarkAresAcpiTablesFileGuid
+ gRdN1EdgeAcpiTablesFileGuid
gSgiClarkHeliosAcpiTablesFileGuid
[FeaturePcd]
diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
index b9a662a..99bad78 100644
--- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
+++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
@@ -76,9 +76,9 @@
#define SGI575_CONF_NUM 0x3
#define SGI575_PART_NUM 0x783
-//SGI-Clark Platform Identification values
-#define SGI_CLARK_PART_NUM 0x786
-#define SGI_CLARK_CONF_ARES 0x1
+//RDN1E1EDGE Platform Identification values
+#define RD_N1E1_EDGE_PART_NUM 0x786
+#define RD_N1_EDGE_CONF_ID 0x1
#define SGI_CLARK_CONF_HELIOS 0x2
#define SGI_CONFIG_MASK 0x0F
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiPlatform.dec
index 10157c7..512ee4c 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dec
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dec
@@ -33,7 +33,7 @@
gArmSgiPlatformIdDescriptorGuid = { 0xf56f152a, 0xad2a, 0x11e6, { 0xb1, 0xa7, 0x00, 0x50, 0x56, 0x3c, 0x44, 0xcc } }
gArmSgiTokenSpaceGuid = { 0x577d6941, 0xaea1, 0x40b4, { 0x90, 0x93, 0x2a, 0x86, 0x61, 0x72, 0x5a, 0x57 } }
gSgi575AcpiTablesFileGuid = { 0xc712719a, 0x0aaf, 0x438c, { 0x9c, 0xdd, 0x35, 0xab, 0x4d, 0x60, 0x20, 0x7d } }
- gSgiClarkAresAcpiTablesFileGuid = { 0x4b0b91d0, 0x4a05, 0x45c4, { 0x88, 0xa7, 0x88, 0xe1, 0x70, 0xe7, 0x66, 0x94 } }
+ gRdN1EdgeAcpiTablesFileGuid = { 0x4b0b91d0, 0x4a05, 0x45c4, { 0x88, 0xa7, 0x88, 0xe1, 0x70, 0xe7, 0x66, 0x94 } }
gSgiClarkHeliosAcpiTablesFileGuid = { 0x2af40815, 0xa84e, 0x4de9, { 0x8c, 0x38, 0x91, 0x40, 0xb3, 0x54, 0x40, 0x73 } }
[PcdsFeatureFlag.common]
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
index bdb4ecb..f2d6672 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
@@ -281,7 +281,7 @@
#
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
- Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf
+ Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
index 7916a52..5e8ccec 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
+++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
@@ -106,7 +106,7 @@ READ_LOCK_STATUS = TRUE
#
INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
- INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/SgiClarkAresAcpiTables.inf
+ INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH edk2-platforms 2/2] Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge
2019-03-05 6:41 [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge Jagadeesh Ujja
@ 2019-03-05 6:41 ` Jagadeesh Ujja
2019-03-13 8:48 ` [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2 siblings, 0 replies; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-05 6:41 UTC (permalink / raw)
To: edk2-devel, leif.lindholm, ard.biesheuvel
Replace all usage of 'SgiClark' with 'RdN1E1Edge' and 'SgiClarkHelios
with 'RdE1Edge' as per the updated product names.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jagadeesh Ujja <jagadeesh.ujja@arm.com>
---
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl | 66 ++++++++++----------
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc | 0
Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} | 6 +-
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 4 +-
Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 +-
Platform/ARM/SgiPkg/Include/SgiPlatform.h | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.dec | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.dsc | 2 +-
Platform/ARM/SgiPkg/SgiPlatform.fdf | 2 +-
9 files changed, 43 insertions(+), 43 deletions(-)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl b/Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl
similarity index 68%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl
rename to Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl
index 7cfc419..c2f2dfb 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Dsdt.asl
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl
@@ -20,195 +20,195 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARMSGI",
EFI_ACPI_ARM_OEM_REVISION) {
Scope (_SB) {
//
- // HeliosCores 8X2 Processor declaration
+ // Neoverse-E1 8X2 Processor declaration
//
- Device (CP00) { // HeliosCore: Cluster 0, Cpu 0, Thread 0
+ Device (CP00) { // Neoverse-E1: Cluster 0, Cpu 0, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 0)
Name (_STA, 0xF)
}
- Device (CP01) { // HeliosCore: Cluster 0, Cpu 0, Thread 1
+ Device (CP01) { // Neoverse-E1: Cluster 0, Cpu 0, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 1)
Name (_STA, 0xF)
}
- Device (CP02) { // HeliosCore: Cluster 0, Cpu 1, Thread 0
+ Device (CP02) { // Neoverse-E1: Cluster 0, Cpu 1, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 2)
Name (_STA, 0xF)
}
- Device (CP03) { // HeliosCore: Cluster 0, Cpu 1, Thread 1
+ Device (CP03) { // Neoverse-E1: Cluster 0, Cpu 1, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 3)
Name (_STA, 0xF)
}
- Device (CP04) { // HeliosCore: Cluster 0, Cpu 2, Thread 0
+ Device (CP04) { // Neoverse-E1: Cluster 0, Cpu 2, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 4)
Name (_STA, 0xF)
}
- Device (CP05) { // HeliosCore: Cluster 0, Cpu 2, Thread 1
+ Device (CP05) { // Neoverse-E1: Cluster 0, Cpu 2, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 5)
Name (_STA, 0xF)
}
- Device (CP06) { // HeliosCore: Cluster 0, Cpu 3, Thread 0
+ Device (CP06) { // Neoverse-E1: Cluster 0, Cpu 3, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 6)
Name (_STA, 0xF)
}
- Device (CP07) { // HeliosCore: Cluster 0, Cpu 3, Thread 1
+ Device (CP07) { // Neoverse-E1: Cluster 0, Cpu 3, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 7)
Name (_STA, 0xF)
}
- Device (CP08) { // HeliosCore: Cluster 0, Cpu 4, Thread 0
+ Device (CP08) { // Neoverse-E1: Cluster 0, Cpu 4, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 8)
Name (_STA, 0xF)
}
- Device (CP09) { // HeliosCore: Cluster 0, Cpu 4, Thread 1
+ Device (CP09) { // Neoverse-E1: Cluster 0, Cpu 4, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 9)
Name (_STA, 0xF)
}
- Device (CP10) { // HeliosCore: Cluster 0, Cpu 5, Thread 0
+ Device (CP10) { // Neoverse-E1: Cluster 0, Cpu 5, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 10)
Name (_STA, 0xF)
}
- Device (CP11) { // HeliosCore: Cluster 0, Cpu 5, Thread 1
+ Device (CP11) { // Neoverse-E1: Cluster 0, Cpu 5, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 11)
Name (_STA, 0xF)
}
- Device (CP12) { // HeliosCore: Cluster 0, Cpu 6, Thread 0
+ Device (CP12) { // Neoverse-E1: Cluster 0, Cpu 6, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 12)
Name (_STA, 0xF)
}
- Device (CP13) { // HeliosCore: Cluster 0, Cpu 6, Thread 1
+ Device (CP13) { // Neoverse-E1: Cluster 0, Cpu 6, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 13)
Name (_STA, 0xF)
}
- Device (CP14) { // HeliosCore: Cluster 0, Cpu 7, Thread 0
+ Device (CP14) { // Neoverse-E1: Cluster 0, Cpu 7, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 14)
Name (_STA, 0xF)
}
- Device (CP15) { // HeliosCore: Cluster 0, Cpu 7, Thread 1
+ Device (CP15) { // Neoverse-E1: Cluster 0, Cpu 7, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 15)
Name (_STA, 0xF)
}
- Device (CP16) { // HeliosCore: Cluster 0, Cpu 0, Thread 0
+ Device (CP16) { // Neoverse-E1: Cluster 0, Cpu 0, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 16)
Name (_STA, 0xF)
}
- Device (CP17) { // HeliosCore: Cluster 0, Cpu 0, Thread 1
+ Device (CP17) { // Neoverse-E1: Cluster 0, Cpu 0, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 17)
Name (_STA, 0xF)
}
- Device (CP18) { // HeliosCore: Cluster 0, Cpu 1, Thread 0
+ Device (CP18) { // Neoverse-E1: Cluster 0, Cpu 1, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 18)
Name (_STA, 0xF)
}
- Device (CP19) { // HeliosCore: Cluster 0, Cpu 1, Thread 1
+ Device (CP19) { // Neoverse-E1: Cluster 0, Cpu 1, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 19)
Name (_STA, 0xF)
}
- Device (CP20) { // HeliosCore: Cluster 0, Cpu 2, Thread 0
+ Device (CP20) { // Neoverse-E1: Cluster 0, Cpu 2, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 20)
Name (_STA, 0xF)
}
- Device (CP21) { // HeliosCore: Cluster 0, Cpu 2, Thread 1
+ Device (CP21) { // Neoverse-E1: Cluster 0, Cpu 2, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 21)
Name (_STA, 0xF)
}
- Device (CP22) { // HeliosCore: Cluster 0, Cpu 3, Thread 0
+ Device (CP22) { // Neoverse-E1: Cluster 0, Cpu 3, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 22)
Name (_STA, 0xF)
}
- Device (CP23) { // HeliosCore: Cluster 0, Cpu 3, Thread 1
+ Device (CP23) { // Neoverse-E1: Cluster 0, Cpu 3, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 23)
Name (_STA, 0xF)
}
- Device (CP24) { // HeliosCore: Cluster 0, Cpu 4, Thread 0
+ Device (CP24) { // Neoverse-E1: Cluster 0, Cpu 4, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 24)
Name (_STA, 0xF)
}
- Device (CP25) { // HeliosCore: Cluster 0, Cpu 4, Thread 1
+ Device (CP25) { // Neoverse-E1: Cluster 0, Cpu 4, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 25)
Name (_STA, 0xF)
}
- Device (CP26) { // HeliosCore: Cluster 0, Cpu 5, Thread 0
+ Device (CP26) { // Neoverse-E1: Cluster 0, Cpu 5, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 26)
Name (_STA, 0xF)
}
- Device (CP27) { // HeliosCore: Cluster 0, Cpu 5, Thread 1
+ Device (CP27) { // Neoverse-E1: Cluster 0, Cpu 5, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 27)
Name (_STA, 0xF)
}
- Device (CP28) { // HeliosCore: Cluster 0, Cpu 6, Thread 0
+ Device (CP28) { // Neoverse-E1: Cluster 0, Cpu 6, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 28)
Name (_STA, 0xF)
}
- Device (CP29) { // HeliosCore: Cluster 0, Cpu 6, Thread 1
+ Device (CP29) { // Neoverse-E1: Cluster 0, Cpu 6, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 29)
Name (_STA, 0xF)
}
- Device (CP30) { // HeliosCore: Cluster 0, Cpu 7, Thread 0
+ Device (CP30) { // Neoverse-E1: Cluster 0, Cpu 7, Thread 0
Name (_HID, "ACPI0007")
Name (_UID, 30)
Name (_STA, 0xF)
}
- Device (CP31) { // HeliosCore: Cluster 0, Cpu 7, Thread 1
+ Device (CP31) { // Neoverse-E1: Cluster 0, Cpu 7, Thread 1
Name (_HID, "ACPI0007")
Name (_UID, 31)
Name (_STA, 0xF)
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc b/Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc
similarity index 100%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkHelios/Madt.aslc
rename to Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc
diff --git a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
similarity index 91%
rename from Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
rename to Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
index 8b45702..da6d634 100644
--- a/Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
+++ b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
@@ -15,7 +15,7 @@
[Defines]
INF_VERSION = 0x0001001A
- BASE_NAME = SgiClarkHeliosAcpiTables
+ BASE_NAME = RdE1EdgeAcpiTables
FILE_GUID = 2af40815-a84e-4de9-8c38-9140b3544073
MODULE_TYPE = USER_DEFINED
VERSION_STRING = 1.0
@@ -26,8 +26,8 @@
Gtdt.aslc
Iort.aslc
Mcfg.aslc
- SgiClarkHelios/Dsdt.asl
- SgiClarkHelios/Madt.aslc
+ RdE1Edge/Dsdt.asl
+ RdE1Edge/Madt.aslc
Spcr.aslc
Ssdt.asl
diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
index e00febd..cc9b0a6 100644
--- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
+++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c
@@ -52,8 +52,8 @@ ArmSgiPkgEntryPoint (
(ConfigId == RD_N1_EDGE_CONF_ID)) {
Status = LocateAndInstallAcpiFromFv (&gRdN1EdgeAcpiTablesFileGuid);
} else if ((PartNum == RD_N1E1_EDGE_PART_NUM) &&
- (ConfigId == SGI_CLARK_CONF_HELIOS)) {
- Status = LocateAndInstallAcpiFromFv (&gSgiClarkHeliosAcpiTablesFileGuid);
+ (ConfigId == RD_E1_EDGE_CONF_ID)) {
+ Status = LocateAndInstallAcpiFromFv (&gRdE1EdgeAcpiTablesFileGuid);
} else {
Status = EFI_UNSUPPORTED;
}
diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
index 7b8b3b6..7752256 100644
--- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
+++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf
@@ -38,7 +38,7 @@
gArmSgiPlatformIdDescriptorGuid
gSgi575AcpiTablesFileGuid
gRdN1EdgeAcpiTablesFileGuid
- gSgiClarkHeliosAcpiTablesFileGuid
+ gRdE1EdgeAcpiTablesFileGuid
[FeaturePcd]
gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported
diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
index 99bad78..e89a508 100644
--- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h
+++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h
@@ -79,7 +79,7 @@
//RDN1E1EDGE Platform Identification values
#define RD_N1E1_EDGE_PART_NUM 0x786
#define RD_N1_EDGE_CONF_ID 0x1
-#define SGI_CLARK_CONF_HELIOS 0x2
+#define RD_E1_EDGE_CONF_ID 0x2
#define SGI_CONFIG_MASK 0x0F
#define SGI_CONFIG_SHIFT 0x1C
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiPlatform.dec
index 512ee4c..612c494 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dec
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dec
@@ -34,7 +34,7 @@
gArmSgiTokenSpaceGuid = { 0x577d6941, 0xaea1, 0x40b4, { 0x90, 0x93, 0x2a, 0x86, 0x61, 0x72, 0x5a, 0x57 } }
gSgi575AcpiTablesFileGuid = { 0xc712719a, 0x0aaf, 0x438c, { 0x9c, 0xdd, 0x35, 0xab, 0x4d, 0x60, 0x20, 0x7d } }
gRdN1EdgeAcpiTablesFileGuid = { 0x4b0b91d0, 0x4a05, 0x45c4, { 0x88, 0xa7, 0x88, 0xe1, 0x70, 0xe7, 0x66, 0x94 } }
- gSgiClarkHeliosAcpiTablesFileGuid = { 0x2af40815, 0xa84e, 0x4de9, { 0x8c, 0x38, 0x91, 0x40, 0xb3, 0x54, 0x40, 0x73 } }
+ gRdE1EdgeAcpiTablesFileGuid = { 0x2af40815, 0xa84e, 0x4de9, { 0x8c, 0x38, 0x91, 0x40, 0xb3, 0x54, 0x40, 0x73 } }
[PcdsFeatureFlag.common]
gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported|FALSE|BOOLEAN|0x00000001
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc b/Platform/ARM/SgiPkg/SgiPlatform.dsc
index f2d6672..ae55139 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc
@@ -282,7 +282,7 @@
MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
- Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
+ Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
#
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.fdf b/Platform/ARM/SgiPkg/SgiPlatform.fdf
index 5e8ccec..3d450a8 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.fdf
+++ b/Platform/ARM/SgiPkg/SgiPlatform.fdf
@@ -107,7 +107,7 @@ READ_LOCK_STATUS = TRUE
INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
- INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/SgiClarkHeliosAcpiTables.inf
+ INF RuleOverride=ACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
# Required by PCI
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-05 6:41 [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 2/2] Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge Jagadeesh Ujja
@ 2019-03-13 8:48 ` Jagadeesh Ujja
2019-03-15 8:21 ` Jagadeesh Ujja
2 siblings, 1 reply; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-13 8:48 UTC (permalink / raw)
To: edk2-devel, Leif Lindholm, Ard Biesheuvel
hi Ard/Leif
Please let me know if you have any comments on this patch
thanks
Jagadeesh
On Tue, Mar 5, 2019 at 12:20 PM Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> This patchset updates the product names for SGI-Clark.Ares and
> SGI-Clark.Helios platforms.
> The first patch replaces all uses of sgiclarka with rdn1edge.
> The second patch replaces all use of sgiclarkh with rde1edge.
>
> Jagadeesh Ujja (2):
> Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge
> Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge
>
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl | 66 ++++++++++----------
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc | 0
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} | 6 +-
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl | 16 ++---
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc | 16 ++---
> Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} | 6 +-
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 12 ++--
> Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 4 +-
> Platform/ARM/SgiPkg/Include/SgiPlatform.h | 8 +--
> Platform/ARM/SgiPkg/SgiPlatform.dec | 4 +-
> Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +-
> Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +-
> 12 files changed, 73 insertions(+), 73 deletions(-)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl (68%)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc (100%)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} (91%)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl (85%)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc (93%)
> rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} (92%)
>
> --
> 2.7.4
>
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-13 8:48 ` [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
@ 2019-03-15 8:21 ` Jagadeesh Ujja
2019-03-15 10:44 ` Ard Biesheuvel
0 siblings, 1 reply; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-15 8:21 UTC (permalink / raw)
To: edk2-devel, Leif Lindholm, Ard Biesheuvel
hi Ard/Leif
Please let me know if you have any comments on this patch set
thanks
Jagadeesh
On Tue, Mar
On Wed, Mar 13, 2019 at 2:18 PM Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> hi Ard/Leif
>
> Please let me know if you have any comments on this patch
>
> thanks
> Jagadeesh
> On Tue, Mar 5, 2019 at 12:20 PM Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > This patchset updates the product names for SGI-Clark.Ares and
> > SGI-Clark.Helios platforms.
> > The first patch replaces all uses of sgiclarka with rdn1edge.
> > The second patch replaces all use of sgiclarkh with rde1edge.
> >
> > Jagadeesh Ujja (2):
> > Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge
> > Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge
> >
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl | 66 ++++++++++----------
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc | 0
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} | 6 +-
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl | 16 ++---
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc | 16 ++---
> > Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} | 6 +-
> > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 12 ++--
> > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 4 +-
> > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 8 +--
> > Platform/ARM/SgiPkg/SgiPlatform.dec | 4 +-
> > Platform/ARM/SgiPkg/SgiPlatform.dsc | 4 +-
> > Platform/ARM/SgiPkg/SgiPlatform.fdf | 4 +-
> > 12 files changed, 73 insertions(+), 73 deletions(-)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Dsdt.asl (68%)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHelios => RdE1Edge}/Madt.aslc (100%)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkHeliosAcpiTables.inf => RdE1EdgeAcpiTables.inf} (91%)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Dsdt.asl (85%)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAres => RdN1Edge}/Madt.aslc (93%)
> > rename Platform/ARM/SgiPkg/AcpiTables/{SgiClarkAresAcpiTables.inf => RdN1EdgeAcpiTables.inf} (92%)
> >
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 8:21 ` Jagadeesh Ujja
@ 2019-03-15 10:44 ` Ard Biesheuvel
2019-03-15 11:16 ` Jagadeesh Ujja
0 siblings, 1 reply; 15+ messages in thread
From: Ard Biesheuvel @ 2019-03-15 10:44 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org, Leif Lindholm
On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> hi Ard/Leif
>
> Please let me know if you have any comments on this patch set
>
HI Jagadeesh,
What does RdE1Edge or RdN1Edge mean?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 10:44 ` Ard Biesheuvel
@ 2019-03-15 11:16 ` Jagadeesh Ujja
2019-03-15 11:18 ` Ard Biesheuvel
0 siblings, 1 reply; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-15 11:16 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
hi Ard,
On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > hi Ard/Leif
> >
> > Please let me know if you have any comments on this patch set
> >
>
> HI Jagadeesh,
>
> What does RdE1Edge or RdN1Edge mean?
RdE1Edge/RdN1Edge are new product name
Rd stands for reference design.
The Neoverse E1 Edge Reference Design
The Neoverse N1 Edge Reference Design
More details can be found in the below links
https://pcfiend.com/2019/02/20/arm-announces-neoverse-n1-e1-platforms-cpus-enabling-a-huge-jump-in-infrastructure-performance/
https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/arm-neoverse-n1-platform-accelerating-the-transformation-to-a-scalable-cloud-to-edge-infrastructure
https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/posts/arm-neoverse-e1-platform-empowering-the-infrastructure-to-meet-next-generation-throughput-demands
thanks
Jagadeesh
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 11:16 ` Jagadeesh Ujja
@ 2019-03-15 11:18 ` Ard Biesheuvel
2019-03-15 11:40 ` Jagadeesh Ujja
0 siblings, 1 reply; 15+ messages in thread
From: Ard Biesheuvel @ 2019-03-15 11:18 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org
On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> hi Ard,
>
> On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > >
> > > hi Ard/Leif
> > >
> > > Please let me know if you have any comments on this patch set
> > >
> >
> > HI Jagadeesh,
> >
> > What does RdE1Edge or RdN1Edge mean?
>
> RdE1Edge/RdN1Edge are new product name
> Rd stands for reference design.
>
> The Neoverse E1 Edge Reference Design
> The Neoverse N1 Edge Reference Design
>
So 'reference design' is the name of the platform based on the
Neoverse E1 and N1, respectively?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 11:18 ` Ard Biesheuvel
@ 2019-03-15 11:40 ` Jagadeesh Ujja
2019-03-15 11:57 ` Ard Biesheuvel
0 siblings, 1 reply; 15+ messages in thread
From: Jagadeesh Ujja @ 2019-03-15 11:40 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > hi Ard,
> >
> > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > >
> > > > hi Ard/Leif
> > > >
> > > > Please let me know if you have any comments on this patch set
> > > >
> > >
> > > HI Jagadeesh,
> > >
> > > What does RdE1Edge or RdN1Edge mean?
> >
> > RdE1Edge/RdN1Edge are new product name
> > Rd stands for reference design.
> >
> > The Neoverse E1 Edge Reference Design
> > The Neoverse N1 Edge Reference Design
> >
>
> So 'reference design' is the name of the platform based on the
> Neoverse E1 and N1, respectively?
yes ,
'reference design' is a class of platform, in which we have Neoverse
E1/N1 cores support. Going forward other cores can come in
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 11:40 ` Jagadeesh Ujja
@ 2019-03-15 11:57 ` Ard Biesheuvel
2019-03-15 12:25 ` Thomas Abraham
0 siblings, 1 reply; 15+ messages in thread
From: Ard Biesheuvel @ 2019-03-15 11:57 UTC (permalink / raw)
To: Jagadeesh Ujja; +Cc: edk2-devel@lists.01.org
On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
>
> On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > >
> > > hi Ard,
> > >
> > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > >
> > > > > hi Ard/Leif
> > > > >
> > > > > Please let me know if you have any comments on this patch set
> > > > >
> > > >
> > > > HI Jagadeesh,
> > > >
> > > > What does RdE1Edge or RdN1Edge mean?
> > >
> > > RdE1Edge/RdN1Edge are new product name
> > > Rd stands for reference design.
> > >
> > > The Neoverse E1 Edge Reference Design
> > > The Neoverse N1 Edge Reference Design
> > >
> >
> > So 'reference design' is the name of the platform based on the
> > Neoverse E1 and N1, respectively?
>
> yes ,
> 'reference design' is a class of platform, in which we have Neoverse
> E1/N1 cores support. Going forward other cores can come in
>
Could we drop the 'edge'? It seems redundant.
I'd prefer it if we could stick with
NeoverseE1
NeoverseN1
or if the reference design part is relevant
NeoverseE1ReferenceDesign
NeoverseN1ReferenceDesign
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 11:57 ` Ard Biesheuvel
@ 2019-03-15 12:25 ` Thomas Abraham
2019-03-15 12:29 ` Ard Biesheuvel
0 siblings, 1 reply; 15+ messages in thread
From: Thomas Abraham @ 2019-03-15 12:25 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: Jagadeesh Ujja, edk2-devel@lists.01.org
On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> >
> > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > >
> > > > hi Ard,
> > > >
> > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > >
> > > > > > hi Ard/Leif
> > > > > >
> > > > > > Please let me know if you have any comments on this patch set
> > > > > >
> > > > >
> > > > > HI Jagadeesh,
> > > > >
> > > > > What does RdE1Edge or RdN1Edge mean?
> > > >
> > > > RdE1Edge/RdN1Edge are new product name
> > > > Rd stands for reference design.
> > > >
> > > > The Neoverse E1 Edge Reference Design
> > > > The Neoverse N1 Edge Reference Design
> > > >
> > >
> > > So 'reference design' is the name of the platform based on the
> > > Neoverse E1 and N1, respectively?
> >
> > yes ,
> > 'reference design' is a class of platform, in which we have Neoverse
> > E1/N1 cores support. Going forward other cores can come in
> >
>
> Could we drop the 'edge'? It seems redundant.
Hi Ard,
'edge' here would be required because there is also a 'hyperscale'
class of platform based on N1 cores.
(https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
>
> I'd prefer it if we could stick with
>
> NeoverseE1
> NeoverseN1
>
> or if the reference design part is relevant
>
> NeoverseE1ReferenceDesign
> NeoverseN1ReferenceDesign
The ReferenceDesign part is relevant and without which the name would
only indicate the CPU name (NeoverseN1). And so is 'edge' because
there is 'hyperscale' variant as of today and there could be other
variants as well.
Thanks,
Thomas.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 12:25 ` Thomas Abraham
@ 2019-03-15 12:29 ` Ard Biesheuvel
2019-03-15 12:44 ` Thomas Abraham
0 siblings, 1 reply; 15+ messages in thread
From: Ard Biesheuvel @ 2019-03-15 12:29 UTC (permalink / raw)
To: Thomas Abraham; +Cc: Jagadeesh Ujja, edk2-devel@lists.01.org
On Fri, 15 Mar 2019 at 13:25, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > >
> > > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > > <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > >
> > > > > hi Ard,
> > > > >
> > > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > >
> > > > > > > hi Ard/Leif
> > > > > > >
> > > > > > > Please let me know if you have any comments on this patch set
> > > > > > >
> > > > > >
> > > > > > HI Jagadeesh,
> > > > > >
> > > > > > What does RdE1Edge or RdN1Edge mean?
> > > > >
> > > > > RdE1Edge/RdN1Edge are new product name
> > > > > Rd stands for reference design.
> > > > >
> > > > > The Neoverse E1 Edge Reference Design
> > > > > The Neoverse N1 Edge Reference Design
> > > > >
> > > >
> > > > So 'reference design' is the name of the platform based on the
> > > > Neoverse E1 and N1, respectively?
> > >
> > > yes ,
> > > 'reference design' is a class of platform, in which we have Neoverse
> > > E1/N1 cores support. Going forward other cores can come in
> > >
> >
> > Could we drop the 'edge'? It seems redundant.
>
> Hi Ard,
>
> 'edge' here would be required because there is also a 'hyperscale'
> class of platform based on N1 cores.
> (https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
>
> >
> > I'd prefer it if we could stick with
> >
> > NeoverseE1
> > NeoverseN1
> >
> > or if the reference design part is relevant
> >
> > NeoverseE1ReferenceDesign
> > NeoverseN1ReferenceDesign
>
> The ReferenceDesign part is relevant and without which the name would
> only indicate the CPU name (NeoverseN1). And so is 'edge' because
> there is 'hyperscale' variant as of today and there could be other
> variants as well.
>
Hi Thomas,
Thanks for the clarification.
So could we go with
> > NeoverseE1EdgeReferenceDesign
> > NeoverseN1EdgeReferenceDesign
instead?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 12:29 ` Ard Biesheuvel
@ 2019-03-15 12:44 ` Thomas Abraham
2019-03-15 12:50 ` Ard Biesheuvel
0 siblings, 1 reply; 15+ messages in thread
From: Thomas Abraham @ 2019-03-15 12:44 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Mar 15, 2019 at 6:04 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 15 Mar 2019 at 13:25, Thomas Abraham <thomas.abraham@arm.com> wrote:
> >
> > On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > >
> > > > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > > > <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > >
> > > > > > hi Ard,
> > > > > >
> > > > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > > >
> > > > > > > > hi Ard/Leif
> > > > > > > >
> > > > > > > > Please let me know if you have any comments on this patch set
> > > > > > > >
> > > > > > >
> > > > > > > HI Jagadeesh,
> > > > > > >
> > > > > > > What does RdE1Edge or RdN1Edge mean?
> > > > > >
> > > > > > RdE1Edge/RdN1Edge are new product name
> > > > > > Rd stands for reference design.
> > > > > >
> > > > > > The Neoverse E1 Edge Reference Design
> > > > > > The Neoverse N1 Edge Reference Design
> > > > > >
> > > > >
> > > > > So 'reference design' is the name of the platform based on the
> > > > > Neoverse E1 and N1, respectively?
> > > >
> > > > yes ,
> > > > 'reference design' is a class of platform, in which we have Neoverse
> > > > E1/N1 cores support. Going forward other cores can come in
> > > >
> > >
> > > Could we drop the 'edge'? It seems redundant.
> >
> > Hi Ard,
> >
> > 'edge' here would be required because there is also a 'hyperscale'
> > class of platform based on N1 cores.
> > (https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
> >
> > >
> > > I'd prefer it if we could stick with
> > >
> > > NeoverseE1
> > > NeoverseN1
> > >
> > > or if the reference design part is relevant
> > >
> > > NeoverseE1ReferenceDesign
> > > NeoverseN1ReferenceDesign
> >
> > The ReferenceDesign part is relevant and without which the name would
> > only indicate the CPU name (NeoverseN1). And so is 'edge' because
> > there is 'hyperscale' variant as of today and there could be other
> > variants as well.
> >
>
> Hi Thomas,
>
> Thanks for the clarification.
>
> So could we go with
>
> > > NeoverseE1EdgeReferenceDesign
> > > NeoverseN1EdgeReferenceDesign
>
> instead?
The official product names being used for these two platforms are
'RD-N1-Edge' and 'RD-E1-Edge'. So to keep to platform name in line
with the product name and also to keep it short, 'RdN1Edge' and
'RdE1Edge' names are being used in this patch series. Are there any
limitations in using this shorter name for the platforms.
Thanks,
Thomas.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 12:44 ` Thomas Abraham
@ 2019-03-15 12:50 ` Ard Biesheuvel
2019-03-15 13:06 ` Thomas Abraham
0 siblings, 1 reply; 15+ messages in thread
From: Ard Biesheuvel @ 2019-03-15 12:50 UTC (permalink / raw)
To: Thomas Abraham; +Cc: edk2-devel@lists.01.org
On Fri, 15 Mar 2019 at 13:44, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
> On Fri, Mar 15, 2019 at 6:04 PM Ard Biesheuvel
> <ard.biesheuvel@linaro.org> wrote:
> >
> > On Fri, 15 Mar 2019 at 13:25, Thomas Abraham <thomas.abraham@arm.com> wrote:
> > >
> > > On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
> > > <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > >
> > > > > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > >
> > > > > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > >
> > > > > > > hi Ard,
> > > > > > >
> > > > > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > > > >
> > > > > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > > > >
> > > > > > > > > hi Ard/Leif
> > > > > > > > >
> > > > > > > > > Please let me know if you have any comments on this patch set
> > > > > > > > >
> > > > > > > >
> > > > > > > > HI Jagadeesh,
> > > > > > > >
> > > > > > > > What does RdE1Edge or RdN1Edge mean?
> > > > > > >
> > > > > > > RdE1Edge/RdN1Edge are new product name
> > > > > > > Rd stands for reference design.
> > > > > > >
> > > > > > > The Neoverse E1 Edge Reference Design
> > > > > > > The Neoverse N1 Edge Reference Design
> > > > > > >
> > > > > >
> > > > > > So 'reference design' is the name of the platform based on the
> > > > > > Neoverse E1 and N1, respectively?
> > > > >
> > > > > yes ,
> > > > > 'reference design' is a class of platform, in which we have Neoverse
> > > > > E1/N1 cores support. Going forward other cores can come in
> > > > >
> > > >
> > > > Could we drop the 'edge'? It seems redundant.
> > >
> > > Hi Ard,
> > >
> > > 'edge' here would be required because there is also a 'hyperscale'
> > > class of platform based on N1 cores.
> > > (https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
> > >
> > > >
> > > > I'd prefer it if we could stick with
> > > >
> > > > NeoverseE1
> > > > NeoverseN1
> > > >
> > > > or if the reference design part is relevant
> > > >
> > > > NeoverseE1ReferenceDesign
> > > > NeoverseN1ReferenceDesign
> > >
> > > The ReferenceDesign part is relevant and without which the name would
> > > only indicate the CPU name (NeoverseN1). And so is 'edge' because
> > > there is 'hyperscale' variant as of today and there could be other
> > > variants as well.
> > >
> >
> > Hi Thomas,
> >
> > Thanks for the clarification.
> >
> > So could we go with
> >
> > > > NeoverseE1EdgeReferenceDesign
> > > > NeoverseN1EdgeReferenceDesign
> >
> > instead?
>
> The official product names being used for these two platforms are
> 'RD-N1-Edge' and 'RD-E1-Edge'. So to keep to platform name in line
> with the product name and also to keep it short, 'RdN1Edge' and
> 'RdE1Edge' names are being used in this patch series. Are there any
> limitations in using this shorter name for the platforms.
>
No, I just found them a bit cryptic. But if they are an exact match
with the product names, I don't have any objections.
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 68cc99303e38..a8f34e065815
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms
2019-03-15 12:50 ` Ard Biesheuvel
@ 2019-03-15 13:06 ` Thomas Abraham
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Abraham @ 2019-03-15 13:06 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Fri, Mar 15, 2019 at 6:32 PM Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
>
> On Fri, 15 Mar 2019 at 13:44, Thomas Abraham <thomas.abraham@arm.com> wrote:
> >
> > On Fri, Mar 15, 2019 at 6:04 PM Ard Biesheuvel
> > <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 15 Mar 2019 at 13:25, Thomas Abraham <thomas.abraham@arm.com> wrote:
> > > >
> > > > On Fri, Mar 15, 2019 at 5:27 PM Ard Biesheuvel
> > > > <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Fri, 15 Mar 2019 at 12:40, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > >
> > > > > > On Fri, Mar 15, 2019 at 4:55 PM Ard Biesheuvel
> > > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > > >
> > > > > > > On Fri, 15 Mar 2019 at 12:17, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > > >
> > > > > > > > hi Ard,
> > > > > > > >
> > > > > > > > On Fri, Mar 15, 2019 at 4:14 PM Ard Biesheuvel
> > > > > > > > <ard.biesheuvel@linaro.org> wrote:
> > > > > > > > >
> > > > > > > > > On Fri, 15 Mar 2019 at 09:21, Jagadeesh Ujja <jagadeesh.ujja@arm.com> wrote:
> > > > > > > > > >
> > > > > > > > > > hi Ard/Leif
> > > > > > > > > >
> > > > > > > > > > Please let me know if you have any comments on this patch set
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > HI Jagadeesh,
> > > > > > > > >
> > > > > > > > > What does RdE1Edge or RdN1Edge mean?
> > > > > > > >
> > > > > > > > RdE1Edge/RdN1Edge are new product name
> > > > > > > > Rd stands for reference design.
> > > > > > > >
> > > > > > > > The Neoverse E1 Edge Reference Design
> > > > > > > > The Neoverse N1 Edge Reference Design
> > > > > > > >
> > > > > > >
> > > > > > > So 'reference design' is the name of the platform based on the
> > > > > > > Neoverse E1 and N1, respectively?
> > > > > >
> > > > > > yes ,
> > > > > > 'reference design' is a class of platform, in which we have Neoverse
> > > > > > E1/N1 cores support. Going forward other cores can come in
> > > > > >
> > > > >
> > > > > Could we drop the 'edge'? It seems redundant.
> > > >
> > > > Hi Ard,
> > > >
> > > > 'edge' here would be required because there is also a 'hyperscale'
> > > > class of platform based on N1 cores.
> > > > (https://www.anandtech.com/show/13959/arm-announces-neoverse-n1-platform/3).
> > > >
> > > > >
> > > > > I'd prefer it if we could stick with
> > > > >
> > > > > NeoverseE1
> > > > > NeoverseN1
> > > > >
> > > > > or if the reference design part is relevant
> > > > >
> > > > > NeoverseE1ReferenceDesign
> > > > > NeoverseN1ReferenceDesign
> > > >
> > > > The ReferenceDesign part is relevant and without which the name would
> > > > only indicate the CPU name (NeoverseN1). And so is 'edge' because
> > > > there is 'hyperscale' variant as of today and there could be other
> > > > variants as well.
> > > >
> > >
> > > Hi Thomas,
> > >
> > > Thanks for the clarification.
> > >
> > > So could we go with
> > >
> > > > > NeoverseE1EdgeReferenceDesign
> > > > > NeoverseN1EdgeReferenceDesign
> > >
> > > instead?
> >
> > The official product names being used for these two platforms are
> > 'RD-N1-Edge' and 'RD-E1-Edge'. So to keep to platform name in line
> > with the product name and also to keep it short, 'RdN1Edge' and
> > 'RdE1Edge' names are being used in this patch series. Are there any
> > limitations in using this shorter name for the platforms.
> >
>
> No, I just found them a bit cryptic. But if they are an exact match
> with the product names, I don't have any objections.
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Pushed as 68cc99303e38..a8f34e065815
Thank you Ard.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-03-15 13:06 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-05 6:41 [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 1/2] Platforms/ARM/SgiPkg: Rename SgiClarkAres to RdN1Edge Jagadeesh Ujja
2019-03-05 6:41 ` [PATCH edk2-platforms 2/2] Platforms/ARM/SgiPkg: Rename SgiClarkHelios to RdE1Edge Jagadeesh Ujja
2019-03-13 8:48 ` [PATCH edk2-platforms 0/2] Platforms/ARM/SgiPkg: apply product names for sgiclarka and sgiclarkh platforms Jagadeesh Ujja
2019-03-15 8:21 ` Jagadeesh Ujja
2019-03-15 10:44 ` Ard Biesheuvel
2019-03-15 11:16 ` Jagadeesh Ujja
2019-03-15 11:18 ` Ard Biesheuvel
2019-03-15 11:40 ` Jagadeesh Ujja
2019-03-15 11:57 ` Ard Biesheuvel
2019-03-15 12:25 ` Thomas Abraham
2019-03-15 12:29 ` Ard Biesheuvel
2019-03-15 12:44 ` Thomas Abraham
2019-03-15 12:50 ` Ard Biesheuvel
2019-03-15 13:06 ` Thomas Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox