From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=162.221.156.55; helo=smtp03.citrix.com; envelope-from=prvs=961469de7=igor.druzhinin@citrix.com; receiver=edk2-devel@lists.01.org Received: from SMTP03.CITRIX.COM (smtp03.citrix.com [162.221.156.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26B9D211D59A0 for ; Wed, 6 Mar 2019 04:41:04 -0800 (PST) X-IronPort-AV: E=Sophos;i="5.58,447,1544486400"; d="scan'208";a="79810433" From: Igor Druzhinin To: CC: , , , , , , Igor Druzhinin Date: Wed, 6 Mar 2019 12:40:54 +0000 Message-ID: <1551876056-28223-2-git-send-email-igor.druzhinin@citrix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1551876056-28223-1-git-send-email-igor.druzhinin@citrix.com> References: <1551876056-28223-1-git-send-email-igor.druzhinin@citrix.com> MIME-Version: 1.0 Subject: [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 X-List-Received-Date: Wed, 06 Mar 2019 12:41:07 -0000 Content-Type: text/plain This aperture doesn't exist in OVMF and trying to use it causes failing assertions later in cases there are prefetchable and non-prefetchable BARs following each other. This configuration is quite likely with some PCI passthrough devices. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Igor Druzhinin --- OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c index 9204179..c23c46d 100644 --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c @@ -129,11 +129,7 @@ PcatPciRootBridgeParseBars ( // Length = ((~Length) + 1) & 0xffffffff; - if ((Value & BIT3) == BIT3) { - MemAperture = PMem; - } else { - MemAperture = Mem; - } + MemAperture = Mem; } else { // // 64bit @@ -149,11 +145,7 @@ PcatPciRootBridgeParseBars ( Length = Length | LShiftU64 ((UINT64) UpperValue, 32); Length = (~Length) + 1; - if ((Value & BIT3) == BIT3) { - MemAperture = PMemAbove4G; - } else { - MemAperture = MemAbove4G; - } + MemAperture = MemAbove4G; } Limit = Base + Length - 1; -- 2.7.4