From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26902211DDA1E for ; Thu, 14 Mar 2019 11:03:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 11:03:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="155085120" Received: from mboopath-mobl.amr.corp.intel.com (HELO localhost) ([10.252.139.55]) by fmsmga001.fm.intel.com with ESMTP; 14 Mar 2019 11:03:55 -0700 MIME-Version: 1.0 In-Reply-To: References: From: Jordan Justen To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Message-ID: <155258662331.20276.3714209093894340086@jljusten-skl> User-Agent: alot/0.8 Date: Thu, 14 Mar 2019 11:03:48 -0700 Subject: Re: PATCH] Change EDK II to BSD+Patent License X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Mar 2019 18:03:58 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-03-13 10:54:22, Kinney, Michael D wrote: > =20 > 84141eacac edk2: Remove Contributions.txt and update Readme.md I guess this removes the requirement for the 'Contributed-under' tag in commit messages? But, what about Signed-off-by? Is it desirable to remove that requirement? Relatedly, some open source projects have standardized on tying the Signed-off-by to this text: https://developercertificate.org/ So, the contributor doesn't have to agree to give the project the contribution under the Contributed-under terms, but they still indicate that they believe that the project can use the code under the project's indicated license. There is also other information in Contributions.txt that appears to have been deleted, rather than moved. I guess it is mostly duplicated on the wiki. That doesn't mean it's not a good idea to duplicate it in the source tree, or at least provide a web-link. It seems like the first place devs might look for such information is either the readme, or Contributions.txt. Regarding the wiki, I guess it has to be updated after this change is made. It might be good to add that to the bug so it can't be closed until that is fixed. How about updating BaseTools/Scripts/PatchCheck.py? -Jordan