From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2D7F211D56C1 for ; Thu, 14 Mar 2019 23:15:42 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 23:15:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="328852347" Received: from mboopath-mobl.amr.corp.intel.com (HELO localhost) ([10.252.139.55]) by fmsmga005.fm.intel.com with ESMTP; 14 Mar 2019 23:15:41 -0700 MIME-Version: 1.0 In-Reply-To: <20190315051749.6564-2-zhichao.gao@intel.com> References: <20190315051749.6564-1-zhichao.gao@intel.com> <20190315051749.6564-2-zhichao.gao@intel.com> Cc: Michael D Kinney , Bret Barkelew , Michael Turner , Liming Gao From: Jordan Justen To: Zhichao Gao , edk2-devel@lists.01.org Message-ID: <155263054046.23460.7190580861275117521@jljusten-skl> User-Agent: alot/0.8 Date: Thu, 14 Mar 2019 23:15:40 -0700 Subject: Re: [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 06:15:42 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-03-14 22:17:33, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 >=20 > Add a new api DebugVPrint prototype definition in the > DebugLib header file. This api would expose a print > routine with VaList parameter. These lines seem to be fairly short, with the longest be 54 chars. I guess not a problem, but by the recommendation says they could be up to 75 in length. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format >=20 > diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/D= ebugLib.h > index e6a7a357b2..51d89bbd52 100644 > --- a/MdePkg/Include/Library/DebugLib.h > +++ b/MdePkg/Include/Library/DebugLib.h > @@ -8,7 +8,7 @@ > of size reduction when compiler optimization is disabled. If MDEPKG_ND= EBUG is > defined, then debug and assert related macros wrapped by it are the NU= LL implementations. > =20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made availa= ble under > the terms and conditions of the BSD License that accompanies this distri= bution. > The full text of the license may be found at > @@ -101,6 +101,29 @@ DebugPrint ( > ); > =20 > +/** > + Prints a debug message to the debug output device if the specified err= or level is enabled. According to the style guide: "Preferably, limit line lengths to 80 columns or less." https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C https://github.com/tianocore-docs/Docs/raw/master/Specifications/CCS_2_1_Dr= aft.pdf But, this line uses 92 columns. I think there are similar cases in other patches. > + > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib functi= on > + GetDebugPrintErrorLevel (), then print the message specified by Format= and the > + associated variable argument list to the debug output device. > + > + If Format is NULL, then ASSERT(). > + > + @param ErrorLevel The error level of the debug message. > + @param Format Format string for the debug message to print. > + @param VaListMarker VA_LIST marker for the variable argument list. > + > +**/ > +VOID > +EFIAPI > +DebugVPrint ( > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN VA_LIST VaListMarker > + ); > + > + > /** > Prints an assert message containing a filename, line number, and descr= iption. > This may be followed by a breakpoint or a dead loop. > @@ -221,6 +244,7 @@ DebugClearMemoryEnabled ( > VOID > ); > =20 > + What's going on here? It seems like maybe extra lines are added that have nothing to do with this patch. -Jordan > /** > Returns TRUE if any one of the bit is set both in ErrorLevel and PcdFi= xedDebugPrintErrorLevel. > =20 > @@ -236,6 +260,7 @@ DebugPrintLevelEnabled ( > IN CONST UINTN ErrorLevel > ); > =20 > + > /** > Internal worker macro that calls DebugAssert(). > =20 > @@ -273,6 +298,7 @@ DebugPrintLevelEnabled ( > #define _DEBUG(Expression) DebugPrint Expression > #endif > =20 > + > /** > Macro that calls DebugAssert() if an expression evaluates to FALSE. > =20 > @@ -299,6 +325,7 @@ DebugPrintLevelEnabled ( > #define ASSERT(Expression) > #endif > =20 > + > /** > Macro that calls DebugPrint(). > =20 > @@ -322,6 +349,7 @@ DebugPrintLevelEnabled ( > #define DEBUG(Expression) > #endif > =20 > + > /** > Macro that calls DebugAssert() if an EFI_STATUS evaluates to an error = code. > =20 > @@ -348,6 +376,7 @@ DebugPrintLevelEnabled ( > #define ASSERT_EFI_ERROR(StatusParameter) > #endif > =20 > + > /** > Macro that calls DebugAssert() if a RETURN_STATUS evaluates to an erro= r code. > =20 > @@ -375,6 +404,7 @@ DebugPrintLevelEnabled ( > #define ASSERT_RETURN_ERROR(StatusParameter) > #endif > =20 > + > /** > Macro that calls DebugAssert() if a protocol is already installed in t= he > handle database. > @@ -418,6 +448,7 @@ DebugPrintLevelEnabled ( > #define ASSERT_PROTOCOL_ALREADY_INSTALLED(Handle, Guid) > #endif > =20 > + > /** > Macro that marks the beginning of debug source code. > =20 > --=20 > 2.16.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel