From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CFD4A211D940D for ; Fri, 15 Mar 2019 11:16:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 11:16:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,483,1544515200"; d="scan'208";a="152731504" Received: from mboopath-mobl.amr.corp.intel.com (HELO localhost) ([10.252.139.55]) by fmsmga004.fm.intel.com with ESMTP; 15 Mar 2019 11:16:42 -0700 MIME-Version: 1.0 In-Reply-To: References: <20190315071603.16936-1-hao.a.wu@intel.com> From: Jordan Justen To: Ard Biesheuvel , Hao Wu Cc: "edk2-devel@lists.01.org" , Laszlo Ersek Message-ID: <155267380200.30417.2941036035350773974@jljusten-skl> User-Agent: alot/0.8 Date: Fri, 15 Mar 2019 11:16:42 -0700 Subject: Re: [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 18:16:44 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-03-15 04:09:56, Ard Biesheuvel wrote: > On Fri, 15 Mar 2019 at 08:16, Hao Wu wrote: > > > > This series will update the OVMF to stop using the ISA drivers within > > IntelFrameworkModulePkg. > > > > As the replacement, a new OVMF Super I/O bus driver has been add which > > will install the Super I/O protocol for ISA serial and PS2 keyboard > > devices. By doing so, these devices can be managed by: > > > > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > > > respectively. > > >=20 > Just a couple of notes from my side - I'm sure Laszlo will have a much > longer list :-) >=20 > - Dropping the floppy driver is fine with me. > - What is OVMF specific about this driver? Is it only the hardcoded > list of COM1/COM2/PS2 keyboard? If so, should we split this into a > driver and a library class, where the driver lives in MdeModulePkg, > and the library is implemented in the context of OVMF? > - Regardless of the previous, adding the new driver should be a patch > of its own. Yeah. I think the first patch should add the new driver, and update the .dsc files to build the new driver. But, don't update the .fdf, so there shouldn't be a functional change to the OVMF output after the first patch. Then the second patch can modify the .dsc and .fdf files to swap out the drivers. -Jordan > - I spotted an incorrect reference to PCI_IO_DEV in a comment (patch #2) >=20 >=20 >=20 > > > > Tests done: > > A. GCC5 & VS2015x86 tool chains build pass > > B. Launch QEMU (2.4.50, Windows) with command: > > > qemu-system-x86_64.exe -pflash \OVMF.fd -serial file:1.= txt -serial file:2.txt > > > > Able to see the ISA COM1/COM2 UART and PS2Keyboard devices under She= ll > > using command 'devtree'; > > > > Both the serials and PS2 keyboard are working fine; > > > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Ray Ni > > > > Hao Wu (2): > > OvmfPkg: Drop the ISA Floppy device support > > OvmfPkg: Add an Super IO bus driver to replace the current ISA support > > > > OvmfPkg/OvmfPkgIa32.dsc | 10 +- > > OvmfPkg/OvmfPkgIa32X64.dsc | 10 +- > > OvmfPkg/OvmfPkgX64.dsc | 10 +- > > OvmfPkg/OvmfPkgIa32.fdf | 10 +- > > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +- > > OvmfPkg/OvmfPkgX64.fdf | 10 +- > > OvmfPkg/SioBusDxe/SioBusDxe.inf | 54 ++ > > OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++++++++++ > > OvmfPkg/SioBusDxe/SioService.h | 221 +++++++ > > OvmfPkg/SioBusDxe/ComponentName.c | 167 ++++++ > > OvmfPkg/SioBusDxe/SioBusDxe.c | 622 ++++++++++++++++++++ > > OvmfPkg/SioBusDxe/SioService.c | 405 +++++++++++++ > > OvmfPkg/SioBusDxe/SioBusDxe.uni | 21 + > > 13 files changed, 1846 insertions(+), 36 deletions(-) > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.inf > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.h > > create mode 100644 OvmfPkg/SioBusDxe/SioService.h > > create mode 100644 OvmfPkg/SioBusDxe/ComponentName.c > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.c > > create mode 100644 OvmfPkg/SioBusDxe/SioService.c > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.uni > > > > -- > > 2.12.0.windows.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel