From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jordan.l.justen@intel.com> Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jordan.l.justen@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 232D721A07093 for <edk2-devel@lists.01.org>; Sun, 17 Mar 2019 23:20:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2019 23:20:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,492,1544515200"; d="scan'208";a="142892322" Received: from pjschube-mobl2.amr.corp.intel.com (HELO localhost) ([10.255.229.236]) by orsmga002.jf.intel.com with ESMTP; 17 Mar 2019 23:20:36 -0700 MIME-Version: 1.0 In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B7B0177@SHSMSX101.ccr.corp.intel.com> References: <20190315051749.6564-1-zhichao.gao@intel.com> <20190315051749.6564-2-zhichao.gao@intel.com> <155263054046.23460.7190580861275117521@jljusten-skl> <3CE959C139B4C44DBEA1810E3AA6F9000B7B0177@SHSMSX101.ccr.corp.intel.com> From: Jordan Justen <jordan.l.justen@intel.com> Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>, Bret Barkelew <Bret.Barkelew@microsoft.com>, Michael Turner <Michael.Turner@microsoft.com>, "Gao, Liming" <liming.gao@intel.com> To: "Gao, Zhichao" <zhichao.gao@intel.com>, "edk2-devel@lists.01.org" <edk2-devel@lists.01.org> Message-ID: <155289003042.7045.9736868893658475606@jljusten-skl> User-Agent: alot/0.8 Date: Sun, 17 Mar 2019 23:20:35 -0700 Subject: Re: [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development <edk2-devel.lists.01.org> List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe> List-Archive: <http://lists.01.org/pipermail/edk2-devel/> List-Post: <mailto:edk2-devel@lists.01.org> List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help> List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>, <mailto:edk2-devel-request@lists.01.org?subject=subscribe> X-List-Received-Date: Mon, 18 Mar 2019 06:20:38 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-03-17 17:14:40, Gao, Zhichao wrote: > > -----Original Message----- > > From: Justen, Jordan L > > Sent: Friday, March 15, 2019 2:16 PM > >=20 > > On 2019-03-14 22:17:33, Zhichao Gao wrote: > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 > > > > > > Add a new api DebugVPrint prototype definition in the > > > DebugLib header file. This api would expose a print > > > routine with VaList parameter. > >=20 > > These lines seem to be fairly short, with the longest be 54 chars. I gu= ess not a > > problem, but by the recommendation says they could be up to 75 in lengt= h. > >=20 > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format > >=20 >=20 > It is hard for someone to control the characters in a line. I guess that depends on your editor. :) > Making the text massage readable base on the rules make more sense. > It is easier to control the chars number within 75. Line length less > than 76 characters is legal. Yes, I mentioned it is legal, but it is noticably short. I don't think it is so short that it is really a problem, so feel free to leave it if you prefer. > >=20 > > According to the style guide: > >=20 > > "Preferably, limit line lengths to 80 columns or less." > >=20 > > https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C > >=20 > > https://github.com/tianocore- > > docs/Docs/raw/master/Specifications/CCS_2_1_Draft.pdf > >=20 > > But, this line uses 92 columns. > >=20 > > I think there are similar cases in other patches. >=20 > Right. This sentence I copied from the comment of DebugPrint > function which might be designed for a long time. The CCS might not > be designed as such style at that time. For this, it's better to > change both of the two sentences. > By the way, the whole edk2 repo may contain a lot of lines violated > this rule. It takes effort to fix them all. I agree there are many violations of this in edk2. Usually, it's not too important to go around fixing the issues that already happened, but if you are changing or adding some code, then you can try to make sure the new lines you add are good. -Jordan