From: jordan.l.justen@intel.com
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh
Date: Wed, 03 Apr 2019 15:24:39 -0700 [thread overview]
Message-ID: <155433027462.27290.10106696912134038958@jljusten-skl> (raw)
In-Reply-To: <20190403215439.15128-1-michael.d.kinney@intel.com>
$ git grep GdbRun
EmulatorPkg/Unix/Host/Host.c: // has a break point script to source the GdbRun script.
EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbxuser: command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbxuser: command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/build.sh: /usr/bin/gdb $BUILD_ROOT_ARCH/Host -q -cd=$BUILD_ROOT_ARCH -x $WORKSPACE/EmulatorPkg/Unix/GdbRun
If those are updated,
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2019-04-03 14:54:39, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1657
>
> Add .sh file extension to the shell script GdbRun so
> changes to this file will pass PatchCheck.py.
>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> EmulatorPkg/Unix/{GdbRun => GdbRun.sh} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename EmulatorPkg/Unix/{GdbRun => GdbRun.sh} (100%)
>
> diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
> similarity index 100%
> rename from EmulatorPkg/Unix/GdbRun
> rename to EmulatorPkg/Unix/GdbRun.sh
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2019-04-03 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 21:54 [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh Michael D Kinney
2019-04-03 22:24 ` jordan.l.justen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155433027462.27290.10106696912134038958@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox