public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh
@ 2019-04-03 21:54 Michael D Kinney
  2019-04-03 22:24 ` jordan.l.justen
  0 siblings, 1 reply; 2+ messages in thread
From: Michael D Kinney @ 2019-04-03 21:54 UTC (permalink / raw)
  To: devel; +Cc: Jordan Justen, Andrew Fish, Ray Ni, Michael D Kinney

https://bugzilla.tianocore.org/show_bug.cgi?id=1657

Add .sh file extension to the shell script GdbRun so
changes to this file will pass PatchCheck.py.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 EmulatorPkg/Unix/{GdbRun => GdbRun.sh} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename EmulatorPkg/Unix/{GdbRun => GdbRun.sh} (100%)

diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
similarity index 100%
rename from EmulatorPkg/Unix/GdbRun
rename to EmulatorPkg/Unix/GdbRun.sh
-- 
2.21.0.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh
  2019-04-03 21:54 [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh Michael D Kinney
@ 2019-04-03 22:24 ` jordan.l.justen
  0 siblings, 0 replies; 2+ messages in thread
From: jordan.l.justen @ 2019-04-03 22:24 UTC (permalink / raw)
  To: Kinney, Michael D, devel; +Cc: Andrew Fish, Ray Ni, Michael D Kinney

$ git grep GdbRun
EmulatorPkg/Unix/Host/Host.c:  // has a break point script to source the GdbRun script.
EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbxuser:         command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbxuser:         command = "set gInXcode=1\nsource ../../../../EmulatorPkg/Unix/GdbRun";
EmulatorPkg/build.sh:  /usr/bin/gdb $BUILD_ROOT_ARCH/Host -q -cd=$BUILD_ROOT_ARCH -x $WORKSPACE/EmulatorPkg/Unix/GdbRun

If those are updated,

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2019-04-03 14:54:39, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1657
> 
> Add .sh file extension to the shell script GdbRun so
> changes to this file will pass PatchCheck.py.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/Unix/{GdbRun => GdbRun.sh} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename EmulatorPkg/Unix/{GdbRun => GdbRun.sh} (100%)
> 
> diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
> similarity index 100%
> rename from EmulatorPkg/Unix/GdbRun
> rename to EmulatorPkg/Unix/GdbRun.sh
> -- 
> 2.21.0.windows.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-03 22:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03 21:54 [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh Michael D Kinney
2019-04-03 22:24 ` jordan.l.justen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox