From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: jordan.l.justen@intel.com)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by groups.io with SMTP; Wed, 03 Apr 2019 15:24:41 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 15:24:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; 
   d="scan'208";a="139779959"
Received: from bkbrooks-mobl.amr.corp.intel.com (HELO localhost) ([10.255.230.254])
  by orsmga003.jf.intel.com with ESMTP; 03 Apr 2019 15:24:40 -0700
MIME-Version: 1.0
In-Reply-To: <20190403215439.15128-1-michael.d.kinney@intel.com>
References: <20190403215439.15128-1-michael.d.kinney@intel.com>
From: jordan.l.justen@intel.com
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, devel@edk2.groups.io
Subject: Re: [Patch] EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>, Michael D Kinney <michael.d.kinney@intel.com>
Message-ID: <155433027462.27290.10106696912134038958@jljusten-skl>
User-Agent: alot/0.8
Date: Wed, 03 Apr 2019 15:24:39 -0700
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

$ git grep GdbRun
EmulatorPkg/Unix/Host/Host.c:  // has a break point script to source the Gd=
bRun script.
EmulatorPkg/Unix/Xcode/xcode_project32/xcode_project.xcodeproj/default.pbxu=
ser:         command =3D "set gInXcode=3D1\nsource ../../../../EmulatorPkg/=
Unix/GdbRun";
EmulatorPkg/Unix/Xcode/xcode_project64/xcode_project.xcodeproj/default.pbxu=
ser:         command =3D "set gInXcode=3D1\nsource ../../../../EmulatorPkg/=
Unix/GdbRun";
EmulatorPkg/build.sh:  /usr/bin/gdb $BUILD_ROOT_ARCH/Host -q -cd=3D$BUILD_R=
OOT_ARCH -x $WORKSPACE/EmulatorPkg/Unix/GdbRun

If those are updated,

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

On 2019-04-03 14:54:39, Kinney, Michael D wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=3D1657
>=20
> Add .sh file extension to the shell script GdbRun so
> changes to this file will pass PatchCheck.py.
>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  EmulatorPkg/Unix/{GdbRun =3D> GdbRun.sh} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename EmulatorPkg/Unix/{GdbRun =3D> GdbRun.sh} (100%)
>=20
> diff --git a/EmulatorPkg/Unix/GdbRun b/EmulatorPkg/Unix/GdbRun.sh
> similarity index 100%
> rename from EmulatorPkg/Unix/GdbRun
> rename to EmulatorPkg/Unix/GdbRun.sh
> --=20
> 2.21.0.windows.1
>=20