From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jordan.l.justen@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 10 Apr 2019 02:16:55 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 02:16:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="336563638" Received: from askirtik-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.188.249]) by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2019 02:16:55 -0700 MIME-Version: 1.0 In-Reply-To: <9d0a2a9b-21b9-de51-c232-c6847d7b03b3@redhat.com> References: <20190409110844.14746-1-anthony.perard@citrix.com> <20190409110844.14746-2-anthony.perard@citrix.com> <9d0a2a9b-21b9-de51-c232-c6847d7b03b3@redhat.com> Cc: Ard Biesheuvel , Julien Grall , xen-devel@lists.xenproject.org To: Laszlo Ersek , anthony.perard@citrix.com, devel@edk2.groups.io From: "Jordan Justen" Subject: Re: [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib Message-ID: <155488781468.19925.8808103067126994195@jljusten-skl> User-Agent: alot/0.8 Date: Wed, 10 Apr 2019 02:16:54 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-04-10 01:48:39, Laszlo Ersek wrote: > On 04/09/19 13:08, Anthony PERARD wrote: > > and remove extra includes of OvmfPlatforms.h. >=20 > (1) In commit messages, please don't rely on the subject line, and the > first paragraph of the body, being read as a single sentence. I think BaseTools/Scripts/PatchCheck.py does try to check that the second line of the commit message is an empty line. Also, https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format -Jordan