From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: jordan.l.justen@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 10 Apr 2019 02:48:29 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 02:48:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="148021016" Received: from askirtik-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.188.249]) by FMSMGA003.fm.intel.com with ESMTP; 10 Apr 2019 02:48:29 -0700 MIME-Version: 1.0 In-Reply-To: <20190409110844.14746-3-anthony.perard@citrix.com> References: <20190409110844.14746-1-anthony.perard@citrix.com> <20190409110844.14746-3-anthony.perard@citrix.com> To: Anthony PERARD , devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v2 02/31] OvmfPkg: Create platform XenOvmf Cc: Laszlo Ersek , Ard Biesheuvel , Julien Grall , xen-devel@lists.xenproject.org, Anthony PERARD From: "Jordan Justen" Message-ID: <155488970861.20447.12525571872411959890@jljusten-skl> User-Agent: alot/0.8 Date: Wed, 10 Apr 2019 02:48:28 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-04-09 04:08:15, Anthony PERARD wrote: > This is a copy of OvmfX64, removing VirtIO and some SMM. >=20 > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. >=20 > Compare to OvmfX64, this patch: >=20 > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITION > - removed: VirtioLib class resolution > - removed: all UEFI_DRIVER modules for virtio devices > - removed: DXE_SMM_DRIVER and SMM_CORE lib class resolutions > - removed: DXE_SMM_DRIVER and SMM_CORE FDF rules > - removed: Everything related to SMM_REQUIRE=3D=3Dtrue > - removed: Everything related to SECURE_BOOT_ENABLE=3D=3Dtrue > - removed: Everything related to TPM2_ENABLE=3D=3Dtrue > - changed: PcdPciDisableBusEnumeration dynamic default flipped to TRUE > - changed: default FD_SIZE_IN_KB to 2M. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/{OvmfPkgX64.dsc =3D> XenOvmf.dsc} | 202 +------------------- I guess we all want our name to be first :), but OvmfXen seems more like the pattern that edk2 uses when making sub-platforms. Also, in some cases we've used !ifdef type things to keep dsc and fdf files common. Would that not be workable here? Maybe it would get too ugly. :\ It could help to prevent having to sync dsc changes across, and prevent changes from being omitted for Xen on accident. -Jordan