From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: Re: [edk2-devel] [PATCH 1/5] OvmfPkg/build.sh: Require QEMU 1.6 or newer and always enable flash
Date: Wed, 10 Apr 2019 13:18:03 -0700 [thread overview]
Message-ID: <155492748366.24518.8207768973811563958@jljusten-skl> (raw)
In-Reply-To: <c122252e-6a88-9552-2098-2fd9c4aa3a1b@redhat.com>
On 2019-04-10 07:16:34, Laszlo Ersek wrote:
> Hi Jordan,
>
> I've asked Phil (CC'd) to review this series in my stead. I'll be happy
> to provide an ACK when Phil gives his R-b (if I should forget, please
> ping me separately).
>
> In the future, please include a cover letter; a cumulative diffstat
> usually helps with the review. (I've had to check all patches to see
> that only build.sh is being modified.)
I did create a cover letter, but then I deleted it. I thought I was
making too much out of it...
>From what I gather, you don't find this script useful, and therefore I
sometimes wonder if I'm the only one that uses it. :)
-Jordan
next prev parent reply other threads:[~2019-04-10 20:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 9:34 [PATCH 1/5] OvmfPkg/build.sh: Require QEMU 1.6 or newer and always enable flash Jordan Justen
2019-04-10 9:34 ` [PATCH 2/5] OvmfPkg/build.sh: Don't automatically -hda qemu parameter Jordan Justen
2019-04-10 9:34 ` [PATCH 3/5] OvmfPkg/build.sh: Move automatic TARGET_TOOLS detection later Jordan Justen
2019-04-10 15:37 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-04-10 19:56 ` Jordan Justen
2019-04-10 9:34 ` [PATCH 4/5] OvmfPkg/build.sh: Add AARCH64/ARM build and qemu support Jordan Justen
2019-04-10 9:34 ` [PATCH 5/5] OvmfPkg/build.sh: Add a cross compiler prefix for AARCH64/ARM Jordan Justen
2019-04-10 14:16 ` [edk2-devel] [PATCH 1/5] OvmfPkg/build.sh: Require QEMU 1.6 or newer and always enable flash Laszlo Ersek
2019-04-10 20:18 ` Jordan Justen [this message]
2019-04-11 7:48 ` Laszlo Ersek
2019-04-10 14:45 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155492748366.24518.8207768973811563958@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox