From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: jordan.l.justen@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 10 Apr 2019 13:18:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 13:18:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,334,1549958400"; d="scan'208";a="134669650" Received: from askirtik-mobl1.amr.corp.intel.com (HELO localhost) ([10.254.188.249]) by orsmga006.jf.intel.com with ESMTP; 10 Apr 2019 13:18:04 -0700 MIME-Version: 1.0 In-Reply-To: References: <20190410093424.20365-1-jordan.l.justen@intel.com> From: "Jordan Justen" Cc: Ard Biesheuvel , Philippe Mathieu-Daudé To: Laszlo Ersek , devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH 1/5] OvmfPkg/build.sh: Require QEMU 1.6 or newer and always enable flash Message-ID: <155492748366.24518.8207768973811563958@jljusten-skl> User-Agent: alot/0.8 Date: Wed, 10 Apr 2019 13:18:03 -0700 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2019-04-10 07:16:34, Laszlo Ersek wrote: > Hi Jordan, >=20 > I've asked Phil (CC'd) to review this series in my stead. I'll be happy > to provide an ACK when Phil gives his R-b (if I should forget, please > ping me separately). >=20 > In the future, please include a cover letter; a cumulative diffstat > usually helps with the review. (I've had to check all patches to see > that only build.sh is being modified.) I did create a cover letter, but then I deleted it. I thought I was making too much out of it... >>From what I gather, you don't find this script useful, and therefore I sometimes wonder if I'm the only one that uses it. :) -Jordan