From: "Jordan Justen" <jordan.l.justen@intel.com>
To: Zhiguang Liu <zhiguang.liu@intel.com>, devel@edk2.groups.io
Cc: Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Add the second console to Emulator
Date: Sun, 28 Apr 2019 21:53:39 -0700 [thread overview]
Message-ID: <155651361916.18471.16527159378922602650@jljusten-skl> (raw)
In-Reply-To: <20190429030425.20556-1-zhiguang.liu@intel.com>
What do you think about this change to the commit message?
EmulatorPkg: Support a second GOP window
Two GOP screens will be created if PcdEmuGop is set in
EmulatorPkg.dsc:
gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window 2"
On 2019-04-28 20:04:25, Zhiguang Liu wrote:
> @@ -51,6 +83,10 @@ BDS_CONSOLE_CONNECT_ENTRY gPlatformConsole[] = {
> (CONSOLE_OUT | CONSOLE_IN)
> },
> {
> +(EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2,
> + (CONSOLE_OUT | CONSOLE_IN)
> + },
> + {
The indentation looks wrong on these lines.
With these fixes:
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
> NULL,
> 0
> }
next prev parent reply other threads:[~2019-04-29 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 3:04 [PATCH] EmulatorPkg: Add the second console to Emulator Zhiguang Liu
2019-04-29 4:53 ` Jordan Justen [this message]
2019-04-29 5:54 ` [edk2-devel] " Zhiguang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155651361916.18471.16527159378922602650@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox